Toss 1.03

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

14:19, 19th Oct 2010
The_Reborn_Devil:

This spell still isn't MUI nor MPI. You also have leaks and you don't need the "Do Nothing".

I would highly recommend looking at the GUI tutorials we have here to learn about leaks, unit groups and how to make MUI spells.

Leaks (memory leaks) occur when you forget to remove certain things like locations that you create. "(Position of TossTarget)" creates a new location and to avoid a leak you need to remove it. This can be done by storing it in a variable and then using custom script to remove it. You must also remember to destroy unit groups after you're done with them.


Status: Rejected until updated
Rating: N/A

PM me or another mod once you've updated this to get it reviewed again. Have a nice day!

 

[Zealon]

Testing now.....

EDIT: unfortunatly there are quite a few problems that need to be addressed, I don't know very much about triggers/spells but I know enough to know that there are issues. Sorry

 

[zv27]

1:This is a bad copy of the original.
2:There are many gaps in the coding.
3:If you already copying it up to be just like the original.

 

[Lambdadelta]

• Not MUI.
• Displays the error message to all players.
• Uses begins casting an ability.
• Stupid icon?
• That Toss is very.. triangular.
• Location Leak abundance.

 

[MortAr]

Triggers, if possible.

 

[light bolt30]

Can you post the triggers here for us to see?

 

[underground4550]

• Not MUI.
• Displays the error message to all players.
• Uses begins casting an ability.
• Stupid icon?
• That Toss is very.. triangular.
• Location Leak abundance.

i didnt make the icon, i just grabed a random one because its not about the icon ... and i dont know how to make it any other way, can you help me make it better?
edit: I fixed the icon, and the text message, I don't know what you mean by triangular. "Location Leak Abundance." What does this mean. Sorry i'm new to this and i want to learn.

Can you post the triggers here for us to see?

i just copied and pasted the triggers, idk the proper way to do it but there ya go.

No comment this is a terribly bad

Explain why its bad, don't say no comment then add an offensive comment.

Wow , don't triple post use edit button.....

There i used to edit button, my first spell, im learning can you give me any other tips?

3 reasons why this user needs some private instructions on how to act in a forum. Reason 1. he does not read the rules (non-mui spell etc) Reason 2. he triple posted. Reason 3. it helps him in a long run.

I just went and re-read it now, i know i should of did it earlier. i actually did try to make it MUI but the trigger didn't work, i don't know how to make this kind of spell MUI.

Use trigger tags around the triggers you posted...
[TRIGGER and /TRIGGER]

learn hashtables or indexing or structs
(you can use the tutorials section to learn

Comments on the spell:

-Spell is not MUI-
-I suggest changing the .02 seconds to .03-
-uses waits, changed that-
-Dont use imported materials if not badly needed-

Location Leak Abundance means that your spell leaks many locations... Go to the tutorials section to learn about leaks...

Toss is triangular - I think he means that your toss forms a triangle instead of an arc...

Note: maybe add some more originality, coz some people dislike replicated DotA spells... you can add a stun effect or something else...

Thanks a lot, ill do changes asap, ill read the tutorials, and learn how to arc instead of triangular. Ill try to get a blizzard icon as well, and originality.

I'm not sure but I do believe that in Dota, this skill doesn't pick unit randomly but it pick the nearest unit. If it pick random unit in area, this skill will be a garbage skill that no one want to play because of its difficulty to use. (In playing there are usually 2-4 unit in 250 within casting area so it will be only 25% to pick the specific unit)

Hope fix. Will rate after update. + Will be pleased if you correct me if I'm wrong

Sorry but you are wrong, in DotA it grabs a "Nearby Unit" it doesn't state that it is grabing the closest unit, and i know for a fact that it doesn't grab the closest unit because I've played Tiny several times.

well apart from the obvious which has already been said, all I have really to say it to use a parabola for a much smoother effect

to work out a parabola you need to do the following formula:

(4 * Max height of parabola / Max distance) * (Max distance - currant distance) * (Currant distance / Max distance) = Currant fly height

so more or less, everytime you move the unit using the loop you set variables to how far it's moved and when it's cast you set how high u want the unit go and how far it'll go as a total. then set a variable to the above formula then set the units fly height to the variable and you're effect will be so much smoother.

I tried using the formula, and I think i did something wrong because it didn't work. Max height of parabola. is that the max height that i choose? i chose 700.

Formula

• Animation - Change Tossee flying height to ((4.00 x ((Real(TossHeight)) / (Real(TossDistance)))) x (((Real(TossDistance)) - (Distance between TosserPoint and (Position of TossTarget))) x ((Distance between TosserPoint and (Position of TossTarget)) / (Distance between TosserPoint and TossTargetPoint))) at 1500.00

Edit: I learnt how to do parabolas in school now, so i have a better understanding of it, and i took the formula that he gave me and attempted to use it, it worked, but i'm sure that your formula is much better if i understood it, thanks anyways.

My Formula

• Set TossHeight = (((500.00 / (Real(TossMidDistance))) x (Power((TossRemainingDistance - (Real(TossMidDistance))), 2.00))) + 500.00)
• If (TossRemainingDistance Less than or equal to (Real(TossMidDistance))) then do (Set TossHeight = ((1.00 / TossHeight) x -1.00)) else do (Do nothing)

please put a changelog so that we'll easily know what you changed with each updates...

Lol, i have a changelog, i've had one since 1.01. Please don't post useless comments

 

[Klingo]

Wow , don't triple post use edit button.....

 

[aaron]

3 reasons why this user needs some private instructions on how to act in a forum. Reason 1. he does not read the rules (non-mui spell etc) Reason 2. he triple posted. Reason 3. it helps him in a long run.

 

[Adiktuz]

Use trigger tags around the triggers you posted...
[TRIGGER and /TRIGGER]

learn hashtables or indexing or structs
(you can use the tutorials section to learn

Comments on the spell:

-Spell is not MUI-
-I suggest changing the .02 seconds to .03-
-uses waits, changed that-
-Dont use imported materials if not badly needed-

Location Leak Abundance means that your spell leaks many locations... Go to the tutorials section to learn about leaks...

Toss is triangular - I think he means that your toss forms a triangle instead of an arc...

Note: maybe add some more originality, coz some people dislike replicated DotA spells... you can add a stun effect or something else...

 

[Zealon]

well, at least you are tring

 

[Bankde]

Unit Group - Add all units of (Units within 250.00 of (Position of Tosser)) to Tossable
Unit Group - Remove Tosser from Tossable
Set Tossee = (Random unit from Tossable)

I'm not sure but I do believe that in Dota, this skill doesn't pick unit randomly but it pick the nearest unit. If it pick random unit in area, this skill will be a garbage skill that no one want to play because of its difficulty to use. (In playing there are usually 2-4 unit in 250 within casting area so it will be only 25% to pick the specific unit)

Hope fix. Will rate after update. + Will be pleased if you correct me if I'm wrong

 

[Tank-Commander]

well apart from the obvious which has already been said, all I have really to say it to use a parabola for a much smoother effect

to work out a parabola you need to do the following formula:

(4 * Max height of parabola / Max distance) * (Max distance - currant distance) * (Currant distance / Max distance) = Currant fly height

so more or less, everytime you move the unit using the loop you set variables to how far it's moved and when it's cast you set how high u want the unit go and how far it'll go as a total. then set a variable to the above formula then set the units fly height to the variable and you're effect will be so much smoother.

 

[Zealon]

Testing the map, It gets a little annoying because as soon as the map begins, you are surrounded by many wolves and its hard to get out of all the chaos! your mountain giants die too fast, and there are too many of them as well. Everything keeps dieng and resurecting, and its hard to test it.

Make the map bigger, then make some acceptable terrain, then make two mountain giants to test with, make it that they have 100000000 health, with 10000000 hp regeneration, and give them the ability of course. Then make groups of creeps around the map that resurect if killed, after a few seconds. Don't make them start where you do, just nearby. That way its easier on all of us

Heres a small example: http://www.hiveworkshop.com/forums/spells-569/fan-knives-v1-1-a-146574/?prev=search%3Dfan%26d%3Dlist%26r%3D20

Just some advice, you don't have to listen to me.

 

[Adiktuz]

please put a changelog so that we'll easily know what you changed with each updates...

 

[Bankde]

I would suggest you to make it MUI FIRST <<<<<< before update anything else

Or... you will have a terrible dream at the end with the hundred of variables waiting for you.

Besure to remove leak before doing anything else. (Or it will stack up which is hard to solve)
Point >> Leak (call RemoveLocation)
UnitGroup >> Leak (call DestroyGroup)
Special effect >> Leak (MUST always destroy after creating them)

If you don't really know where is leak, go here. http://www.hiveworkshop.com/forums/tools-560/leak-check-1-3-a-62951/

 

[tjordell]

underground, To be honest, there is no easy way to get it MUI or MPI with Waits. You do need to create a way around the waits. Meaby a loop trigger which adds the time to a variable and a condition to checks if the time is equal to the ordinary wait time. That's the easiest way I know.