[Trigger] Timer window doesn't show timer's time

Vladadamm · Apr 19, 2012

So, i have that :

Timer - Start (Load 10 of (Key (Triggering unit)) in Hash) as a Un coup timer that will expire in (Respawn_Time + ((Real((Hero level of (Triggering unit)))) x Respawn_Increment)) seconds
Timer - Create a timer window for (Last started timer) with title Respawn time :
Timer - Show (Last created timer window) for (Triggering player)

The timer is created, the window too. But the problem is that the window doesn't show timer's remaining time.

-Kobas- · Apr 19, 2012

(Last started timer) will return null,

JASS:

function GetLastCreatedTimerBJ takes nothing returns timer
    return bj_lastStartedTimer
endfunction

because when you saved timer you didn't set global variable.

Before this your code add this line:
set bj_lastStartedTimer = LoadTimerHandle(udg_Hash, GetHandleId(GetTriggerUnit()), 10)
And it should work, you can then use Last started timer to start timer as well in your first line.

Vladadamm · Apr 19, 2012

I don't think it's the problem, cause when i tried the trigger with that :

Timer - Create a timer window for (Load 10 of (Key (Triggering unit)) in Hash) with title Respawn time :

also, your jass line gave me a compilation error.

Starquizer · Apr 19, 2012

Vladadamm said:
I don't think it's the problem, cause when i tried the trigger with that :

Timer - Create a timer window for (Load 10 of (Key (Triggering unit)) in Hash) with title Respawn time :

also, your jass line gave me a compilation error.

Make sure you are not creating a Timer Window at map initialization.

-Kobas- · Apr 19, 2012

Vladadamm said:
I don't think it's the problem, cause when i tried the trigger with that :

Timer - Create a timer window for (Load 10 of (Key (Triggering unit)) in Hash) with title Respawn time :

also, your jass line gave me a compilation error.

Sry I write hash instead of udg_Hash, try it now: set bj_lastStartedTimer = LoadTimerHandle(udg_Hash, GetHandleId(GetTriggerUnit()), 10)

Starquizer said:
Make sure you are not creating a Timer Window at map initialization.

In that case window won't be created at first place.

Hmmm can you show whole trigger?

1 more things, timer must be created at some point, maybe you forget to create it, and Load function returned null.

Vladadamm · Apr 19, 2012

You're solution don't work.

Star, if you look actions, you can see that it's not started at map init since i use triggering unit.

So, here is whole trigger :

Death
- EvÃ©nements
  - UnitÃ© - A unit Meurt
- Conditions
  - ((Dying unit) is Un hÃ©ros) Egal Ã TRUE
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - Si - Conditions
      - ((Killing unit) belongs to an enemy of (Triggering player)) Egal Ã TRUE
    - Alors - Actions
      - Set TempInt = (Random integer number between 1 and 4)
      - Partie - Display to (All players) the text: ((Name of (Owner of (Killing unit))) + (KillsStrings[TempInt] + ((Name of (Triggering player)) + (KillsStrings2[TempInt] + ((String((KillGold_Basic + ((Hero level of (Triggering unit)) x KillGold_Increment)))) + !)))))
      - Joueur - Add (180 + ((Hero level of (Triggering unit)) x KillGold_Increment)) to (Owner of (Killing unit)) Or actuel
      - Joueur - Add -50 to (Triggering player) Or actuel
    - Sinon - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        Si - Conditions
        
        (Triggering player) Egal Ã (Owner of (Killing unit))
        
        Alors - Actions
        
        Set TempInt = (Random integer number between 1 and 3)
        
        Partie - Display to (All players) the text: ((Name of (Triggering player)) + SuicideStrings[TempInt])
        
        Sinon - Actions
        
        Set TempInt = (Random integer number between 1 and 1)
        
        Partie - Display to (All players) the text: ((Name of (Owner of (Killing unit))) + (DenyStrings[TempInt] + ((Name of (Triggering player)) + !)))
  - Groupe unitÃ© - Add (Triggering unit) to Rez_Group
  - Compte Ã rebours - Start (Load 10 of (Key (Triggering unit)) in Hash) as a Un coup timer that will expire in (Respawn_Time + ((Real((Hero level of (Triggering unit)))) x Respawn_Increment)) seconds
  - Custom script: set bj_lastStartedTimer = LoadTimerHandle(udg_Hash, GetHandleId(GetTriggerUnit()), 10)
  - Compte Ã rebours - Create a timer window for (Last started timer) with title Respawn time :
  - Compte Ã rebours - Montrer (Last created timer window) for (Triggering player)
  - Table de hachage - Save Handle Of(Last created timer window) as 11 of (Key (Triggering unit)) in Hash
  - Table de hachage - Save (Respawn_Time + ((Real((Hero level of (Triggering unit)))) x Respawn_Increment)) as 12 of (Key (Triggering unit)) in Hash
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - Si - Conditions
      - (Respawn <gen> is on) Egal Ã FALSE
    - Alors - Actions
      - DÃ©clencheur - Turn on Respawn <gen>
    - Sinon - Actions

-Kobas- · Apr 19, 2012

I don't see line where you created timer?
Where you saved timer at first place?

Vladadamm · Apr 20, 2012

Compte Ã rebours - Start (Load 10 of (Key (Triggering unit)) in Hash) as a Un coup timer that will expire in (Respawn_Time + ((Real((Hero level of (Triggering unit)))) x Respawn_Increment)) seconds
Custom script: set bj_lastStartedTimer = LoadTimerHandle(udg_Hash, GetHandleId(GetTriggerUnit()), 10)
Compte Ã rebours - Create a timer window for (Last started timer) with title Respawn time :
Compte Ã rebours - Montrer (Last created timer window) for (Triggering player)
Table de hachage - Save Handle Of(Last created timer window) as 11 of (Key (Triggering unit)) in Hash

Here are all actions related to the timer.

I didn't saved the timer, i've just created and started it.

Troll-Brain · Apr 20, 2012

Well, i'm not sure i can read correctly GUI actually, but it seems you attemp to use a timer stored in an hashtable.

Code:

Compte Ã rebours - Start (Load 10 of (Key (Triggering unit)) in Hash)

So if a created timer is not stored there in the first place, it should use a null timer, so it would explain why it doesn't work.

Vladadamm · Apr 20, 2012

If i try to use a timer stored in an hashtable, or in a variable, it makes no difference; it still don't works.

-Kobas- · Apr 20, 2012

Here you go small library that will do job with timers dialogs for you

You can still do regular things with timers all you need to do is to use custom script and player id (jass player 0 (red) == gui player 1 (red)).
Also you can create GUI timer variable and just use something like this in custom script:
set udg_YOUR_TIMER_VARIABLE = RT[0] <<<< Timer created for red player.
and then use udg_YOUR_TIMER_VARIABLE in gui triggers easily

JASS:

library RespawnTimer
    globals
                timer array       RT
                timerdialog array RTD
        
        private boolean array     B
        private hashtable         HASH = InitHashtable()
    endglobals
    
    private function FlushExpiredTimer takes nothing returns nothing
        local integer id = GetHandleId(GetExpiredTimer())
        call DestroyTimer(      LoadTimerHandle(      HASH, id, 0))
        call DestroyTimerDialog(LoadTimerDialogHandle(HASH, id, 1))
        set B[LoadInteger(                            HASH, id, 2)] = false
        call TriggerExecute(LoadTriggerHandle(        HASH, id, 3))
        /**/call BJDebugMsg("Debug: Timer Dialog Destroyed for player: " + GetPlayerName(Player(LoadInteger(HASH, id, 2))))
        call FlushChildHashtable(HASH, id)
    endfunction
    
    function CreateRespawnTimer takes player owner, string title, real timeout, boolean show, trigger trig returns nothing
        local integer id = GetPlayerId(owner)
        if not B[id] then
            set B[id] = true
            set RT[id]  = CreateTimer()
            set RTD[id] = CreateTimerDialog(RT[id])
            call SaveTimerHandle(        HASH, GetHandleId(RT[id]), 0, RT[id] )
            call SaveTimerDialogHandle(  HASH, GetHandleId(RT[id]), 1, RTD[id])
            call SaveInteger(            HASH, GetHandleId(RT[id]), 2, id     )
            call SaveTriggerHandle(      HASH, GetHandleId(RT[id]), 3, trig   )
            call TimerStart(RT[id], timeout, false, function FlushExpiredTimer)
            call TimerDialogSetTitle(RTD[id], title)
            if show then
                call TimerDialogDisplay(RTD[id], true)
            endif
            /**/call BJDebugMsg("Debug: Timer Dialog is created for: " + GetPlayerName(owner))
        else
            /**/call BJDebugMsg("Debug: Timer Dialog is already created for: " + GetPlayerName(owner))
        endif
    endfunction
endlibrary

+

Test
- Events
  - Player - Player 1 (Red) skips a cinematic sequence
- Conditions
- Actions
  - Custom script: call CreateRespawnTimer(Player(0), "Example" , 5.00 , true, gg_trg_Test_2 )
  - Custom script: call CreateRespawnTimer(Player(1), "Example" , 7.00 , true, gg_trg_Test_3 )

+

Test 2
- Events
- Conditions
- Actions
  - Unit - Create 1 Footman for Player 1 (Red) at (Center of (Playable map area)) facing Default building facing degrees

+

Test 3
- Events
- Conditions
- Actions
  - Unit - Create 1 Priest for Player 2 (Blue) at (Center of (Playable map area)) facing Default building facing degrees

Vladadamm · Apr 20, 2012

Your library doesn't fit what i want to do with the timer.

Also, it complicates things for only 1timer in the map.

-Kobas- · Apr 20, 2012

Ok I give up.

Troll-Brain · Apr 20, 2012

We are not in your mind, if you don't post your attempts, we can't guess what's wrong.
So far, it seems that you are not using any timer, that's not because you use an hashtable that magically it creates a timer for you.
Create a timer, and then store it in the hashtable if you want.

You can link a timer and a timer window, but it's not because you create a timer window that creates automatically a timer as well, you have to do it yourself.

Vladadamm · Apr 20, 2012

Already tried what you said. It doesn't works too.

Starquizer · Apr 20, 2012

Vladadamm said:
Already tried what you said. It doesn't works too.

Could you attach the map ?

Troll-Brain · Apr 20, 2012

Vladadamm said:
Already tried what you said. It doesn't works too.

You still have not shared the code ...

Really, you're just doing something wrong, you're either not understanding what i meant or something else, but we can't guess.

Vladadamm · Apr 21, 2012

Vladadamm said:
Death

EvÃ©nements

UnitÃ© - A unit Meurt

Conditions

((Dying unit) is Un hÃ©ros) Egal Ã TRUE

Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

Si - Conditions

((Killing unit) belongs to an enemy of (Triggering player)) Egal Ã TRUE

Alors - Actions

Set TempInt = (Random integer number between 1 and 4)

Partie - Display to (All players) the text: ((Name of (Owner of (Killing unit))) + (KillsStrings[TempInt] + ((Name of (Triggering player)) + (KillsStrings2[TempInt] + ((String((KillGold_Basic + ((Hero level of (Triggering unit)) x KillGold_Increment)))) + !)))))

Joueur - Add (180 + ((Hero level of (Triggering unit)) x KillGold_Increment)) to (Owner of (Killing unit)) Or actuel

Joueur - Add -50 to (Triggering player) Or actuel

Sinon - Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

Si - Conditions

(Triggering player) Egal Ã (Owner of (Killing unit))

Alors - Actions

Set TempInt = (Random integer number between 1 and 3)

Partie - Display to (All players) the text: ((Name of (Triggering player)) + SuicideStrings[TempInt])

Sinon - Actions

Set TempInt = (Random integer number between 1 and 1)

Partie - Display to (All players) the text: ((Name of (Owner of (Killing unit))) + (DenyStrings[TempInt] + ((Name of (Triggering player)) + !)))

Groupe unitÃ© - Add (Triggering unit) to Rez_Group

Compte Ã rebours - Start (Load 10 of (Key (Triggering unit)) in Hash) as a Un coup timer that will expire in (Respawn_Time + ((Real((Hero level of (Triggering unit)))) x Respawn_Increment)) seconds

Custom script: set bj_lastStartedTimer = LoadTimerHandle(udg_Hash, GetHandleId(GetTriggerUnit()), 10)

Compte Ã rebours - Create a timer window for (Last started timer) with title Respawn time :

Compte Ã rebours - Montrer (Last created timer window) for (Triggering player)

Table de hachage - Save Handle Of(Last created timer window) as 11 of (Key (Triggering unit)) in Hash

Table de hachage - Save (Respawn_Time + ((Real((Hero level of (Triggering unit)))) x Respawn_Increment)) as 12 of (Key (Triggering unit)) in Hash

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

Si - Conditions

(Respawn <gen> is on) Egal Ã FALSE

Alors - Actions

DÃ©clencheur - Turn on Respawn <gen>

Sinon - Actions

Here it is.

Troll-Brain · Apr 21, 2012

Ok, i give up.
I've already explained what's wrong.

Starquizer · Apr 21, 2012

Try uploading the map, may be you missed something.

[Trigger] Timer window doesn't show timer's time

Attachments

Similar threads