This map lag a lot!!! Help...

[sephiroth1234]

Please check the map below. I used MemoryLeakHelper in this map, why do special effects leak even if I clean them? I always type debug and it shows that it leaks 15 and above special effects per second.

 

[Odellia]

Why would you depend on the program? Besides from conserving time, but just doing it the manual way helps you more because you also learn how to clean leaks. I'm going to edit this post after I am done checking your triggers.

Hellfire Blaze Spell :

Hellfire Blaze Start

-

• Unit Group - Add (Casting unit) to HellfireBlazeCasters

- Don't use Casting Unit, use Triggering Unit.

Hellfire Blaze Explosion

- I dont see any obvious leaks here.

Hellfire Blaze Start Stop

- Unit Group -

• Remove (Casting unit) from HellfireBlazeCasters

- Don't use Casting Unit, use Trigger Unit.

I don't see any obvious leaks at all, you need to change all Casting Units to Triggering Unit. I do not understand the part "Why do special effects leak even if I clean them?" I tried understanding it, but I think its the softwares problem not yours, I saw all of your special effects is destroyed after you used them.

Also, the dying unit, change it also to Triggering Unit.

 

[ap0calypse]

I didn't see any heavy leaks (although you could null some variables).
Don't use MemoryLeakHelper, use your head...

And don't use every 0.01 seconds, use every 0.03 seconds (it will definitely save a lot of lag).
Another thing you can do: turn off ALL loop-triggers and only turn them on once the ability is cast.
When the ability is done, check if anyone else is casting it, if nobody is casting it, turn the loop-trigger off again.

I didn't check all triggers, and not thoroughly though, just rapidly checked most of them.

 

[defskull]

As said by ap0, 0.01 and 0.03 makes a BIG different

 

[sephiroth1234]

Special effects I shall say, when I type call DisplayLeaks() in the MemoryLeakHelper, it shows special effect leaks even if I destroy them after the special effect action like this:

• SPECIAL EFFECT
  • Events
  • Conditions
  • Actions
    • Special Effect - Create special effect at foot of (Unit) using <SPECIAL EFFECT>
    • Special Effect - Destroy (Last created special effect)

 

[The_DooM]

Try putting the special effects to variables and then destroy them. Create special effect then, Set SpecialEffect(Variable)=Last Created Special Effect, then destroy SpecialEffect and then Custom Script call DestroyEffect (udg_SpecialEffect). Try that, hope it helps

 

[sephiroth1234]

Like this?

• SPECIAL EFFECT
  • Events
  • Conditions
  • Actions
    • Special Effect - Create special effect at foot of (Unit) using <SPECIAL EFFECT>
    • Set VARIABLE = (Last created special effect)
    • Special Effect - Destroy (VARIABLE)

 

[The_DooM]

Sorry, was afk Yeah, just add a Custom Script like this:

• Actions
  • Special Effect - Create a special effect attached to the foot of (Unit) using <SPECIAL EFFECT>
  • Set Variable = (Last created special effect)
  • Special Effect - Destroy Variable
  • Custom script: call DestroyEffect (udg_Variable)

Hope it helps

 

[ap0calypse]

That's... absolutely pointless.

Please DON'T listen to/use MemoryLeakHelper, use your OWN head!
You don't need a program to do everything for you... it doesn't leak, that's all you should know.

Also, don't use variables and custom scripts for special effects, it only makes the coding worse (more lines -> less efficient -> drains more CPU + file size).


There IS one thing though:

It's either this:

• Special Effect - Create a special effect at (Position of (Unit)) using <SPECIAL EFFECT>

Or this:

• Special Effect - Create a special effect attached to the foot of (Unit) using <SPECIAL EFFECT>

Your action doesn't exist ("Create special effect at foot of (Unit)").
If it is the first one: it does leak, it leaks a location.
If it's the second one: it doesn't leak.


For easy trigger copy/pasting: right-click anything in the trigger editor and select "copy as text", then you can paste it here.
(Additionally, you can click the trigger's header to CnP the entire trigger, or Events/Conditions/Actions to CnP eiter one of them).

 

[sephiroth1234]

Or can I use dummy units and order them to cast a spell(to create the special effect)? That is the only thing efficient I can do to prevent leak(s).

 

[ap0calypse]

No, lol

Just use this:

• Set TempLoc = (Position of (Unit))
• Special Effect - Create a special effect at TempLoc using <SPECIAL EFFECT>
• Custom script - call RemoveLocation(udg_TempLoc

...and this for all special effects you have (which aren't attached to units).
It removes the leaks

 

[tjordell]

ap0, You forgot that he need to destroy the Special Effect AND the leak. Do it with "Special Effect - Destroy Last Created Special Effect".

 

[ap0calypse]

ap0, You forgot that he need to destroy the Special Effect AND the leak. Do it with "Special Effect - Destroy Last Created Special Effect".

Well, he already did that in his previous triggers, so I thought that he could figure that one out himself ^^
You're right though

 

[sephiroth1234]

TY again for the time...... +rep!!!