Terrain Kill System v1.2

[Moderator]

Approved

The system seems to work quite well. It could check into 8 directions for more accuracy, but that would make the script heavier.
You could add a configurable variable for that.

Old reviews

I strongly recommend using a hashtable for the system as the number of loops
you do with an array solution increases rapidly when more deadly terrain
types are added. You can leave as it is but it will cost you in rating.
You leak loc1.
The looping trigger should be turned off when the group is empty. You could trigger it
or explain it somewhere.
If your system requires there to be deadly terrain on all sides for the unit to die, then it is enough if there is a safe terrain on one side.
Use that thought to optimize the loop.

Add support for multiple deadly terrain types.
A hashtable will prove to be useful there, save a boolean using the
terrain type as a parent key. Check if the boolean exists or not in
the looping trigger.
The logic in the looping trigger can be improved.
The looping trigger doesn't need to update that often.
You don't need to use an array for the locations.

 

[rulerofiron99]

Very simple system.

• You shouldn't have to use a point to get a terrain type. Do this:
  
  • Set DeathTerrainType = Lordaeron Fall - Rock
• You should allow multiple terrain types. Change DeathTerrainType to an array and check for each one.
• Your location variable shouldn't be an array, rather use Loc1, Loc2.
• You should explain that units need to be added to the unit group.
• You're only checking 3 points around the hero. You should rather loop from 1 to 4 to check for 4 points. In fact, you should rather loop from 1 to 8 and change the angle to 45.
• This:
  
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Terrain type at Loc[2]) Not equal to DeathTerrain
    • Then - Actions
      • Set HeroOnPath = True
    • Else - Actions
      • Custom script: call RemoveLocation(udg_Loc[2])
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • HeroOnPath Equal to False
    • Then - Actions
      • Unit - Kill TKUnit
      • Set TKUnit = No unit
    • Else - Actions
  should be changed to this:
  
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Terrain type at Loc[2]) Not equal to DeathTerrain
      • (TKUnit is alive) Equal to True
    • Then - Actions
      • Unit - Kill TKUnit
      • Set TKUnit = No unit
    • Else - Actions
      • Custom script: call RemoveLocation(udg_Loc[2])

 

[Wrda]

I did a mistake at 3 points, I wanted to put 4 not 3, so I'm going to put 0 to 3.
Going to fix later.
Yes this is a simple system, but there was no such system like this in hive so I just uploaded this simple system and can be useful for players who do maze, slide and escape maps.
edit since the death terrain type can be changed along the maze or other maps, i put a location so it's easier than finding the correct terrain type.

 

[rulerofiron99]

I did a mistake at 3 points, I wanted to put 4 not 3, so I'm going to put 0 to 3.
Going to fix later.
Yes this is a simple system, but there was no such system like this in hive so I just uploaded this simple system and can be useful for players who do maze, slide and escape maps.

What I meant by simple is that it's something people can make quite easily.

Although you do have a point in it being useful; I've seen someone create 360 regions, each with its own trigger, just for this effect.

Please consider making different terrain types, and maybe something like a timer to death, if a unit returns to safe terrain in that time they don't die.

 

[Vladadamm]

What I meant by simple is that it's something people can make quite easily.

Although you do have a point in it being useful; I've seen someone create 360 regions, each with its own trigger, just for this effect.

Please consider making different terrain types, and maybe something like a timer to death, if a unit returns to safe terrain in that time they don't die.

Mazers usually put 500 regions with one trigger ^^".

The timer to death is useless, it is meant to be used in Mazes and Slides, and in mazes and slides, when you touch the death terrain, you die.

Also, Wrda, isn't it Checkpath and not Terrain Kill ? And it's a vSex/Tolerant one, not a normal one (normal ones don't have offset ^^")

 

[polardude]

why not make it easy like

Terrain Kill
Events
Time - Every 0.20 seconds of game time
Conditions
Actions
Unit Group - Pick every unit in (Units of type Escaper) and do (Actions)
Loop - Actions
Set Position = (Position of (Picked unit))
Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain type at Position) Equal to (==) Underground - Dirt
Then - Actions
Unit - Kill (Picked unit)
Else - Actions
Do nothing

 

[Vladadamm]

why not make it easy like

Terrain Kill
Events
Time - Every 0.20 seconds of game time
Conditions
Actions
Unit Group - Pick every unit in (Units of type Escaper) and do (Actions)
Loop - Actions
Set Position = (Position of (Picked unit))
Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain type at Position) Equal to (==) Underground - Dirt
Then - Actions
Unit - Kill (Picked unit)
Else - Actions
Do nothing

He haven't done a simple Check Path, he did a Tolerant one, which is not the same thing ^^'

 

[Wrda]

why not make it easy like

Terrain Kill
Events
Time - Every 0.20 seconds of game time
Conditions
Actions
Unit Group - Pick every unit in (Units of type Escaper) and do (Actions)
Loop - Actions
Set Position = (Position of (Picked unit))
Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain type at Position) Equal to (==) Underground - Dirt
Then - Actions
Unit - Kill (Picked unit)
Else - Actions
Do nothing

The only reason i didnt do this, is because in mazes and slides, erm, this is hard to explain without a screenshot..., well, through the maze, you see a diagonal terrain, like this / \
Without making offsets, that part would be too hard for units passing it, terrain kill without offests should ONLY be used in escape maps.
Edit: event with every 0.20 seconds of game time is too slow for updating the locations to make units die when they are out of path...

 

[polardude]

The only reason i didnt do this, is because in mazes and slides, erm, this is hard to explain without a screenshot..., well, through the maze, you see a diagonal terrain, like this / \
Without making offsets, that part would be too hard for units passing it, terrain kill without offests should ONLY be used in escape maps.
Edit: event with every 0.20 seconds of game time is too slow for updating the locations to make units die when they are out of path...

will if you get it to 0.03 it can wrok i try to make a small escape map is find and nice to use ;D

and if you whant to use other terrain then Underground - Dirt then you can use pick one and it seems to wrok find

 

[Wrda]

Updated the system.