TasUnitBonus

[Antares]

This is a new system or moved from Code Archive?

 

[Tasyen]

This is a new system or moved from Code Archive?

This is a new system.

 

[Produtor]

Another one of Tasyen's subscription systems, I wish Blizzard had the same dedication to Warcraft as you and the community here at Hivework Shop.

Apparently it adds a skill that has a bonus that it will increase to the Hero, but how does it increase CastPoint and CastBackswing?

And another thing, will there be a Jass version?

 

[Tasyen]

And another thing, will there be a Jass version?

I will not make a vjass version of this. vjass cant do this dynamic function mapping which is a core feature.

but how does it increase CastPoint and CastBackswing?

castpoint and castbackswing are unit stats when an ability is gained the ability copies the unit's current castpoint & castbackswing values.
To make already owned abilities be cast faster you would change the unit castpoint then lose the castable spells from the unit and readd them.

Edit: would be easier when one would have the ability_RealFields for castpoint but sadly no, so only doable by readding spells.

 

[Tasyen]

Updated to V1.2b)
Added the addon TasUnitBonusHero, I forgot to port it from my map.
TasUnitBonus.UnitAdd does not use numbers as key anymore. "1" is still allowed 1 not.
TasUnitBonusHero manages TasUnitBonuses on level ups for any hero [0] and [unit] and [RawCode].

TasUnitBonusHero[FourCC'Hpal'] = { -- paladin levelup Bonus
 Str = 1
 ,["DMG+"] = 5 -- gain 5 Bonus ATK every LevelUp
 ,[2] = { Ability = FourCC'AHbz'} -- at level 2 add Blizzard
 ,[4] = {["STR+"] = 12}
}

Edit:
V1.2c)
fixed serious bugs of TasUnitBonusHero.

 

[alex1989]

You're so talented, I also wish I knew how to make an off-screen interface like that, but this is way beyond my level, like the photo I posted, you can do for those positions is add a container Hero's items?

 

[Tasyen]

You're so talented,

I trained many years. in gui, then java and some other none warcraft 3 stuff, after that jass, then i trained Lua and warcraft 3 custom UI (was quite bad at some point in that subject). But y, I guess have talent for some parts of math/order.
TasUnitBonus is the result of systems, I wrote before, some not public released and only for my map or as a experiment. In that systems I encountered the problem that I needed to give unit stats and so I came to this idea. My Talent system is one of these concept-ancestors it has a stat systems by Lua tables.

One can create many types of ui but warcraft 3 frames are based on rectangles -> images are easier than models. One can create a custom ui with buttons to contain: items like a bag, yes. I made such and some others did as well. Making more default item/command/hero buttons is not doable with the ui-frame api. In such a case one would need to recreate the whole feature.

TasItemBag

Introduction TasItemBag is a custom UI system/addition for Warcraft 3 V1.31 or higher, in vjass or Lua. It adds additional item storage. An unit can still only equip 6 items (use their boni). Details The storage UI is a grid of buttons, each contains upto one item. One can scroll up and down by...

www.hiveworkshop.com

TasInventoryEx

Introduction TasInventoryEx is a custom UI system/addition for Warcraft 3 V1.31 or higher, In vjass or Lua. With it heroes can equip more items (use item-boni). There is a version (jass or vjass) for Warcraft 3 V1.26 without customUI, using an Unit as substitude. Details The storage UI is a...

www.hiveworkshop.com

Inventory v1.0.8

Inventory by SmitingDevil * Introduction * Code * Screenshots * How to Import * Changelog * Credits Introduction This is a simple system with the following features: Compatibility with the default inventory Drag and drop items - Move items from custom inventory to default one and vice...

www.hiveworkshop.com

The image shows TasCheatbox, if one wonders, i added that as demo to have some tester super powers like dispel buffs and such.
normaly the 3 & 4 page would create items & units but in this map the were replaced with "cheats" using TasUnitBonus.

 

[Tasyen]

Updated to V1.3)
added 4 prebuilt stats

2 over skills
"PRIMARY+"
"LIFE_STEAL+" item lifesteal

2 but they dont work in V1.31.1 cause they use Unit Weaponfields.
AttackRange
AttackRangeR

AttackRangeR is AttackRange but wont do anthing if the unit is not ranged.

improved AbilityInc
now should be able to decrease current level like key Ability with a -value.

What common important stat is missing?

Ported another addon TasUnitBonusItemTooltip. Updates item tooltips to include the stats given by that item + itemCode. Items only use this feature when you call it onto it.
TasUnitBonusItemTooltip(item)

TasUnitBonusItemTooltip replaces a placeholder: There are 2 options.
$ replaces all tooltip
$item inser the StatList here keep the rest as it is.

I think all addons for TasUnitBonus are now ported.

 

[Tasyen]

I think all addons for TasUnitBonus are now ported.

I was wrong. Still got one that gives TasUnitBonus when a hero learns a skill. But I cant port the version from my map, it has weird featues and was constructed for 1 level skills only that give another bonus after dozens of levels and maybe (also/only) affecting other units.

Could make an simpler version that works kinda like TasUnitBonusHero. Would then be called TasUnitBonusLearn.

Edit:
Updated, includes now the addon TasUnitBonusLearn, should be suited for the normal warcraft 3 Learning system.
TasUnitBonusLearn uses the same format as TasUnitBonusHero it does not have the any key with 0 and instead of hero level, skill levels matter, it also can be called from the outside.
TasUnitBonusLearnAction(unit, spellCode, learnedLevel)

TasUnitBonusLearn[FourCC'AHhb'] = { -- HolyLight
  ["DMG+"] = 3 -- 3 Bonus ATK every time Skilled
 ,[2] = { Str = 10} -- Skilling level 2 10 base Str
}

 

[Tasyen]

Applied a small Fix V1.4)
the key AttackRange of TasUnitBonus wrongly used udg_Unit the demo map test unit.

 

[Antares]

Adds a new supported type by key the function runs when a request to add to this key.
The function needs to do the inc.
instead of a function you can give an already existing key to make key do the same.

I don't know what that means.

Please use an AI assistant like ChatGPT to help you with the translation or have someone help you with the documentation. I'm sure there are a lot of people who would be happy to.

The description in the OP is fine, but for the comments in the code, I just don't know what it's trying to tell me.

It doesn't help that the formatting is all messed up. It looks like the scope in TasUnitBonus is closed on line 34. Please fix the indentation and add some empty lines.

I'm sure the code itself is superb as always, but we're trying to be more stringent when it comes to documentation, as to increase the accessibility of this section.

Awaiting Update

 

[Tasyen]

Updated to V1.5)
improved api comments
key Ability; ability survives morphs
seperated TasUnitBonusSkill more from TasUnitBonus
Added Key Tech, it increases/decreases a Research by 1.

TasUnitBonusHero mentions that a Hero benefits from upto 3 tabels at once [0] [GetUnitTypeId] & [unit]
TasUnitBonusItem mentions that an item supports boh at the same time [GetItemTypeId] & [item]

 

[Regno]

Can have jass? (no vJass)

 

[Tasyen]

I will not make a (v)jass version of TasUnitBonus.

 

[Tasyen]

Updated to V1.6)
List bases Types below the TasUnitBonus function.

Ability, AbilityInc & Tech now do the FourCC when needed and work better in TasUnitBonus.UnitAdd.

Added addon TasUnitBonusBuffTable a "clone" of TasUnitBonusBuff, but instead of multiargs it works by a bonusTable like used in TasUnitBonus.UnitAdd

TasUnitBonusBuffTable.add(unit, 'Binf', {Life = 200, Str = 5})

The demo for it

-- example for TasUnitBonusBuffTable
do
    local bonusInvis = {["MOVE+"]=500}
    local bonusBlood = {Ability='AIae'}

    function DemoSpellCast()
        local unit = GetSpellTargetUnit()
        -- the spellcasts tell TasUnitBonusBuff how much to add for a given buffCode
    --Invis buff gives 500 movespeed
        if GetSpellAbilityId() == FourCC'Aivs' then TasUnitBonusBuffTable.add(unit, 'Binv', bonusInvis) end
    

    -- inner fire gives hero str
    -- first cast adds 15, recast give 5 more; 15 20 25 30
        local buffCode = FourCC'Binf'
        if GetSpellAbilityId() == FourCC'Ainf' then
            local value = 0
            local buffData = TasUnitBonusBuffTable.Data[buffCode]
            if buffData and buffData[unit] then value = buffData[unit]["STR+"] end
            if value  < 15 then value = 15 else value  = value + 5 end
            TasUnitBonusBuffTable.add(unit, buffCode, {["STR+"]= value}) end

    -- bloodlust gives an endurance aura
        if GetSpellAbilityId() == FourCC'ACbb' then TasUnitBonusBuffTable.add(unit, 'Bblo', bonusBlood) end    
    end    
end

Edit: Updated to V1.6a)
improved performance for TasUnitBonusBuffTable rebuffing the same thing an unit already has.

Edit: Updated to V1.7)
TasUnitBonusBuffTable can now be called directly,
fixed a posible desync reason with bonusTable
NewType copies the flag in FourCCValueKey for the copied key.
added Clone Types, they do the same as the normal but allow one bonus to apply 4 different abilities/techs
Ability2 Ability3 Ability4
AbilityInc2 AbilityInc3 AbilityInc4
Tech2 Tech3 Tech4

Edit: Updated to V1.7a)
Fixed an critical bug of V1.7 which broke TasUnitBonus.UnitAdd after an level up.

TasUnitBonus.UnitAdd(bonusTable, bonusTable, add)
-> TasUnitBonus.UnitAdd(unit, bonusTable, add)
therefore all addons were updated aswell.

changed some comments.

Edit: Updated to V1.7b)
updated a small typo in the unsupported key metatable

 

[Antares]

A nice collection of quality-of-life libraries that make adding/removing abilities and stat bonuses much easier. Almost any stat/ability is included and the system can easily be expanded to include your own types.

Approved

 

[Bain_Rebirth]

What are the key differences that separate this from Cbopinski’s New Bonus? I Is there a difference in performance? I would love if a newer and more efficient alternative has become available.

What I have found is that this system modifies the base stats via natives thus changing the white numbers. While New bonus uses abilities (requiring object editor) and modifies the green numbers.

 

[Tasyen]

The key difference is one can add more easy new stats/keys to TasUnitBonus, even without touching the TasUnitBonus code. This custom stats can be any number array, it is simple to use an GUI array. While keys also could target more complicated fields like UnitData[unit].Stats.Str, although here one needs to write a add function (oneline function).

The addons handle the events to apply the stats, therefore one can setup TasUnitBonuses just as data at map init or such like the demos show. learning skills, buffs, items, level-Ups can give any TasUnitBonus. (except for buffs these need an runtime event in which the bonus is applied to an specific unit)

Level-up demo for Paladins.

TasUnitBonusHero[FourCC'Hpal'] = { -- paladin levelup Bonus
 Str = 1
 ,["DMG+"] = 5 -- gain 5 Bonus ATK every LevelUp
 ,[2] = { Ability = FourCC'AHbz'} -- at level 2 add Blizzard
 ,[4] = {["STR+"] = 12}
}

TasUnitBonus only adds/takes away stats, it can not tell you how much you have.
The default keys of TasUnitBonus change base stats. The Addon TasUnitBonusSkill adds keys to add green stats which need abilities.

I dont know about performance diffs, wasnt my goal to perform faster than new Bonus, I wanted this data setup outside of events.

TasUnitBonus can not be used in (v)jass mode maps.

 

[Tasyen]

uploaded a small update V1.8)
TasUnitBonus.AddSimpleType has now an optional second arg. When provided it will create an new global array with the key in _G, this array returns 0 like the GUI arrays.
TasUnitBonus.AddSimpleType("MyUnitStat", true) -> add "MyUnitStat" to TasUnitBonus and also create such an array.
TasUnitBonus.AddSimpleType("MyUnitStat") -> only add "MyUnitStat" to TasUnitBonus.


TasUnitBonus.Heal a config when true the Key Life & Mana will increase current Life/Mana, default enabled.

Added TasUnitBonusBuffTable.get(unit, buffCode). It returns the current bonusTable for this unit & buffCode or nil.

Added a new Demo that shows buff stacking, but only 2 rebuffs make the buff better, This demo uses a finite amount of tables, made at the beginning.

local frostArmor = {
    {}
    ,{Life = 100}
    ,{Life = 100, LifeReg = 5}
}
-- Frost armog gives with the first rebuff 100 HP with the second Rebuff also HP/s
local buffCode = FourCC'BUfa'
if GetSpellAbilityId() == FourCC'ACfa' then
    local currentBonus = TasUnitBonusBuffTable.get(unit, buffCode)
    local newBonus = currentBonus
    if not currentBonus then newBonus = frostArmor[1]
    elseif currentBonus == frostArmor[1] then newBonus = frostArmor[2]
    elseif currentBonus == frostArmor[2] then newBonus = frostArmor[3]
    end
    TasUnitBonusBuffTable(unit, buffCode, newBonus)
end

 

[Tasyen]

Updated to V1.9)
TasUnitBonus.UnitAdd supports now a second format for the bonusTable. instead of a map it can now be an array, it automatic chooses the currently used format when called. The array format takes less performance. The performance difference grows with the amount of stats one bonusTable includes.
map = {Str = 2, Agi = 7, Int = 5 }
array = {"Str",5, "Agi", 3, "Int", 2 }

Most of the addons use TasUnitBonus.UnitAdd. Therefore they also support the new format. The 2 formats can not be mixed in one bonusTable. As soon the conditions for array are fullfilled, then the map keys are ignored. The array conditions are the bonusTable has [1] & [2] and [1] is a string.
TasUnitBonusHero can only use the map format when you want that a hero gains bonuses at level x and also every level. With only a every level bonus you can use the array format. the bonus applied by Level x, can use the array format even when the hero bonusTable can not.

 

[Tasyen]

Updated to V1.10)
TasUnitBonusHero can now use array format. {"Str",2, "Agi",2, ...}

it is small patch, one line was changed inside TasUnitBonusHero.

for i = lastLevel[unit] + 1, newLevel do if data[i] then TasUnitBonus.UnitAdd(unit, data[i], 1) end end
->
for i = lastLevel[unit] + 1, newLevel do if data[i] and type(data[i]) == "table" then TasUnitBonus.UnitAdd(unit, data[i], 1) end end

 

[Aldeia]

Any way to make it GUI Friendly?
(with provided examples on how to use the system)

 

[Tasyen]

ok, I'll try to make a GUI interface for some features of TasUnitBonus.

Edit: Updated to V1.10++ added a GUI API.
it can use all addons, but for buffs it will only use TasUnitBonusBuffTable.
-> buffs that become stronger or scale with stats are not doable in GUI setup of this version.
The hero levelup bonus for all heroCodes can not be setuped in GUI.
Custom GUI arrays need an Unit Indexer to be useable in TasUnitBonus, this only matters for arrays registered over the GUI api.
Key Tech & Ability are not diretly useable as one can not choose the skill/tech in the dialog, one would write the objectType as number. I could add 2 more variables to pick a tech/ability, but I will only when wanted.

 

[Aldeia]

ok, I'll try to make a GUI interface for some features of TasUnitBonus.

Edit: Updated to V1.10++ added a GUI API.

Thank you

it can use all addons, but for buffs it will only use TasUnitBonusBuffTable.
-> buffs that become stronger or scale with stats are not doable in GUI setup of this version.

What does it mean, it can use only TasUnitBonusBuffTable?
(I tried casting Windwalk - but no hp regen was given to the hero)

• DemoGUIWindWalk
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Wind Walk
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Execution count of (This trigger)) Equal to 1
      • Then - Actions
        • -------- First use -> create the bonus --------
        • -------- Unit gains 11 HP/s --------
        • Set TasUnitBonus_BuffCode = Wind Walk
        • Set TasUnitBonus_Key = LifeReg
        • Set TasUnitBonus_Amount = 11.00
        • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
        • -------- Custom GUI Array is increased under this buff --------
        • -------- Requires an UnitIndexer --------
        • Set TasUnitBonus_BuffCode = Wind Walk
        • Set TasUnitBonus_Key = udg_UnitSneaks
        • Set TasUnitBonus_Amount = 1.00
        • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
      • Else - Actions
    • -------- apply the bonus to the casting unit --------
    • -------- while it has the buff it benefits from the bonus for this buff --------
    • Set TasUnitBonus_Unit = (Triggering unit)
    • Set TasUnitBonus_BuffCode = Wind Walk
    • Trigger - Run TasUnitBonusGUIUse <gen> (ignoring conditions)

---

And iv tried to add a custom Ensnare that would decrease target armor by 10, but it also doesn't work for me.

• Net
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Ensnare
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Execution count of (This trigger)) Equal to 1
      • Then - Actions
        • -------- First use -> create the bonus --------
        • -------- Unit gains 11 HP/s --------
        • Set TasUnitBonus_BuffCode = Ensnare (General)
        • Set TasUnitBonus_Key = Armor
        • Set TasUnitBonus_Amount = -10.00
        • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
        • -------- Custom GUI Array is increased under this buff --------
        • -------- Requires an UnitIndexer --------
        • Set TasUnitBonus_BuffCode = Wind Walk
        • Set TasUnitBonus_Key = udg_UnitSneaks
        • Set TasUnitBonus_Amount = 1.00
        • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
      • Else - Actions
    • -------- apply the bonus to the casting unit --------
    • -------- while it has the buff it benefits from the bonus for this buff --------
    • Set TasUnitBonus_Unit = (Target unit of ability being cast)
    • Set TasUnitBonus_BuffCode = Ensnare (General)
    • Trigger - Run TasUnitBonusGUIUse <gen> (ignoring conditions)

 

[Tasyen]

Updated TasUnitBonusGUI.
TasUnitBonusGUIUse now resets udg_TasUnitBonus_Unit to nil/no unit.

(I tried casting Windwalk - but no hp regen was given to the hero)

I made only one Add function which does stuff based on which variable has a value then resets. TasUnitBonusGUIUse did not reset TasUnitBonus_Unit from Trigger DemoGUI AddStats which i added later. Therefore the add in windwalk made something unwanted (an leveling bonus for the oger). Fixed with the update. When I made this demo triggers I first made the windwalk it worked, then I added the direct Stat add for the ogers which broke windwalk. But i did not test wind walk again.


TasUnitBonusGUIUse has to be called at the moment the unit has/gains the buff. Ensnare buff is delayed by a missile.

What does it mean, it can use only TasUnitBonusBuffTable?

There are 2 addons about Buffs TasUnitBonusBuffTable & TasUnitBonusBuff they store the data a little bit different.

 

[Greedy Procrastinator]

Hm, will it work on 2.0+?
So I can add new stat like charisma with it?

 

[Tasyen]

Did not test it in V.2.0. Would not know why it should not work for this version :|

it can help in making a new stat like charisma. One can setup what gives it with TasUnitBonus. But you still would need to trigger what charisma does.

Edit: Update TasUnitBonusGUI to 1.2)
There is now TasUnitBonusGUIMakeBuff which creates a new Table for udg_TasUnitBonus_BuffCode. This allows to have buffs with dynamic power/scale based on the situation when casted.
2 new Demos.
One that shows the dynamic Power Buff.
Added One sobi mask to each pulk that gives 15 ATK vs Undead, shows item specific bonuses.

 

[Aldeia]

Did not test it in V.2.0. Would not know why it should not work for this version :|

it can help in making a new stat like charisma. One can setup what gives it with TasUnitBonus. But you still would need to trigger what charisma does.

Edit: Update TasUnitBonusGUI to 1.2)
There is now TasUnitBonusGUIMakeBuff which creates a new Table for udg_TasUnitBonus_BuffCode. This allows to have buffs with dynamic power/scale based on the situation when casted.
2 new Demos.
One that shows the dynamic Power Buff.
Added One sobi mask to each pulk that gives 15 ATK vs Undead, shows item specific bonuses.

What Unit Indexer would one use for LUA?

 

[Tasyen]

no idea.
When you only need the unique index feature of unit indexers. Then making Get Unit User Data return the unit itself will do the deal for almost free.
they did other stuff as far I know, which this would not.

This would do what I said above. To use it make a new script in your map and copy paste.

do
    oldGetUnitUserData = GetUnitUserData 
    function GetUnitUserData(unit) return unit or 0 end
end

Edit: one could it make smarter so it would return the choosen value when you used Set Unit Custom Value
Edit2: Added return unit or 0 to avoid nil pointer error

Edit: Ic Bribe did some stuff for it.

Lua-Core/Unit Indexer.lua at main · BribeFromTheHive/Lua-Core

Contribute to BribeFromTheHive/Lua-Core development by creating an account on GitHub.

github.com

 

[Aldeia]

no idea.
When you only need the unique index feature of unit indexers. Then making Get Unit User Data return the unit itself will do the deal for almost free.
they did other stuff as far I know, which this would not.

This would do what I said above. To use it make a new script in your map and copy paste.

do
    oldGetUnitUserData = GetUnitUserData
    function GetUnitUserData(unit) return unit end
end

Edit: one could it make smarter so it would return the choosen value when you used Set Unit Custom Value

Edit: Ic Bribe did some stuff for it.

Lua-Core/Unit Indexer.lua at main · BribeFromTheHive/Lua-Core

Contribute to BribeFromTheHive/Lua-Core development by creating an account on GitHub.

github.com

As a GUI user, i didn't understand much from it TBH
Nvm got it.

 

[Aldeia]

So I am trying to increase some stats of the item - Broken Sword via a power type item (socket) that the hero has in inventory, but for some reason the bonus stats does not apply (however if another hero picks the item - the added stats work), What am i doing wrong?

• Broken Sword Basic
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- - --------
    • Set TasUnitBonus_ItemCode = Broken Sword
    • Set TasUnitBonus_Key = DMG+
    • Set TasUnitBonus_Amount = 7.00
    • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
    • -------- - --------

---

• Broken Sword Sockets
  • Events
    • Unit - A unit Sells an item (from shop)
  • Conditions
    • (Item-type of (Sold Item)) Equal to Sword Socket
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Buying unit) has an item of type Broken Sword) Equal to True
      • Then - Actions
        • Set TasUnitBonus_Item = (Item carried by (Buying unit) of type Broken Sword)
        • Item - Set Extended Tooltip of TasUnitBonus_Item to ((Extended Item Tooltip of TasUnitBonus_Item) + |n+5 damage)
        • Item - Set Name of TasUnitBonus_Item to ((Name of TasUnitBonus_Item) + Paladin)
        • Set TasUnitBonus_Key = DMG+
        • Set TasUnitBonus_Amount = 5.00
        • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
      • Else - Actions

Spoiler: Screenshots

 

[Tasyen]

So I am trying to increase some stats of the item - Broken Sword via a power type item (socket) that the hero has in inventory, but for some reason the bonus stats does not apply (however if another hero picks the item - the added stats work), What am i doing wrong?

TasUnitBonusItem does not give a bonus when the item already was hold. But it will remove the bonus when droped. One would add the additional bonus to the unit aswell, like the Lua mask of death example shows.

 

[Aldeia]

TasUnitBonusItem does not give a bonus when the item already was hold.

Any way to implement a feature to support that, - seems like a really neat feature to have - after all will allow for a lot of interesting systems (like a socket system for example)

 

[Tasyen]

The bonus is set for the item. It is just that it only applies and removes the bonus on a pick & drop items event.

 

[Aldeia]

The bonus is set for the item. It is just that it only applies and removes the bonus on a pick & drop items event.

I don't know LUA much, but calling the function directly wouldn't allow for such implementation on top of the pick/drop only event?

like the Lua mask of death example shows.

Can you provide an example for such events for GUI? (if it's possible)

 

[Pyrogasm]

I don't know LUA much, but calling the function directly wouldn't allow for such implementation on top of the pick/drop only event?

If that solution is acceptable to you, all you need to do is forcibly drop the item and then have the unit pick it back up immediately. The Action function that updates the bonuses when an item is picked up/dropped is a local non-public-facing function that cannot be directly called from outside the library.

 

[Tasyen]

I don't know LUA much, but calling the function directly wouldn't allow for such implementation on top of the pick/drop only event?

That requires something I didnt want to do.
For the itemCode: One would need to loop all units and if they have such an item then add the additional bonus, sounds costly to me. Far smarter to set the bonus before any unit can pick it up. Except when you want to upgrade all items of type x during the match then it needs the loop all units or replace it with a new item Type on item pick up.

For a specific item: Need to keep track of the current holder as the game does not tell who that is, Then apply it also to the current holder.
^^Alternative Keep track of bonuses provided by items for units and only take away the given bonus on item drop. This would add a big amount of data to be stored or compared (depends how one would implement this).

Can you provide an example for such events for GUI? (if it's possible)

Updated the uploaded map, added a new GUI example:
EchtSilber Hammer
+5 STR
Activ: Destroy an target item this gives 5 more STR

Also added a disabled lua code that upgrades Get Unit/Item Custom Value to return the Unit/Item itself or the choosen Value. so it can be directly used as Index like mentioned in this TasUnitBonus

• DemoGUIEchtSilberHammer
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- All EchtSeliber Hammer gives 5 STR on base --------
    • Set TasUnitBonus_ItemCode = EchtSilber Hammer
    • Set TasUnitBonus_Key = STR+
    • Set TasUnitBonus_Amount = 5.00
    • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
• DemoGUIEchtSilberHammerUse
  • Events
    • Unit - A unit Uses an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to EchtSilber Hammer
  • Actions
    • -------- Display current Power as item Charge --------
    • Item - Set charges remaining in (Item being manipulated) to ((Charges remaining in (Item being manipulated)) + 2)
    • -------- make this Hammer Stronger --------
    • Set TasUnitBonus_Item = (Item being manipulated)
    • Set TasUnitBonus_Key = STR+
    • Set TasUnitBonus_Amount = 5.00
    • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
    • -------- Give the new bonus to the unit now. Because the item is hold and the system takes/gives the bonus on a drop/Pickup event --------
    • Set TasUnitBonus_Unit = (Hero manipulating item)
    • Set TasUnitBonus_Key = STR+
    • Set TasUnitBonus_Amount = 5.00
    • Trigger - Run TasUnitBonusGUIUse <gen> (ignoring conditions)
• DemoGUIEchtSilberHammerCast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to AbsorbItem
  • Actions
    • Item - Remove (Target item of ability being cast)

 

[Aldeia]

That requires something I didnt want to do.
For the itemCode: One would need to loop all units and if they have such an item then add the additional bonus, sounds costly to me. Far smarter to set the bonus before any unit can pick it up. Except when you want to upgrade all items of type x during the match then it needs the loop all units or replace it with a new item Type on item pick up.

For a specific item: Need to keep track of the current holder as the game does not tell who that is, Then apply it also to the current holder.
^^Alternative Keep track of bonuses provided by items for units and only take away the given bonus on item drop. This would add a big amount of data to be stored or compared (depends how one would implement this).


Updated the uploaded map, added a new GUI example:
EchtSilber Hammer
+5 STR
Activ: Destroy an target item this gives 5 more STR

Also added a disabled lua code that upgrades Get Unit/Item Custom Value to return the Unit/Item itself or the choosen Value. so it can be directly used as Index like mentioned in this TasUnitBonus

• DemoGUIEchtSilberHammer
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- All EchtSeliber Hammer gives 5 STR on base --------
    • Set TasUnitBonus_ItemCode = EchtSilber Hammer
    • Set TasUnitBonus_Key = STR+
    • Set TasUnitBonus_Amount = 5.00
    • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
• DemoGUIEchtSilberHammerUse
  • Events
    • Unit - A unit Uses an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to EchtSilber Hammer
  • Actions
    • -------- Display current Power as item Charge --------
    • Item - Set charges remaining in (Item being manipulated) to ((Charges remaining in (Item being manipulated)) + 2)
    • -------- make this Hammer Stronger --------
    • Set TasUnitBonus_Item = (Item being manipulated)
    • Set TasUnitBonus_Key = STR+
    • Set TasUnitBonus_Amount = 5.00
    • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)
    • -------- Give the new bonus to the unit now. Because the item is hold and the system takes/gives the bonus on a drop/Pickup event --------
    • Set TasUnitBonus_Unit = (Hero manipulating item)
    • Set TasUnitBonus_Key = STR+
    • Set TasUnitBonus_Amount = 5.00
    • Trigger - Run TasUnitBonusGUIUse <gen> (ignoring conditions)
• DemoGUIEchtSilberHammerCast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to AbsorbItem
  • Actions
    • Item - Remove (Target item of ability being cast)

Thanks, also is the MOVE+ working with negative values?

• Untitled Trigger 001
  • Events
    • Time - Elapsed game time is 1.00 seconds
  • Conditions
  • Actions
    • Set TasUnitBonus_ItemCode = Boots of DE Speed
    • Set TasUnitBonus_Key = MOVE+
    • Set TasUnitBonus_Amount = -250.00
    • Trigger - Run TasUnitBonusGUIAdd <gen> (ignoring conditions)

I tested this, and while the movement speed (MS) shows as reduced (with the red color indicating a decrease), the actual movement speed remains unchanged. The hero still runs at the same speed as one without boots.

 

[Tasyen]

MOVE+ uses the movespeed item skill and it looks like this skill cant reduce movespeed.

 

[Aldeia]

MOVE+ uses the movespeed item skill and it looks like this skill cant reduce movespeed.

But is there a need to use an ability for that? (because I didn't find the alternative in the bonuses list) (can the MOVE+ be replaced with a func like others from the system that just influences hero ms)

 

[Tasyen]

the ability is not needed. I just have bad experience with the trigger function that changes movespeed, it does not check for movespeed limits and therefore can in edgecases perma change move speed in unwanted ways.


This would add Move as new key to change movespeed using the trigger feature. Put that somewhere in your map script after TasUnitBonus.

TasUnitBonus.NewType("Move", function(unit, value, key)
   SetUnitMoveSpeed(unit, GetUnitMoveSpeed(unit) + value)
end)

 

[Aldeia]

the ability is not needed. I just have bad experience with the trigger function that changes movespeed, it does not check for movespeed limits and therefore can in edgecases perma change move speed in unwanted ways.


This would add Move as new key to change movespeed using the trigger feature. Put that somewhere in your map script after TasUnitBonus.

TasUnitBonus.NewType("Move", function(unit, value, key)
   SetUnitMoveSpeed(unit, GetUnitMoveSpeed(unit) + value)
end)

This seems to work just fine!

 

[Aldeia]

I think there is another bug with attack speed. (iv given the sobi mask (in the test map) 5.0 bonus attack speed and the attack speed of the unit went from Average to Very Slow)

 

[Tasyen]

When you used the key "AttackSpeed" then it increases the base attack cooldown by this amount, to make the unit better with this one use -values.

The key "ATKSP+" uses a hidden gloves of haste item skill. in which +values makes the units better.