TasToolTipBox

[Tasyen]

This will probably get a vjass port in some days.

 

[moddiemads]

I had just started trying to make something like this. Tasyen to the rescue!

 

[Tasyen]

Updated to V2 and ported to vjass)
Own Inventory items now also show the infos, for items the first skill is used (index 0).
added an option to repos default tooltip frame to default pos when TasToolTipBox is not shown.

 

[Tasyen]

Updated vjass to V3)
Improved Skill detection (can ignore ItemSkills in the command card detection)

Updated Lua to V4)
can detect peon built & Hero Learn sub menu, this does not work 100% in all cases
can manual set data for default, subMenu Built & Hero Learn
need to do it when you want to know stuff inside built or shops .
Manual data overpowers the ability detection.

uploaded map still includes Lua V3 because V4 differs quite from V3.

In the demo map only the 4 melee workers goblin shop and townhall have manual data.
goblin shop has colisions hence it will show wrong infos even when working.



not sure how to do the vjass V4 version with the data setup.

edit: Update both to V4a)
V4a AddBatch - Hero Learn assumes now fill card from top left, AddData Filters -coord abilities

vjass uses now an array and loops it to find the index of an unitcode in the system, but each dataset needs 12 slots. therefore the vjass version only supports upto 32k/12 unitcodes -> ~2.6k

 

[Antares]

--[[
function TasToolTipBox.AddData(array, unitCode, objectCode)
    make unitCode use inside array objectCode as manual data
    uses x/y coords of objectCode, therefore with colisions you get unwanted results
]]

This is quite confusing. What is array and what are the possible options? You need to list them.
"make unitCode use inside array objectCode as manual data" Please try to rephrase that sentence.

The frames for ability tooltips are working well. For the build tooltips, the names in the tooltip box seem to get clipped on many of them. I also don't quite understand the intent here. Is this working as intended? What is the use of listing the name of the object again?

For the TasToolTipBox table, you should separate configurables from non-configurables. I don't know what to with ExcludSlots = {[7] = true}, so I don't want to touch it. Same for EventCount, TimerUnit, LastAction, and TimerCount. Separate these visually from the configurables.

I noticed that when I turned off Hide0Text, the ability tooltips remained displayed when I hovered over a build button from one of the workers. Also, a small comment about what this does would be appreciated. It took me some time to get what it does.

For the Icon table, you could do a dictionary with "range", "cooldown" etc. keys or put a comment behind it which index is pointing to which info.

It would be great if the order of the items could be customized. As far as I understand it, if you want cast time displayed, you need to display all other values and you can't pick and choose. Shrinking down the tooltip box and removing holes when some of the items aren't being displayed could be a nice option for the config.

A nice system that enables the display of spell information automatically and with just a few clicks, but there appear to be a few bugs and some features are not explained well.

Awaiting Update

 

[Tasyen]

Updated to 4c added some comments to the api and setup.

I have to tell that this system is a port from my map and the whole submenu stuff is not part of the design goal for my map. They were added as Afterthought because for a general system they are likely needed.

This is quite confusing. What is array and what are the possible options? You need to list them.
"make unitCode use inside array objectCode as manual data" Please try to rephrase that sentence.

yes, bad explained will add more info. I think one should use the batch version below which has examples. In reality one copy pastes the sold Items/Units Learn field from object Editor.

The frames for ability tooltips are working well. For the build tooltips, the names in the tooltip box seem to get clipped on many of them. I also don't quite understand the intent here. Is this working as intended? What is the use of listing the name of the object again?

The names are an example and proof of concept that it also works in built menu. The text is clipped because each Icon slot only displays a limited amount of space on screen (~0.06 x-screen space) This Size limits is caused by the Size of "TasTooltipBoxInfo" which is 0.06/0.015 from fdf. one could change that in map script but I did not implement that.

For the Icon table, you could do a dictionary with "range", "cooldown" etc. keys or put a comment behind it which index is pointing to which info.

The idea is that this indexes match the indexes one uses when one writes onto the text frames inside the this.Action functions, and as user of this System one can change the action functions. With keys, i would suggest a meaning which i dont want to do.

It would be great if the order of the items could be customized. As far as I understand it, if you want cast time displayed, you need to display all other values and you can't pick and choose. Shrinking down the tooltip box and removing holes when some of the items aren't being displayed could be a nice option for the config.

One can customize the icons and the order. Thats what the this.Action functions are about one sets the displayed texts one could set the icon textures but I dont.
I prefere when the positions are static. Then the position itself has a meaning by itself and one does not need to interpret the icon. When one packs and reorganizes them one needs to learn for each ability what Slot 1, 2, ... mean. While with fixed slot indexes, the first is always MissileSpeed.

 

[Antares]

Right, it's slowly coming together for me. I think I get now what's going on with most of the options. Listen, you have a --config start and a -- config end and then there is more config stuff below it.

You could put the functions directly into the table definition, like:

--[...]
        ,FilterItemSkills = true -- true items are never in the command card in your map
        ,EnableSubMenu = true -- true creates events/timer; changing it after the Init run is not supported/recommented.        
        ,YPos = 0.17

        ,ActionSubMenuHero = function(buttonIndex, data, unit, unitCode)
            -- requires EnableSubMenu
            -- what to display inside hero skill menu        
            BlzFrameSetText(BlzGetFrameByName("TasTooltipBoxInfoText", 1), GetObjectName(data))
            return true
        end,

        --[...]

and then have all the non-configurable parts after local this = TasToolTipBox line.

On the ExcludSlots line, maybe mention that 0 is the bottom-left button.

"unitCode will use inside array, objectCode as manual data."

I still don't understand that sentence. It would really help if you used an AI to proof-read your descriptions.

In the this.Action functions, type annotations would help with making it clearer what each parameter means. I assume data is the type id? I'm unfamiliar with the GetObjectName function. Does it work with unit ids, ability ids etc.?

I know I could figure this out by digging into your code, but I'm giving you the average user experience of someone as dense as me.

What about the fact that the "Blacksmith", "Town Hall" field is hidden when you hover over the build buttons when you have Hide0Text disabled. Is that a bug?

 

[Tasyen]

Updated Lua to 4d)
moved the action functions into the config
added Emmy Annotation for the action functions
mentions that buttonIndex 0 is topLeft and 11 bottomRight, i think that is overkill as that is just command card coords.
reworded TasToolTipBox.AddData

What about the fact that the "Blacksmith", "Town Hall" field is hidden when you hover over the build buttons when you have Hide0Text disabled. Is that a bug?

The hover system does not work for disabled command buttons. Normal Gold/Mana costs are not displayed for such aswell.

 

[Antares]

mentions that buttonIndex 0 is topLeft and 11 bottomRight, i think that is overkill as that is just command card coords.

It's still worth clarifying because some people do not know that by heart or the index could start at 1 in your system because of Lua's 1-based indexing.

The hover system does not work for disabled command buttons. Normal Gold/Mana costs are not displayed for such aswell.

That's not what I'm refering to. Here is the tooltip for Town Hall with and without "Hide0Text" flag enabled.

The first info is no longer visible.

 

[Antares]

Please use the full type names or put an ---@alias somewhere in your script.

If the unitCode/abiCode variables are integers, unitId/abiId would be better, less confusing variable names. These are the names that Blizzard uses for their functions.

There is a small bug with the frame position when FixedPos = false. When you hover over one with a TasTooltipBox and move the mouse over one without a box, if you do it really fast, it doesn't adjust the position. When you do it slower, it does. Not a big deal, but maybe you can fix that.

For the vJASS version, please also make sure that the config is clearly delimited from the rest.

Other than that, looking good.

 

[Antares]

Nice system for displaying additional spell information. Very customizable.

Approved

 

[Aldeia]

Can i please ask for a small change that would allow the system to easily do the next thing.
Give any value+icon for various object descriptions. (would be very useful imo)

---

In my case - I want to make special upgrades in a forge that would require a custom resource, and I want to show that custom resource in the box) - it is just i cannot do that easily - and I can see the potential in this system to allow me to do such thing