TasItemshop

[sraltheking]

First you have to make sure you are using the right version. If your map is in jass mode you copy the jass version. If your map is in Lua than you use the other one. Your can see the code mode of your map in Scenario - Map Options - bottom part of the PoPup Window.
The default code mode is jass.
If your map is in jass make sure that you enabled vjass: trigger editor - jasshelper - enable vjass. That requires to enable jasshelper.

The imports do not produce any compiler errors. Without the imported Files the Custom UI will not display and won't work in the game.
Export all and import all are fine when done in the current Version of Warcraft 3.

My man! Thanks

 

[Ugabunda]

Thanks for the update Tasyen. Isn't the above also a bug?

I took some more pics, to hopefully explain the problem better:

1. Here you can see the Shadow Hunter being just outside of the top-right shop's range (= no shop arrow):

View attachment 381818

2. However, if I move the hero to the center of the map, where NO shop is, he again gets the Shop arrow:

View attachment 381819

3. And here just to show that really no other shop is nearby from which the Hero can buy from:

View attachment 381820


I get the same behaviour in my (bigger) map. The heroes at the very center of the map always get the shop arrow, even though there is no shop for miles nearby.

Hi Tasyen, were you able to confirm the thing with the arrow?

Since it's happening in the middle of the map, which is usually when a "point" is not correctly recognized, I assume somewhere in the system a point is not correct.

 

[Tasyen]

Wierd, I encountered it now.
Now that I think about it, the reason could be the hidden Cost detector Shop, created in TasItemCost. The position seems fitting (180/-340) => mid of test map.
That hidden shop is required to automatically detect costs of items, might change its position or give it a special select hero version without arrow.

 

[MyPad]

Fantastic UI System that definitely deserves a high rating, as expected of the custom UI master himself.

Spoiler: Code

There isn't much for me to tackle on here, aside from the dependencies having to use module initialization for the
vJASS equivalent of these systems themselves.

In the vJASS version, the TasItemShopAddCategory function will always add more instances, even if the explicit
check for the maximum number of categories is made.

In the IsRightClick library, even if the optional dependency Frameloader is not required, the library will only compile
when said library exists. (There is an extra line that renders the optional tag effectively useless.)

Status:

Awaiting Update​

 

[Tasyen]

Jass Updated to 4h)
IsRightClick compiles now without FrameLoader.
function TasItemShopAddCategory, placed the array writting into an else path only happening when the limit is not exceeded yet.

aside from the dependencies having to use module initialization for the
vJASS equivalent of these systems themselves.

Never used that. The vjass manual speaks about struct which my code does not contain.

 

[MyPad]

aside from the dependencies having to use module initialization for the
vJASS equivalent of these systems themselves.

Never used that. The vjass manual speaks about struct which my code does not contain.

This was what I was referring to (module initialization):

private module Init
    private static method onInit takes nothing returns nothing
        // Initialization process here..
    endmethod
endmodule
// Dummy struct that's only used for initialization purposes
private struct S extends array
    implement Init
endstruct

With module initialization, it is guaranteed that the initialization function within the library
will be processed first, by order of requirements. The initialization function cannot be
reliably processed first by any other type of initialization, including library initialization
(counterintuitive as it may sound).

 

[Tasyen]

4i jass version:
Replaced the jass init function of the required Libraries with module initialization. Except for Table and String.

 

[Ugabunda]

Wierd, I encountered it now.
Now that I think about it, the reason could be the hidden Cost detector Shop, created in TasItemCost. The position seems fitting (180/-340) => mid of test map.
That hidden shop is required to automatically detect costs of items, might change its position or give it a special select hero version without arrow.

Hey Tasyen, just writing in case this problem was forgotten: In the new version the arrow problem still appears. Cheers!

 

[Tasyen]

Sry, I might have worded that wrong. You have to change the position/select skill/unit inside your map in the Req TasItemCost.
on default it creates a hidden markplace ('nmrk') unit owned by neutral extra, If you don't use this unitType in your map I suggest to change the Select Hero ('Aneu') skill in side object Editor to Shared Shop allies ('Aall') for marktplace. That unit skill change would require 0 code change.

 

[Ugabunda]

Worked - thank you!

I do use the Marketplace Unit Type as my default shop model. However, I changed the default ability "Select Hero" to "Shop Sharing, Allied Bldg.", and I don't see any negative impact (the "correct" shop in the corner of my map still provides an arrow and I can buy from this store as usual). Why did you write "if you don't use this unitType?

 

[Tasyen]

Recently I tried to add TasItemshop to some AoS map. Setting the categories were quite tiresome, so I though one could autoDetect some of the default categories TasItemshop uses.

it can auto detect Str/AGI/INT/Armor/Mana/Life/Regeneration/MoveSpeed/Aura/Active/Consumeable/MagicRess

It does this by running the game: creating many units in pairs one with an item and another without then comparing their values. This detection generates code when it runs which you then feed back into the map's code, after that you remove the detector from your map (should only be done in single player).
There is a vjass and Lua version.
Because of jass limits, the vjass version can not allways handle all registered Items at once (if there are many), therefore it can also only take a subset, generate that, take the part and repeat with a different subset until you got all.
When you don't want that STR/AGI/INT also count for Armor/Mana/Life/Regeneration/MoveSpeed you should set their effect in game play constants to 0 for the generation.

Like in FdfCreatorMap the generated text is written into an EditBox which content you copy paste.
Select the Editbox
Press Pos1
Press shift+ End
ctrl + c
Paste it into an editor, afterwards into your map.
The Lua version generates jass code, which can be converted into Lua with 2 search & ReplaceAll
call ->
// -> --

The map does not contain TasItemShop but requires a working version in the same Map to work.
Created with Warcraft 3 V1.31

 

[Tasyen]

Updated vjass version to v4k to fix a bug related to TasButtonList 10b (jass version). It's a small fix one only needs to change a function inside the req TasButtonList (TIS) (CC).

function TasButtonListAddDataEx takes integer listIndex, integer data, integer playerIndex returns nothing
    local integer listHandle = GetHandleId(LoadLocationHandle(Hash, GetHandleId(TasButtonListDataList[listIndex]), playerIndex))
    local integer index = LoadInteger(Hash, listHandle, 0) + 1
    local integer dataFilteredCount
    call SaveInteger(Hash, listHandle, 0, index)
    call SaveInteger(Hash, listHandle, index, data)
    if GetLocalPlayer() == Player(playerIndex) then
        // add to current filtered for local player only
        set listHandle = GetHandleId(TasButtonListDataListFiltered[listIndex])
        set dataFilteredCount = LoadInteger(Hash, listHandle, 0) + 1
        call SaveInteger(Hash, listHandle, 0, dataFilteredCount)
        call SaveInteger(Hash, listHandle, dataFilteredCount, index)
        call BlzFrameSetMinMaxValue(TasButtonListSlider[listIndex], TasButtonListButtonCount[listIndex], dataFilteredCount)
    endif
endfunction

 

[pick-a-chew]

I can't believe I've slept on this resource for so long, it's pretty incredible. Fairly easy to implement and easy to modify if you know a bit of JASS.

Whilst learning how to use it, i noticed that items that are on the shortcut list that aren't also added to any shop via "call TasItemShopAdd5" can cause desyncs. It may be obvious but if one ever removes all "TasItemShopAdd5" for an item, but accidentally leaves behind an "TasItemShopShortCuts", they might run into issues. Maybe a failsafe could exist for this?

Regardless, an exceptional resource!

 

[Tasyen]

I can't believe I've slept on this resource for so long, it's pretty incredible. Fairly easy to implement and easy to modify if you know a bit of JASS.

Whilst learning how to use it, i noticed that items that are on the shortcut list that aren't also added to any shop via "call TasItemShopAdd5" can cause desyncs. It may be obvious but if one ever removes all "TasItemShopAdd5" for an item, but accidentally leaves behind an "TasItemShopShortCuts", they might run into issues. Maybe a failsafe could exist for this?

Regardless, an exceptional resource!

Thanks, for your feedback&report.

Updated to 4m (jass) /4g (Lua)
Fixed a desync problem with ItemCodes added to QuickLink/ShortCuts which never were added to TasItemShop before.

To update the system in your map you only need to update the TasItemShop script.
The change done was not big, in case you want to keep it like it is. But want the fix you change 3 Lines in the Script TasItemShop:
Update Version at the top

Lua
search the function TasItemShopUI.SetQuickLink(player, itemCode)
Add the code in the box below, as the first Lines of the function

-- request to calc the itemCode costs, this is done in case it was not added to the shop
TasItemCaclCost(itemCode)

jass
search the function public function SetQuickLink
Add the code in the box below, right below the line local integer loopA

// request to calc the itemCode costs, this is done in case it was not added to the shop
call TasItemCaclCost(itemCode)

 

[Tasyen]

replaced the included FrameLoader Lua (Save&Load)

 

[Ericqwe]

How is it to modify the list of ítem

 

[Tasyen]

there are functions to add items to the list. They are mentioned in the description of the system on this Site. Or at the top of TasItemShop. I guess you use the vjass version.

// TasItemShopAdd(itemCode, category)
        // adds itemCode to the common Buyable Item pool and sets the category
// TasItemShopAddShop(unitCode, itemCode)
        // adds itemcode for that specific shop

When you don't need during match changes just use the suggested UserInit or the GUI map init thing.


I did not include a feature to remove items. Theoretically it is possible. When you use a BlackList shop you could change the content of public integer array BUY_ABLE_ITEMS and the value of public integer BUY_ABLE_ITEMS_Count = 0 That would remove the item from all none WhiteList shops.

For WhiteList shops you need to understand Table by bribe.
This is how WhiteListe items are stored:
public HashTable ShopsItems stores the shop items for WhiteList shops its the only stuff one can buy.
ShopsItems[unitCode][0] is the total amount of itemCodes stored in that for that shop UnitCode
ShopsItems[unitCode][x] = itemCode are the itemCodes.