[JASS] Syntax Error

[Garfield1337]

function Dagger_Loop takes nothing returns nothing
    call BJDebugMsg("lol")
endfunction

function Dagger_Loop_Init takes nothing returns nothing
    ForGroup(udg_Daggers,function Dagger_Loop)
endfunction
//===========================================================================
function InitTrig_Untitled_Trigger_001 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_001 = CreateTrigger(  )
    call TriggerRegisterTimerEvent(gg_trg_Untitled_Trigger_001,0.03,true)
    call TriggerAddAction(gg_trg_Untitled_Trigger_001, function Dagger_Loop_Init)
endfunction

Why is this code giving me errors? It says that there's syntax error at 'ForGroup' function and i see nothing wrong. This was actually a part of another trigger,but it doesn't seem to work even alone.

 

[Sesamia]

You forgot to type "call" before the ForGroup function.

 

[Garfield1337]

Oh god...i often make that mistake. Thank you.
I'm sorry that i can't give you rep since i have to spread first =[

 

[Bribe]

function Dagger_Enum takes nothing returns nothing
    call BJDebugMsg("lol")
endfunction

function Dagger_Loop takes nothing returns nothing
    call ForGroup(udg_Daggers, function Dagger_Enum)
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_001 takes nothing returns nothing
    call TimerStart(CreateTimer(), 0.03, true, function Dagger_Loop)
endfunction

Welcome to JASS.

 

[Garfield1337]

Welcome to JASS.

I'm in JASS for some time already,but thank you anyway. Though i still make some begginer mistakes.

 

[Bribe]

Then you should think about how to write efficient code, instead of just working with converted GUI.

 

[Garfield1337]

This was actually a part of another trigger

That. And i don't convert GUI triggers to JASS except when i can't remember the name of some function,but i usually use JASS craft anyway.

 

[Bribe]

Whats with noobies these days who write shit yet think it's the best code ever written

 

[Garfield1337]

I don't know what are you talking about...
I just said i write code myself instead of converting GUI to JASS.
Also i'm aware of the fact that i'm not a really good JASSer.

 

[Berb]

Bribe man chill out lol. I mean if you're starting a bandwagon I'll be the first to jump on but Garfield1337 here just had a simple question.. no reason to start fuming.

 

[Sadalbari]

What's inefficient about that code...

 

[Bribe]

set gg_trg_Untitled_Trigger_001 = CreateTrigger( )
call TriggerRegisterTimerEvent(gg_trg_Untitled_Trigger_001,0.03,true)
call TriggerAddAction(gg_trg_Untitled_Trigger_001, function Dagger_Loop_Init)

A trigger-handle, an event-handle and a triggeraction-handle instead of simply a timer handle. That, my friend, is a key difference between efficient code and not.

 

[Garfield1337]

Timer handle can replace it? Explain me how,then.
Also i hope it's not in vJASS as i haven't learned it yet.

 

[Kricz]

Just a global timer, that you start in some init-function, which will expire all 0.03125 (or whatever) seconds, using a function as a timer-callback.
Normally used when using a struct for spells or something.
They are alot better and some kind of faster than triggers afaik.

vJass gives free global deklaration, using normal jass would require to put the timer variable in the header...

 

[Deaod]

Timer handle can replace it? Explain me how,then.

He already did, look at the code he posted more carefully (especially at the InitTrig function).

 

[Garfield1337]

Oh didn't notice it. Thanks then.

 

[Sadalbari]

You're whining about using a trigger instead of a timer? If you think that's a key difference between efficient and non-efficient code, you either don't know what "key difference" means or you simple don't know much about optimization to begin with. An additional event handle or triggeraction handle is completely irrelevant when discussing efficiency, and definitely not worth nearly cursing someone for.

 

[Bribe]

You're whining about using a trigger instead of a timer? If you think that's a key difference between efficient and non-efficient code, you either don't know what "key difference" means or you simple don't know much about optimization to begin with. An additional event handle or triggeraction handle is completely irrelevant when discussing efficiency

If you knew how inefficient JASS is and how much more performance you get from a single timer instead of a trigger, you would completely retract this statement.

definitely not worth nearly cursing someone for.

Definitely not, for which I apologise.