Stop Time

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Moderator: Pharaoh_ Date: 06:54, 29th Mar 2012 The spell bears many problems, such as: • In the F 1 trigger, you are declaring F_Handle, before you store the F_Dummy itself. • Lacks documentation. • Uses personal paths only that are not configrable through global variables. • Remove the array from F_point[], use 6 different point variables. • You are removing F_point[1] within the unit group enumeration, calling this function as many units are close to F_point[1]; move it in the end of the trigger. • Additionally, move the Trigger - Turn on (XXX), Unit Group - Add F_Dummy to F_Group (both in the first trigger) and removal of F_point[6] location, hashtable values flush (F 5) in the end of the trigger. • Use a variable to store (Picked unit) and then reference it though the created variable. • If you want to filter alive units, make sure you add it in the unit group definition as well, to avoid looping through unnecessary units. • The spell forces the triggers to turn off by the end of the first instance, while other instances might be running at the same time. Make it useable by many units. • Many triggers are used, you could only use one looping trigger and create the effects you want in the distances you need. If it doesn't get a better coding look and doesn't comply with the rules, after your next update, it will be permanently rejected. Useful Links: Spell Rules

Old Review

Moderator: Pharaoh_ Date: 10:41, 12th Mar 2012 The use of hashtable is redundant. The spell is still really easy to reproduce and the leaks are removed unsymmetrically. Unless you perform heavy changes to the spell, it will not get approved. Rejected once again. Useful Links: Things that Leak

 

[zv27]

Your trigger

F2

• F 2
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Time Stop
  • Actions
    • Set F_Caster = (Triggering unit)
    • Set F_point = (Target point of ability being cast)
    • Unit - Create 1 Stop Time Dummy for (Owner of F_Caster) at F_point facing Default building facing degrees
    • Set F_Dummy = (Last created unit)
    • Unit - Add a 10.00 second Generic expiration timer to F_Dummy
    • Unit Group - Add F_Caster to F_group
    • Unit Group - Pick every unit in F_group and do (Actions)
      • Loop - Actions
        • Unit Group - Pick every unit in (Units within 500.00 of F_point matching ((Owner of (Matching unit)) Not equal to (Owner of F_Caster))) and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) is alive) Equal to True
              • Then - Actions
                • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\Invisibility\InvisibilityTarget.mdl
                • Special Effect - Destroy (Last created special effect)
                • Unit - Pause (Picked unit)
                • Animation - Change (Picked unit)'s vertex coloring to (80.00%, 80.00%, 80.00%) with 60.00% transparency
                • Animation - Change (Picked unit)'s animation speed to 0.00% of its original speed
                • Trigger - Turn on F 3 <gen>
              • Else - Actions
            • Custom script: call RemoveLocation(udg_F_point)

F3

• F 3
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Stop Time Dummy
  • Actions
    • Set F_point = (Position of (Dying unit))
    • Unit Group - Add (Dying unit) to F_deathgroup
    • Unit Group - Pick every unit in (Units within 500.00 of F_point matching (((Matching unit) belongs to an enemy of (Owner of F_Dummy)) Equal to True)) and do (Actions)
      • Loop - Actions
        • Unit - Unpause (Picked unit)
        • Animation - Change (Picked unit)'s vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
        • Animation - Change (Picked unit)'s animation speed to 0.00% of its original speed
        • Custom script: call RemoveLocation(udg_F_point)

Too easy
Spell leaks
10 seconds is a very long time to pause units
AnyVariable Glob or Loc
[var]-[var]-[var]
1.5+(Level*1.5)
2.+(Level*2.) and so on
For example:
It should be Unit - Add a [var]+[var]*[var] second Generic expiration timer to F_Dummy

Or set my_var=[var]+[var]*[var]

Or set my_var=1.5+(Level*1.5)

Unit - Add a [my_var] second Generic expiration timer to F_Dummy

After all how can whatever you want
FACELESS VOID CHRONOSPHERE

 

[Tank-Commander]

I'd also like to just point out - The spell as it is would work against buildings, magic immunes, dead units, etc.

 

[furryfox92]

I just fixed that so it will be the level is based on how long the unit is frozen, in other words level 1 freezes for 1 second level 2 for 2 seconds ect. does that seem fair or should i base it off a different system?

 

[zv27]

I just fixed that so it will be the level is based on how long the unit is frozen, in other words level 1 freezes for 1 second level 2 for 2 seconds ect. does that seem fair or should i base it off a different system?

Still missing the trigger

 

[furryfox92]

Still missing the trigger

i tested it out though, and the time changes based off the level

 

[zv27]

i tested it out though, and the time changes based off the level

1: Post Trigger
2: And after updating everything else is almost the same

your trigger after updating

• F1
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Hashtable - Create a hashtable
    • Set F_Hash = (Last created hashtable)

• F 2
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Time Stop
  • Actions
    • Set F_Caster = (Triggering unit)
    • Custom script: set udg_F_Handle = udg_F_Caster
    • Set F_point = (Target point of ability being cast)
    • Unit - Create 1 Stop Time Dummy for (Owner of F_Caster) at F_point facing Default building facing degrees
    • Set F_Dummy = (Last created unit)
    • Hashtable - Save (Real((Level of Time Stop for F_Caster))) as 1 of (Key F_Handle) in F_Hash
    • Unit - Add a (Load 1 of (Key F_Handle) from F_Hash) second Generic expiration timer to F_Dummy
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 500.00 of F_point matching (((Matching unit) belongs to an enemy of (Owner of F_Caster)) Equal to True)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) is alive) Equal to True
          • Then - Actions
            • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\Invisibility\InvisibilityTarget.mdl
            • Set F_Effect = (Last created special effect)
            • Custom script: call DestroyEffect(udg_F_Effect)
            • Unit - Pause (Picked unit)
            • Animation - Change (Picked unit)'s animation speed to 0.00% of its original speed
            • Animation - Change (Picked unit)'s vertex coloring to (80.00%, 80.00%, 80.00%) with 40.00% transparency
            • Trigger - Turn on F 3 <gen>
          • Else - Actions
        • Custom script: call RemoveLocation(udg_F_point)

• F 3
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Stop Time Dummy
  • Actions
    • Set F_point = (Position of (Dying unit))
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 500.00 of F_point matching (((Matching unit) belongs to an enemy of (Owner of F_Dummy)) Equal to True)) and do (Actions)
      • Loop - Actions
        • Unit - Unpause (Picked unit)
        • Animation - Change (Picked unit)'s vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
        • Animation - Change (Picked unit)'s animation speed to 0.00% of its original speed
        • Custom script: call RemoveLocation(udg_F_point)

I guess this will help

This is absolutely unnecessary here

• Hashtable - Save (Real((Level of Time Stop for F_Caster))) as 1 of (Key F_Handle) in F_Hash
• Unit - Add a (Load 1 of (Key F_Handle) from F_Hash) second Generic expiration timer to F_Dummy

try this

• Set my_abilityVar = Time Stop
• Set my_integerVar = (Level of my_abilityVar for F_Caster)
• Set my_realVar = (1.50 + ((Real(my_integerVar)) x 1.50))
• Unit - Add a my_realVar second Generic expiration timer to F_Dummy

or like this

• Set my_abilityVar = Time Stop
• Set my_integerVar = (Level of my_abilityVar for F_Caster)
• Set my_realVar1 = 1.50 // or 2.00 or blabla
• Set my_realVar2 = 1.50 // here also
• Set my_realVar3 = (my_realVar1 + ((Real(my_integerVar)) x my_realVar2))
• Unit - Add a my_realVar3 second Generic expiration timer to F_Dummy

can still in many ways...blabla

this also

• Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\Invisibility\InvisibilityTarget.mdl
• Set F_Effect = (Last created special effect)
• Custom script: call DestroyEffect(udg_F_Effect)

Example: First to take out unnecessary function

• Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\Invisibility\InvisibilityTarget.mdl
• Special Effect - Destroy F_Effect

Example 2: It should look like this

• Special Effect - Create a special effect attached to the origin of my_unitvar using my_stringvar
• Special Effect - Destroy F_Effect

Now as regards the location
You did it like this

• Unit Group - Pick every unit in (Units within 500.00 of F_point matching (((Matching unit) belongs to an enemy of (Owner of F_Caster)) Equal to True)) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is alive) Equal to True
      • Then - Actions
        • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\Invisibility\InvisibilityTarget.mdl
        • Set F_Effect = (Last created special effect)
        • Custom script: call DestroyEffect(udg_F_Effect)
        • Unit - Pause (Picked unit)
        • Animation - Change (Picked unit)'s animation speed to 0.00% of its original speed
        • Animation - Change (Picked unit)'s vertex coloring to (80.00%, 80.00%, 80.00%) with 40.00% transparency
        • Trigger - Turn on F 3 <gen>
      • Else - Actions
    • Custom script: call RemoveLocation(udg_F_point)

and it should be something like

• Unit Group - Pick every unit in (Units within 500.00 of F_point matching (((Matching unit) belongs to an enemy of (Owner of F_Caster)) Equal to True)) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is alive) Equal to True
      • Then - Actions
        • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\Invisibility\InvisibilityTarget.mdl
        • Set F_Effect = (Last created special effect)
        • Custom script: call DestroyEffect(udg_F_Effect)
        • Unit - Pause (Picked unit)
        • Animation - Change (Picked unit)'s animation speed to 0.00% of its original speed
        • Animation - Change (Picked unit)'s vertex coloring to (80.00%, 80.00%, 80.00%) with 40.00% transparency
        • Trigger - Turn on F 3 <gen>
      • Else - Actions
• Custom script: call RemoveLocation(udg_F_point)

Now as regards the group

• Unit Group - Pick every unit in (Units within 500.00 of F_point matching (((Matching unit) belongs to an enemy of (Owner of F_Caster)) Equal to True)) and do (Actions)
  • Loop - Actions

fuck it can no longer

How I started a little more and the entire spell will be over

 

[furryfox92]

how do i post the trigger? o3o sorry .w. i am like really new "I think it's a lot more explaining What will you doing that if I put the whole spell muhahahaha" i cant really understand you.. sorries, but thanks and stuff and when you corrected my location thing it looks exactly the same as mine

 

[zv27]

Copy the triggers from the World Editor (Right click on the name of the trigger above the events and click "Copy as Text")

Then paste the triggers between [HIDDEN="I am the trigger"][TRIGGER]PASTE HERE[/TRIGGER][/HIDDEN] tags

 

[nafre]

Isnt there already a spell like this. If I remembered right it was named Stop. And there was a red circle in the preview picture.

 

[furryfox92]

im unaware of any other spells that might be like mine, i originally came up with it so if there is another like this then sorry

 

[Tank-Commander]

Well to be blunt the time-stopping Idea has been done many times, (typically) in a simple fashion and there is still yet to be one which is quite to my liking (there's always one or two things I'm always picky about) and the reason this is, is simply because we're all human - so when it comes to spell making ideas most of the time we come up with the same things, or atleast that's how I see it.

 

[Adiktuz]

5 triggers for this is just too much...

 

[furryfox92]

5 triggers for this is just too much...

okay well it was being called to simple, now its "to much" make up your mind people

 

[Adiktuz]

I said the triggers were too much, not the spell itself...

and the reason 5 triggers for this spell is too much is because this idea is too simple... learn to understand friend... XD...

 

[furryfox92]

i did understand, you just made it sound otherwise. learn to express your point