Stonneash's item recipe system

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

04:23, 16th Jul 2012
Magtheridon96:

I'll just quote my comments in the posts:

Comments

• Don't use the waits. You can remove them entirely and have the system unaffected.
• Don't store the effect in a variable, just destroy the last created special effect.
• You shouldn't use that huge if block to check if the unit has all the items, you should use some other method. Currently, this will only work if all 3 items are in the first three slots.
• The progress bar is useless because it shows up only when you complete a recipe.
• You need to make the system in such a way so that the player
  doesn't need to create more than one trigger to create his recipes.
  Something along the lines of:
  
  Init Trigger Example

  • Recipe Init
    • Events
      • Map Initialization
    • Conditions
    • Actions
      • Set RecipeItem1 = Gloves of Haste
      • Set RecipeItem2 = Ring of Health
      • Set RecipeItem3 = Ring of Regeneration
      • Set RecipeResult = Enchanted Gauntlet
      • Trigger - Execute CreateRecipe <gen> (ignoring conditions)
      • -------- ---- --------
      • Set RecipeItem1 = Ring of Protection
      • Set RecipeItem2 = Ring of Health
      • Set RecipeResult = Enchanted Hood
      • Trigger - Execute CreateRecipe <gen> (ignoring conditions)
      • -------- ---- --------
      • Set RecipeItem1 = Ring of Health
      • Set RecipeItem2 = Claws of Attack
      • Set RecipeResult = Power Brace
      • Trigger - Execute CreateRecipe <gen> (ignoring conditions)

 

[Almia]

Post Triggers

 

[stonneash]

Triggers
Setup and Result
P.S.
Picture 2&3 are 1 trigger and Picture 1 is one trigger

 

[-3nigmaSt-]

Is there something wrong with this system, my wc3 crashes when i test the map. Also, this leaks and...

 

[Almia]

Please use this in posting triggers:

https://www.hiveworkshop.com/forums/misc.php?do=bbcode#trigger\

You can copy the text of your triggers by right-clicking the icon of the name of the trigger(Ex.[trigger=]Name of your trigger
Events
Conditions
Actions[/trigger]
After right-clicking,you will see this line(Copy triggers as text)then click it then right-click paste to post it.

 

[maddeem]

Is there something wrong with this system, my wc3 crashes when i test the map. Also, this leaks and...

and... not MUI

 

[zv27]

and... not MUI

...and too simple

 

[Noobsmoke]

Worst recipe system that I have ever seen, sorry 1/5

 

[Almia]

Ill give -1/5 for Rejection

 

[WindowsVistaSucks]

We don't need these kind of things. They're way too simple.

 

[Magtheridon96]

smooth functions

What exactly do you mean?


Tips:
- Don't use the waits. You can remove them entirely and have the system unaffected.
- Don't store the effect in a variable, just destroy the last created special effect.
- You shouldn't use that huge if block to check if the unit has all the items, you should use some other method. Currently, this will only work if all 3 items are in the first three slots.
- The progress bar is useless because it shows up only when you complete a recipe.

 

[edo494]

simple doesn't necessarily mean useless
my two cents

 

[Magtheridon96]

But this is not very useful.
It's very cumbersome to work with if you're going to need to create two triggers per recipe and figure out how to change the conditions so that it works.

 

[edo494]

I didn't rate this source, just pointed out that even simple things can be great

 

[stonneash]

Stop telling me that system isn't good ,and start giving Suggestions!!!!!!!!!!!!!!!

 

[Magtheridon96]

I did give you some suggestions. :C

Okay, I'll give you some more:

You need to make the system in such a way so that the player doesn't need to create more than one trigger to create his recipes.

Something along the lines of:

• Recipe Init
  • Events
    • Map Initialization
  • Conditions
  • Actions
    • Set RecipeItem1 = Gloves of Haste
    • Set RecipeItem2 = Ring of Health
    • Set RecipeItem3 = Ring of Regeneration
    • Set RecipeResult = Enchanted Gauntlet
    • Trigger - Execute CreateRecipe <gen> (ignoring conditions)
    • -------- ---- --------
    • Set RecipeItem1 = Ring of Protection
    • Set RecipeItem2 = Ring of Health
    • Set RecipeResult = Enchanted Hood
    • Trigger - Execute CreateRecipe <gen> (ignoring conditions)
    • -------- ---- --------
    • Set RecipeItem1 = Ring of Health
    • Set RecipeItem2 = Claws of Attack
    • Set RecipeResult = Power Brace
    • Trigger - Execute CreateRecipe <gen> (ignoring conditions)

Does that look really awesome?

Your system would check all the variables (RecipeItem1, RecipeItem2, RecipeItem3, RecipeItem4, RecipeItem5 and RecipeItem6), or better yet, instead of 6 different variables, make an array called RecipeItem and you would check RecipeItem[1] to RecipeItem[6].

Then, you would put the item types that are given by the user in the RecipeItem array into another array which you will use in your system.

Actually, not 1 array, but 7 arrays:

- RecipeItems1
- RecipeItems2
- RecipeItems3
- RecipeItems4
- RecipeItems5
- RecipeItems6
- RecipeItemResults
- RecipeItemCounts

The first 6 arrays contain the items that make each recipe and the seventh one contains the result item of the recipe. The last one contains the number of items that make each recipe.

CreateRecipe puts the item types in RecipeItem[] into these arrays and figures out the count.

When a unit picks up an item, you should loop from 1 to the number of recipes that are in the map, check if the unit has all the items, and if he does, remove those items and give him an item of type RecipeItemResults[(Integer A)].


To see examples of how people do this, you can search for some good GUI recipe systems.
Here's a really good one: https://www.hiveworkshop.com/forums/spells-569/m-fis-v1-7-a-210505/