[JASS] Stacking for in battle detection

[Titanhex]

Here is my current damage detection system:

http://www.wc3c.net/showpost.php?p=1024305&postcount=2

Right now what happens is if a unit recieves or deals damage, he will be place in a group for 3 seconds, then removed.

Only problem is, right now it doesn't stack. If the unit takes damage he's removed 3 seconds after the first initial damage, even if he's damaged 2 seconds later, he'll be removed from the group in 1 second.

I'm wondering how I can fix this. I haven't had to worry about stacking effects yet.

This is important since some of the AI I'm creating relies on inBattle detection, as well as the custom healing. It's obviously buggy without stacking.

Thanks

inBattle

scope InBattleDetector initializer Init 

globals
    group inBattle
endglobals

private struct Data

    unit c
    unit d

    static method create takes unit battler, unit hurtingbattler returns Data
     local Data D = Data.allocate()
      set D.c = battler
      set D.d = hurtingbattler
     return D
    endmethod
    
endstruct

private function Timer takes nothing returns nothing
 local timer tim = GetExpiredTimer()
 local Data D = Data(GetTimerData(tim))
    call GroupRemoveUnit(inBattle, D.c)
    call GroupRemoveUnit(inBattle, D.d)
 call ReleaseTimer(tim)
 call D.destroy()
endfunction

private function Conditions takes nothing returns boolean
    local timer tim = NewTimer()
    local real d = GetEventDamage()
    local Data D = Data.create(GetTriggerUnit(), GetEventDamageSource())
    set inBattle = CreateGroup()
    if d > 0 then
        call GroupAddUnit(inBattle, D.c)
        call GroupAddUnit(inBattle, D.d)
        call SetTimerData(tim,D)
        call TimerStart(tim, 3.0, false, function Timer)
    endif
    return false
endfunction

private function Init takes nothing returns nothing
    call AddDamageCondition(Condition(function Conditions))
endfunction

endscope

 

[Maximilianx]

I didn't look over everything completely, but maybe instead of making a new timer every time the unit takes damage, designate that unit a single timer, and reset it when he takes damage again.

 

[Titanhex]

The only thing is how do I resert timers?

 

[PurgeandFire]

Haven't tested it but you can try using these:

native PauseTimer           takes timer whichTimer returns nothing
native TimerStart           takes timer whichTimer, real timeout, boolean periodic, code handlerFunc returns nothing

Not really "resetting" it. But you know... =P Not sure if the timer will stay frozen or not if it gets started again.

 

[Titanhex]

Well I was thinking that instead of doing a timer every time it recieves or deals damage, it'll place the unit in the group and pause the timer until the unit hasn't recieved damage for a while.

I'm not sure how to pause that specific timer though. Actually it's that I don't know how to call that timer back up when the unit gets hit and then tell it to pause. Any help or suggestions? I know there's a way to check if there's info on something, but I don't know the specifics. :\

 

[Bribe]

You don't need to pausetimer to run the same timer. a single TimerStart will do the trick.

 

[Drenferalis]

You don't need to pausetimer to run the same timer. a single TimerStart will do the trick.

For clarification will TimerStart() set the duration of the timer back, add to it, or continue using the old duration?

 

[PurgeandFire]

For clarification will TimerStart() set the duration of the timer back, add to it, or continue using the old duration?

It will set the duration of the timer to whatever you input as the timeout. It won't add or subtract. =)