[Snippet] Trigger

[Nestharus]

This resource has moved here.

--

gone

 

[loveqiezi]

look nice

 

[Almia]

You should rename TriggerRefresh' struct then

 

[mckill2009]

Interesting but you should exercise in giving a sample map to all your resources that requires a lot of library importation, coz as of the moment it requires 7 libraries, some people like me is too lazy to browse just to get those libraries...your missing 1 api declaration btw...

 

[Magtheridon96]

The maps and examples are likely incoming.
There's a lot of stuff to code so we can achieve faster triggers ;O

 

[Nestharus]

Added enabled

Fixed requirements list

edit
Another update

Added 2 new methods + specified what each method does

*           method clear takes nothing returns nothing
*               -   clears expressions
*           method clearReferences takes nothing returns nothing
*               -   clears trigger references
*           method clearBackReferences takes nothing returns nothing
*               -   removes references for all triggers referencing this trigger

 

[PurgeandFire]

You should add a description in the post of what the system is for (assuming you want people to use it).

In the documentation:

/*
* readonly trigger triggger
*/

->

/* 
* readonly trigger trigger
*/

 

[Nestharus]

Fixed documentation

Put example code into map. Read through the examples to see how to use this system =). Keep in mind that it uses Boolean Expressions internally, so it's also faster than native triggers that rely on just TriggerAddCondition.

 

[mckill2009]

Now nice, voting for approval...

 

[looking_for_help]

Can you provide some benchmark results to point out when and how much this is faster than using "normal" triggers?

 

[Magtheridon96]

http://www.hiveworkshop.com/forums/lab-715/faster-triggers-240255/

 

[looking_for_help]

What was the benchmark setup? That isn't specified there. Also "many" bollean expressions is not really specific.

I'm asking because I don't get similar results when trying to reconstruct this.

 

[Nestharus]

Trigger may have nulls in it and creates more malformed trees than BooleanExpression by itself does (due to refs etc). Or(null) performs more slowly than TriggerAddCondition(null).

If you compare BoolanExpression to a trigger, then u'll see the dif .

edit
Even in the case of having nulls, this still performs close to a trigger with trigger conditions of nulls. The pros of being able to reference triggers and remove trigger conditions = awesome. Furthermore, it still always performs faster than TriggerExecute.

 

[looking_for_help]

Alright, I managed to set up an appropriate Benchmark. I measured a difference of ~10 fps in advantage to this system.
This seems to be really awesome in terms of performance.

One drawback is you can't register more than 4096 callback functions in total. You should catch that with ErrorMessage.

EDIT:
It seems that this is bugged if the amount of registered events gets close to 4096. I registered 4050 onDamage handlers
but only 4033 got fired. It seems some handlers got lost.

 

[Nestharus]

Nobody in their right mind would have that many registered events ;P

Only 4033 got fired probably because you hit op limit during registration or something, dunno tbh =), prob wc3 tho

 

[looking_for_help]

Well, via natives methods I can add as many conditions as I want, it is only limited by RAM. So you should consider this.

 

[Nestharus]

It uses Or(), so trying making mass Or() and see how many you can do

 

[Nestharus]

Updated map to have latest Boolean Expression library.

The updates to BooleanExpression reduce operations when building triggers and increase performance when running triggers.

I highly recommend that you get the update.


Trigger registers null boolean expressions in order to hold positions. The new BooleanExpression library will not include these null expressions in the final output. A null expression does reduce trigger speed. As these null expressions are no longer included in the final output, Trigger will get a speed boost.

 

[Nestharus]

Ok everyone, sorry about this, but the BooleanExpression update wrecked Trigger, lol.

I'll be updating Trigger to work with the new behavior of BooleanExpression.

edit
Fixed BooleanExpression (the new builder was bugged), but Trigger is still having problems >.<.

Where t1 is empty, t2 has a function, and t3 has a function

t1.reference(t2)
t2.reference(t3)

that only runs t2

edit
I managed to reproduce the problem exactly only using BooleanExpression and the shifting algorithm from Trigger. It appears that the shifting algorithm in Trigger is bad. I'll work on a fix. Not sure what's wrong with it, but I'll try to figure it out. It's only 3 lines, lolz.

edit
And fixed!! : D

Wow, that was crazy to debug

edit
*rage*

I put in a fail-safe way to stop these boolean expressions from destroying themselves!! >;o, rawr

Added new methods to TriggerCondition and TriggerReference

edit
yet another update, included a couple of debug checks

 

[Zeatherann]

So, how does this piece of code construct triggers?

 

[Nestharus]

http://www.hiveworkshop.com/forums/lab-715/faster-triggers-240255/

 

[Zeatherann]

loop
     exitwhen globalNode == 0

     loop
         exitwhen localNode.priority > globalNode.priority
         set expr = Or(expr, localNode.expr)
     endloop

     set expr = Or(expr, globalNode.expr)

     set globalNode = globalNode .next
endloop

Like this?

 

[Nestharus]

no, that would be slower than native triggers


It's more like

expr3 = Or(expr1, expr2)
expr4 = Or(expr5, expr6)
expr7 = Or(expr3, expr4)

it builds a tree, not a list

 

[Zeatherann]

Okay, cool. So, how does this library take a list and turn it into a tree, if that's what it does.

 

[Nestharus]

It doesn't... it takes a tree.. and... gives you a tree, lol

 

[Zeatherann]

How would a user create the tree then?

 

[Luorax]

It's not the user, but the code. You can just keep registering the boolexprs via the interface methods, and the snippet will take care of the rest.

 

[Zeatherann]

Okay, cool.

 

[BPower]

This worked without throwing an error. But I'm not sure if I double destroy the BooleanExpression here:
call myTrigger.clear() call myExpr[this].destroy()

private struct myStruct extends array
        implement Alloc
        
        private static Table table
        readonly static Trigger myTrigger
        readonly static BooleanExpression array myExpr

    private static method run takes nothing returns boolean
        local integer id = //1, 2, Get any Integer used in method xy
        local thistype this
        set this = table[id]
        call myTrigger.register(expr[this].expression)
        call myTrigger.fire()
        call myTrigger.clear()
        call myExpr[this].destroy()
        //call this.deallocate()
        return false
    endmethod

    private static method xy takes integer id, boolexpr expr returns nothing
        local thistype this = allocate()
        set table[id] = this
        set myExpr[this] = BooleanExpression.create()
        call myExpr[this].register(expr)
    endmethod
    
    private static method onInit takes nothing returns nothing
        set table = Table.create()
        set myTrigger = Trigger.create()
        call xy(1, Condition(function anyStruct.fire))
        call xy(2, Condition(function anyStruct.fire2))
    endmethod
    
endstruct

 

[Nestharus]

If it didn't throw an error in debug mode, then you didn't double free.


There is intense safety checking in BooleanExpression and Trigger.

 

[BPower]

In practise I used this (originally it is ofc a bit more code) for registering Quests based on bought Items.
So there is a corresponding ItemTypeId to a boolexpr.
The array stores around 20 Items/expressions.
And I don't get an error in debug mode.

 

[Nestharus]

The problem isn't you storing expressions, the problem is BooleanExpression storing boolexpr :\.

20 BooleanExpressions could easily be 80-400. At 8192, it goes boom.

 

[BPower]

Ok I got it. Then I will store the boolexpr in table and register it to one BooleanExpression instead of using an array and clear it afterwards.

Looks like this now, and throws no error and is working.

EDIT:

call myExpr.register(tb.boolexpr[id])
call myTrigger.register(myExpr.expression)
call myTrigger.fire()
call myExpr.clear()
call myTrigger.clear()

 

[Nestharus]

Ok I got it. Then I will store the boolexpr in table and register it to one BooleanExpression instead of using an array and clear it afterwards.

Don't do that, that'll kill the point of BooleanExpression, lol.

 

[BPower]

Don't do that, that'll kill the point of BooleanExpression, lol.

Yes, in my enthusiasm I forgot that . :/