[Snippet] [Needs work] Advent

[Troll-Brain]

I don't have the use for it, because if i need a dynamic event i would just use a dynamic trigger and don't have use of "data", but nevermind you don't have to convince me, i've just found something lame imho.
Since you are using LinkedListModule, and especially the method insertNode, which for some reason is actually reverting the relative order (i mean i don't know why Dirac has chosen this way), you would use "prev" instead of "next" in you fire method.

Because with this sample :

scope Test initializer init

    private function F1 takes nothing returns nothing
        call BJDebugMsg("F1")
    endfunction
    
    private function F2 takes nothing returns nothing
        call BJDebugMsg("F2")
    endfunction

    private function init takes nothing returns nothing
        local Advent ev = Advent.create()
        call ev.registerEx(function F1)
        call ev.registerEx(function F2)
        call ev.fire()
    endfunction
    
endscope

The expected messages are "F1" and then "F2", not the opposite.
Ofc that probably doesn't matter that much, but i think it makes more sense this way.

 

[Bribe]

He uses prepend and not append? Append makes the most sense for something like this. If he reads this he can note that we'd rather have "insertNode" do an append instead of a prepend.

 

[Dirac]

call ev.fire()
Here hes firing a null trigger, if you can tell why I'll give you a prize.

Yes, because of how linked list works it will always fire first the node you added last.
But Bribe made it even weirder, if you call "this.fire" the codes registered to the "this" instance are fired LAST, this I fixed in the version above

 

[Bribe]

Your "fix" goes against the entire philosophy of privatization, but this one little thing you mentioned seems like a good idea which I should include.

 

[Magtheridon96]

Ofc that probably doesn't matter that much, but i think it makes more sense this way.

Actually, it's very important.

Here's a theoretical example:
Let's say I register 2 codes and one of the functions I registered contains an if block that only executes the code within it if some boolean X == true.
When I execute the first function, it's sets X to true.
The second function will set X to false at the end.
If this doesn't execute code1 before code2, code2 wouldn't execute :c

 

[Troll-Brain]

What i meant, is that i consider a such practice, a bad one, or i'm missing something.
But it's usually how jass triggers work. (first created, first used)

 

[Magtheridon96]

Status report?

 

[Bribe]

This can be gy'ded