[Snippet] GetPointZ and UnitZ

[overcold_ice]

//========================================================================================
//      
//      GetPointZ
//      -*- overcold_ice -*-
//      
//     -[*] Requirements:
//          - JNGP
//          - latest version of JassHelper
//      
//     -[*] API:
//      
//      function GetPointZ takes real x, real y returns real
//          returns the terrain z value of point [x, y]
//      
//========================================================================================
library GetPointZ
    
    globals
        private location _loc = Location(0, 0)
    endglobals
    
    function GetPointZ takes real x, real y returns real
        call MoveLocation(_loc, x, y)
        return GetLocationZ(_loc)
    endfunction
    
endlibrary

//========================================================================================
//      
//      UnitZ
//      -*- overcold_ice -*-
//      
//     -[*] Requirements:
//          - JNGP
//          - latest version of JassHelper
//      
//     -[*] Optional Requirements:
//          - AutoFly
//              http://www.hiveworkshop.com/forums/jass-resources-412/snippet-autofly-unitindexer-version-195563/
//          - GetPointZ
//      
//          Adds the real UnitZ functions (not UnitFlyHeight)
//      
//     -[*] API:
//      
//      function GetUnitZ takes unit u returns real
//          returns the terrain z value of point [ux, uy] + its FlyHeight
//      function SetUnitZ takes unit u, real z returns nothing
//          sets the unit's FlyHeight to (z - ground z at [ux, uy])
//      
//========================================================================================
library UnitZ requires optional AutoFly, optional GetPointZ
    
    globals
        private location _loc = Location(0, 0)
    endglobals
    
    function GetUnitZ takes unit u returns real
        static if not LIBRARY_GetPointZ then
            call MoveLocation(_loc, x, y)
            return GetLocationZ(_loc) + GetUnitFlyHeight(u)
        else
            return GetPointZ(GetUnitX(u), GetUnitY(u)) + GetUnitFlyHeight(u)
        endif
    endfunction
    function SetUnitZ takes unit u, real z returns nothing
        static if not LIBRARY_AutoFly then
            if UnitAddAbility(u, 'Amrf') and UnitRemoveAbility(u, 'Amrf') then
            endif
        endif
        
        static if not LIBRARY_GetPointZ then
            call MoveLocation(_loc, GetUnitX(u), GetUnitY(u))
            call SetUnitFlyHeight(u, z - GetLocationZ(_loc), 0)
        else
            call SetUnitFlyHeight(u, z - GetPointZ(GetUnitX(u), GetUnitY(u)), 0)
        endif
    endfunction
    
endlibrary

 

[Bannar]

Are my eyez o'right?

Two libraries instead of one? No Fly library required?
Not every unit can fly by default. Have you even tested this?

The goal you want to achieve here is already implemented in plenty of sites. Even in Small Code Snippets there should be one.

 

[overcold_ice]

oh forgot about the 'fly' thing :3

and it's 2 libraries, not one
they are a bit different

updated that 'fly' thing

 

[Magtheridon96]

call UnitAddAbility(u, 'Amrf')
call UnitRemoveAbility(u, 'Amrf')

->

if UnitAddAbility(u, 'Amrf') and UnitRemoveAbility(u, 'Amrf') then
endif

This has been done so many times before.
I can't count the number of times it's been done using my hands and feet and that should tell you something.

I don't know if I should approve it.
I can, and for modularity, I probably would, but why?

 

[Bannar]

You can aprove and graveyard this - or just graveyard. As I've said already - various versions of SetUnitZ were around here since 2007 or even earlier. Not to mention thehelper or wc3c sites.

 

[overcold_ice]

@mag: thx for that 'if' correction

hmmm . . .
so that's it
you can gy this anyway, it's extremely small

i post it since i don't see anything like this around, i didn't check the small code snippets though
my reason is just because this thing helps my stuffs
and probably will help anyone else

moving loc to get ground z manually is tiring
and more when you use it in conjunction with unit's z

 

[Almia]

Idk. But i think this shall be submitted in Small Code Snippets thread right?

 

[Bannar]

^It is already if I'm not mistaken. If you use search engine, it will come up with ton of similar stuff.

 

[Almia]

If its so, Votes for GY.

 

[Magtheridon96]

Graveyarded.