[Trigger] Selected units by player

[Ironside]

In the bellow trigger (the event is added on map ini (any player writes -f as substring).

It works fine, but if a player uses it while he has no units selected then the whole game freezes or random strange bugs occur. I'm sure checking for if group is empty won't work due to some of the errors I saw till now...

How would I fix it?

• Set Facing
  • Events
  • Conditions
  • Actions
    • Set TempInt = (Integer((Substring((Entered chat string), 3, 8))))
    • Unit Group - Pick every unit in (Units currently selected by (Triggering player)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • And - All (Conditions) are true
              • Conditions
                • (Titan Palace <gen> contains (Picked unit)) Equal to False
                • (Owner of (Picked unit)) Equal to (Triggering player)
          • Then - Actions
            • Custom script: call SetImmovableUnitFacing(GetEnumUnit(), udg_TempInt)
          • Else - Actions
    • Custom script: call DestroyGroup(bj_lastCreatedGroup)

 

[Maker]

• Untitled Trigger 030
  • Events
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Set i = (Number of units in (Units currently selected by (Triggering player)))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • i Greater than 0
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Triggering unit) is A structure) Equal to True
            • ((Triggering unit) is A Hero) Equal to True
          • Then - Actions
          • Else - Actions
      • Else - Actions

You don't need the extra AND for the conditions, also there is no bj_lastCreatedGroup involved here.

 

[Ironside]

Ok thank you, I'll try this out.

 

[Ironside]

Bump, I tried it but even with this it causes some very strange errors whenever it's used.
Examples: units can't move, units move by themselves, can't use spells, ...

 

[Bribe]

What's your current trigger look like now?

 

[Ironside]

This is how it looks like currently:

• Set Facing
  • Events
  • Conditions
  • Actions
    • Set TempInt = (Integer((Substring((Entered chat string), 3, 8))))
    • Set TempGroup = (Units currently selected by (Triggering player))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in TempGroup) Greater than 0
      • Then - Actions
        • Unit Group - Pick every unit in TempGroup and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Or - Any (Conditions) are true
                  • Conditions
                    • (Titan Palace <gen> contains (Picked unit)) Equal to True
                    • (Owner of (Picked unit)) Not equal to (Triggering player)
              • Then - Actions
                • Unit Group - Remove (Picked unit) from TempGroup
              • Else - Actions
        • Unit Group - Pick every unit in TempGroup and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • And - All (Conditions) are true
                  • Conditions
                    • (Titan Palace <gen> contains (Picked unit)) Equal to False
                    • (Owner of (Picked unit)) Equal to (Triggering player)
              • Then - Actions
                • Custom script: call SetImmovableUnitFacing(GetEnumUnit(), udg_TempInt)
              • Else - Actions
      • Else - Actions
    • Custom script: call DestroyGroup(udg_TempGroup)

 

[Bribe]

Why are you using SetImmovableUnitFacing if you said the units should be able to move? Just use "SetUnitFacing" then.

First, you can greatly simplify your trigger:

• Select
  • Events
  • Conditions
  • Actions
    • Set TempInt = (Integer((Substring((Entered chat string), 3, 8))))
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units currently selected by (Triggering player)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Titan Palace <gen> contains (Picked unit)) Equal to False
            • (Owner of (Picked unit)) Equal to (Triggering player)
          • Then - Actions
            • Custom script: call SetImmovableUnitFacing(GetEnumUnit(), udg_TempInt)
          • Else - Actions

Second, SetImmovableUnitFacing uses SetUnitPosition, which issues the "stop" order. So whenever this trigger fires, all the units will get issued stop orders.

 

[Ironside]

The problem is, that without moving the unit first it doesn't seem to work on buildings. I also decided to only make it work if the selected count equals to 1 unit.

Here's the new trigger:

• Set Facing
  • Events
  • Conditions
  • Actions
    • Set TempInt = (Integer((Substring((Entered chat string), 3, 8))))
    • Set TempGroup = (Units currently selected by (Triggering player))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in TempGroup) Equal to 1
      • Then - Actions
        • Unit Group - Pick every unit in TempGroup and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • And - All (Conditions) are true
                  • Conditions
                    • (Titan Palace <gen> contains (Picked unit)) Equal to False
                    • (Owner of (Picked unit)) Equal to (Triggering player)
              • Then - Actions
                • Unit - Make (Picked unit) face (Real(TempInt)) over 0.00 seconds
                • Custom script: call SetImmovableUnitFacing(GetEnumUnit(), udg_TempInt)
              • Else - Actions
      • Else - Actions
    • Custom script: call DestroyGroup(udg_TempGroup)

 

[Cokemonkey11]

you can make it work how you wanted it by changing the condition

number of units equal to 1

into

number of units not equal to 0

 

[Ironside]

It used to be that way, now it needs to be only if it's equal to 1 unit.

 

[Cokemonkey11]

So.. this thread is already solved?

Sorry then.

 

[Ironside]

Just tested it again, it won't work most of the times at all, bugs still happen like units freeze, can't use spells, etc.
Pick units currently selected must clearly be bugged...

 

[SA Dashie]

Run some tests to see if some combinations of function could be causing it. For example if I remember right, from previous experiences setting a units facing angle over 0.00 seconds isn't instant. Prehapse replace it with this function as it doesn't require a wait (as I have observed).

call SetUnitFacing(udg_Unit, bj_UNIT_FACING)

Although I have not actually tested it without doing it this way before though.

 

[Bribe]

That function performs the same as SetUnitFacingTimed with a value of 0.

 

[SA Dashie]

yes, but it doesn't suggest for a possible turn for the unit so it should just set it directly set the angle instead of having suggest that it may make another slight wait for it to function although it is set to 0.00 seconds. Anyway I am only suggesting that this may help with a function like the one done in the trigger strait after.
I am only suggesting that it is worth a try considering that some WE functions are bugged and this may fix the problem.

 

[Ironside]

The point is, there is a similar trigger in the map which was used to resize units, same problems.
Without doubt it was the pick units selected by player that is bugged.

Anyway I decided to not use it at all, and made it like a spell, which now solves this problem.