scorpion182's spellpack 1 v1.1

[Moderator]

21:08, 18th Dec 2008
Hanky:
Well the spells are ok so far. The script is ok, also it seems to be leakless and MUI. But you should learn not to use TriggerSleepAction functions because that's not good for multiplayer. Also you should use not much location function because it would be much more effective to use x/y. Well the visual effects are ok. The documentation is abit to less but I think it's still acceptable.

All in all two good spells with some space to improve. I can just recommend to use this spells if someone searching spells like these.

Possible Improvements:
- get rid of the TimerSleepAction and the location functions
- sometimes the jass could be much more effective used
- also maybe using the function of the JNPG would make the spellpack more alot more effecient

 

[TheBlooddancer]

I'll check this after class's.

 

[scorpion182]

ok thanks

 

[tuantai120]

hey scorpion182
i need model Black Tornado and Gaia Force in Grand battle
can u upload in this web site?
thanks very much )

 

[xxdingo93xx]

Note that my rating will not have any influence to moderators reviews.
This review consists out of my personal attidude and opinion about this spell/these spells.

Idea/Creativity: 6/10
Coding: 8/10
Balance: 8/10
Ability Tooltip: 10/10
MUI: Yes (+2/10)
(Yes: +2/10, No: -2/10, MPI: +/-0/10)
Language: Jass (+1/10)
(GUI: +/- 0/10, Jass: +1/10, vJass: +2/10)
Total: 35/40

Medial: 8/10 = 4/5

Viewers Note:
Ahh...good old Jass spells .. ^^ The spell Broken Phantasm is pretty neat, the Mamaragan is rather simple but OK.
Your coding seems to be OK except of some flaws.

1.

local location loc=GetUnitLoc(target)

Locations shouldn't be used. As I can see correnctly, you don't even use it. So better delete it ^^
2.
Get rid of the TriggerSleepActions.
3.

    local unit dum1
    local unit dum2
    local unit dum3

A unit array would save lines and make it look better. So you can also use a loop.

It is balanced well, though I recommend to define the damage in a seperate function to make it easier configurable. Documentation is well made except of telling about rawcodes.
No need to tell much about the ability tooltip, it is just perfect.
MUI and Jass -> extra score.

All in all neat (good old Jass) Spells, recommendable. Fix the things I mentioned and it would be even better.

 

[tuantai120]

srr i don't see about that spell
can u help me? scorpion182
plzzzz i beg u
i need spell Black Tornado and Gaia Force of Mega Digimon in Grand Battle AI.v1

 

[scorpion182]

@xxdingo93xx
thanks for the suggestion, i'll update this spellpack soon. but i can't get rid of the TriggerSleepActions, cause i need it to hold the trigger before the missile hit the target

@tuantai120
i'll upload those spells someday but not now, please understand

UPDATED
v1.1
- Deleted Unneeded Variabel
- Added Preload Ability Trigger to Avoid First Time Casting Lag
- Fixed Code Follow xxdingo93xx Suggestion
- Fixed Mamaragan Damage Configuration

 

[tuantai120]

thanks very much

 

[pkw]

ah, you have it in here too ^^ . Nice Mamaragan spell you have there. 4/5 for you. (another 1 I wan more spells )

 

[scorpion182]

thanks pkw

 

[xxdingo93xx]

@xxdingo93xx
thanks for the suggestion, i'll update this spellpack soon. but i can't get rid of the TriggerSleepActions, cause i need it to hold the trigger before the missile hit the target

You can. Actually you wil have to use vJass then ^^ Avoid those TSA's with TimerUtils or Hanky's MainScript.

 

[tuantai120]

where is request about my spell?
Agains: Gaia Force and Black Tornado

 

[Need_O2]

meh...

 

[scorpion182]

@tuantai120
be patient, if i've finished, i'll send it to you
@xxdingo93xx
ok i'll try it later
@Hanky
thanks, i'll learn more about vJass

 

[tuantai120]

thanks very much scorpion182
my yahoo: [email protected]