Running blank trigger

[kentzeus]

Hey, does it matter if I run a blank trigger in the sense of causing problems or reducing performance? This is the trigger I'm using and I'm thinking of removing the condition, and just let the blank trigger "No trigger" run instead. What do you think?

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Items_GeneralTrigger[(Integer A)] Not equal to No trigger <gen>
  • Then - Actions
    • Trigger - Run Items_GeneralTrigger[(Integer A)] (ignoring conditions)
  • Else - Actions

 

[Pyrogasm]

No.

 

[kentzeus]

Ok thanks

 

[Dr Super Good]

What happens is it tries to run a trigger with the value of null, which is what GUI refers to as no trigger and is the default value for uninitialized trigger array slots. If this is safe or does anything depends on how run trigger is internally implemented. It should have a native test, like what you wrote above, to only run a trigger if the argument is a valid trigger object.

If it does not have such a test, or a safety for null, then it may be prone to crashing or causing unpredictable behaviour.

 

[Pyrogasm]

If it does not have such a test, or a safety for null, then it may be prone to crashing or causing unpredictable behaviour.

Can you name any native that produces crashes or unpredictable behavior when passed a null handle as an argument? I am not aware of any.

 

[Dr Super Good]

Can you name any native that produces crashes or unpredictable behavior when passed a null handle as an argument?

Sadly I cannot. However for a very long time we all remember Player(16) crashing.

 

[kentzeus]

What happens is it tries to run a trigger with the value of null, which is what GUI refers to as no trigger and is the default value for uninitialized trigger array slots. If this is safe or does anything depends on how run trigger is internally implemented. It should have a native test, like what you wrote above, to only run a trigger if the argument is a valid trigger object.

If it does not have such a test, or a safety for null, then it may be prone to crashing or causing unpredictable behaviour.

It is a real trigger though. So it's not the default value of "no trigger" but a trigger named No Trigger, that is empty.

• No trigger
  • Events
  • Conditions
  • Actions

 

[Dr Super Good]

It is a real trigger though. So it's not the default value of "no trigger" but a trigger named No Trigger, that is empty.

That is probably less efficient that the Do Nothing action. Trigger execution overhead in JASS is quite large, especially compared with function calls.