Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
[tr]
IcemanBo: Too long as NeedsFix. Rejected.
Rubick the Grand Magus's Spell Steal v1.3 | Reviewed by Maker | 16th Jun 2013 | ||||||
NEEDS FIX | ||||||
|
20:52, 4th Oct 2012 Magtheridon96: In the Cast trigger, since you stored (Triggering unit) into a variable, there's no point in repeating it over and over again inside the loop. Also, be sure to store the target unit of the ability being cast into a variable so you don't end up repeating the call over and over again. By the way, instead of storing the unit-type that will have the Spell Steal ability into a variable, you can simply make your second trigger filter out events when the ability being cast is equal to "Spell Steal". By the way, you should deny a Spell Steal if the level of the stolen ability for the caster is greater than 0. Currently, If I had "Fireball" and I stole "Fireball", I'd end up having no "Fireball" after the spell steal duration expires. Another tip, at the end of the loop in the cast-trigger in which you create the missile (under the custom scripts directly), add this line in Custom script: exitwhen true Do the same for the last loop in the cast-trigger because after you reset the ability data, it's going to be pointless to continue looping since you're sure that only one instance may contain data for this unit at most. |