[JASS] Removing a unit... twice?

[Cokemonkey11]

If I remove a unit from the game, is it also removed from a group it's in?

    loop
        exitwhen FirstOfGroup(g)==null
        call RemoveUnit(FirstOfGroup(g))
        //call GroupRemoveUnit(g,FirstOfGroup(g)) //does this remove 2 units!??? does removing a unit remove it from it's group as well?
    endloop

 

[dimitri231]

Yes it does =)

 

[Cokemonkey11]

Thank you. [solved]

 

[Eleandor]

No it doesn't. GroupRemoveUnit removes the unit from the group, RemoveUnit removes the unit from the game. Your loop will bug because you never remove FirstOfGroup() from the group. So what happens is that since the unit is removed from the game, the handle is considered null and you exit the loop before looping through all units in the group.

 

[Deaod]

Thats one good reason to not use RemoveUnit(). It causes Groups to fuck up and slow down by about 50 times (refer to Griffens tests over at wc3c for proofs). Just kill the units and hide them. Let WC3 do the recycling internally. Oh and FirstOfGroup() loops are inefficient. Why not use the boolexpr for that?

 

[Eleandor]

Can't pass arguments to boolexpr. The inefficiency, if any, is not noticeable.

 

[Deaod]

Using a boolexpr takes (5/6) of the time it takes with a FirstOfGroup() loop (when only passing a struct (integer)). This is a rough estimate, in reality its slightly faster (_slightly_; 0.01-0.03 should be enough).

 

[Cokemonkey11]

Thanks. Sorry Deaod I need to spread reputation around before giving to you again, but I gave to Eleandor.