Remove All Units of Group From Group Efficiency.

[Assassins-Creed]

Is the below function N or O(1)?

• Unit Group - Remove all units of TempGroup from TempGroup

 

[Pyrogasm]

Presumably it's more efficient than FirstOfGroup or ForGroup -based removal loops.

 

[MyPad]

BlzGroupRemoveGroupFast might be O(1), going by the presumption that adding a group quickly just appends the entire target list (group) to the desired list of units (whichGroup)

The function above might be O(N), based on how it was implemented before.

 

[Assassins-Creed]

Presumably it's more efficient than FirstOfGroup or ForGroup -based removal loops.

Okay but that still has an N run-time I'm assuming.

BlzGroupRemoveGroupFast might be O(1), going by the presumption that adding a group quickly just appends the entire target list (group) to the desired list of units (whichGroup)

The function above might be O(N), based on how it was implemented before.

BlzGroupRemoveFast is 1.31 isn't it?

 

[MyPad]

BlzGroupRemoveFast is 1.31 isn't it?

Yes, it is (PTR).

 

[Dr Super Good]

If you want to clear a group then use the appropriate native to do so...

native GroupClear takes group whichGroup returns nothing

If you want to remove all units in group B from group A then this is the current implementation...

function GroupRemoveGroup takes group sourceGroup,group destGroup returns nothing
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false
    set bj_groupRemoveGroupDest = destGroup
    call ForGroup(sourceGroup, function GroupRemoveGroupEnum)
    if (wantDestroy) then
        call DestroyGroup(sourceGroup)
    endif
endfunction

function GroupRemoveGroupEnum takes nothing returns nothing
    call GroupRemoveUnit(bj_groupRemoveGroupDest, GetEnumUnit())
endfunction

On the 1.31 PTR there is this native implementation, which is likely considerably faster...

native BlzGroupRemoveGroupFast takes group whichGroup,group removeGroup returns integer