Rapid Firebolt v7.0

[Moderator]

12:42, 18th Jan 2014
BPower:

• The spell is leakless, MUI and performs well.
• The chosen effects fit to the content of the spell.
• Tooltips are fine.
• Use "spell" as Art - Animation Names instead of "stand".
• DamageType fire, cold, poison, etc equal DamageType magic the wc3 engine doesn't make a difference here.

The triggering looks good, I've added a few suggestions to optimize the code here

 

[Haley]

~Reserved

 

[Rheiko]

| Rheiko | 14/01/14

Vote for Approval

Rheiko's Review: Use ITE for that Harvester. If RF_DestroyTrees equal to True then create harvester, if not then don't. So it won't create an unnecessary Harvester. Set RF_Owner = (Owner of RF_Caster[RF_Index]) why don't you store this at Stage 2?

[TD][/TD]

 

[Haley]

• Set RF_Owner = (Owner of RF_Caster[RF_Index])

why don't you store this at Stage 2?

just to make it damage other player if the caster owner change during the firebolt move..

 

[Rheiko]

oh, i see..

 

[BPower]

Some suggestions:

- Use "spell" as Art - Animation Names instead of "stand".
- udg_RF_HSpeed[udg_RF_Index]*Cos(udg_RF_Angle[udg_RF_Index]
This is actually constant per missle. You could set udg_RF_HSCos to the whole term at the end of stage 2. Ofc you now need another variable for Sin calculation aswell.
- DamageType fire, cold, poison, etc equal DamageType magic the wc3 engine doesn't make a difference here.

- You filter out flying units
- tooltip and objects are fine, the effects really fit to the concept.

Nice spell overall

 

[zv27]

BPover is right.There is no difference between fire damage and magical. Fire = Magic etc.The only way to manipulate the magical damage is to make your own system, but believe me it is a very difficult job.
Btw. cool spell

 

[marvey323]

Your spell has been chosen to be added in my upcoming Hero RPG of epic proportions. This spell serves for my Fire Mage's 3rd ability and you have been credited. Thank you and if you want to come test my map and see your spell in action (with some modifications ) do PM me on these boards.

 

[Bloody Wolf]

its pretty much overkill when maxed but anyway it has a nice touch to it

 

[BPower]

You could use a player variable instead of detecting the owner in each loop.

IssueTargetOrderById returns a boolean which is only true if the order is executed properly. In other words if it is not a tree the condition will be false.
Instead of:

• Custom script: call IssueTargetOrderById(udg_RF_Harvester,udg_RF_HarvestOrderId,udg_RF_PickedDest)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Current order of RF_Harvester) Equal to RF_HarvestOrderId
  • Then - Actions
    • Destructible - Kill RF_PickedDest
  • Else - Actions

You can shorten it to:

• Custom script: if IssueTargetOrderById(udg_RF_Harvester,udg_RF_HarvestOrderId,udg_RF_PickedDest) then
• Destructible - Kill RF_PickedDest
• Custom script: endif

The following is very optional, it's just a small boost of the spell performance.

For udg_RF_HSpeed[udg_RF_Index]*Cos(udg_RF_Angle[udg_RF_Index]
--> RF_Speed is determined in stage 2 and will be constant for stage 1.
--> RF_Angle is determined in stage 2 and will be constant for stage 1.
--> Conclusion: The whole term will always have the same value each loop.
--> Solution: Calculate it in stage 2: udg_RF_Cos[udg_RF_Index] = udg_RF_HSpeed[udg_RF_Index]*Cos(udg_RF_Angle[udg_RF_Index]

• set udg_RF_X=GetUnitX(udg_RF_Firebolt[udg_RF_Index])+udg_RF_Cos[udg_RF_Index])

 

[Daffa]

http://www.hiveworkshop.com/forums/spells-569/gui-jass-isdesttree-v1-2-a-240149/ or http://www.hiveworkshop.com/forums/spells-569/isdestree-v1-2-a-224623/ can be used for Tree Filtering, this allows you to skip tree filtering and let the system handle it (if you prefer that way)

anyway, great spell!