[Trigger] Random Heroes GUI Help

[Admiral Jack]

Guys is there something wrong with this because i think it wont work....

• Command All Random
  • Events
    • Player - Player 2 (Blue) types a chat message containing -ar as An exact match
    • Player - Player 2 (Blue) types a chat message containing -allrandom as An exact match
  • Conditions
    • GameMode Equal to MODE_Normal
  • Actions
    • Set GameMode = MODE_AllRandom_AllPick
    • Quest - Display to Players the Secret message: All random mode ena...
    • Player Group - Pick every player in Players and do (Actions)
      • Loop - Actions
        • Set Random_Hero = (Random integer number between 1 and RandomTotal_All)
        • Unit - Create 1 Heroes_All[RandomData_All[Random_Hero]] for (Picked player) at ((Picked player) start location) facing Default building facing degrees
        • Quest - Display to (All enemies of (Picked player)) the Hint message: (A player has randomed + (Name of (Last created unit)))
        • Set Player_Already_Picked[(Player number of (Picked player))] = (Player_Already_Picked[(Player number of (Picked player))] + 1)
        • Player Group - Pick every player in Players and do (Actions)
          • Loop - Actions
            • Player - Make (Unit-type of (Last created unit)) Unavailable for training/construction by (Picked player)
        • Set RandomData_All[Random_Hero] = RandomData_All[RandomTotal_All]
        • Set RandomTotal_All = (RandomTotal_All - 1)
    • Quest - Display to Players the Secret message: All random mode ena...

Help guys.....

 

[PurplePoot]

What about it isn't working? Are the other triggers that initialize the arrays and other variables you use working correctly?

 

[Admiral Jack]

I think this is the only trigger that i made because i just modified it....

 

[Marsal]

A simple allrandom mode:

• Events
  • Map Initialization
• Conditions
• Actions
  • Set Hero[1]=Bloodmage
  • Set Hero[2]=Knight
  • Set Hero....

• Events
  • Player - Player 2 (Blue) types a chat message containing -ar as An exact match
  • Player - Player 2 (Blue) types a chat message containing -allrandom as An exact match
• Conditions
• Actions
  • Trigger - Turn off (other mode triggers)
  • Set R = Math random number between 1 and (number of heroes)
  • Player Group - Pick Every player in game and do multiple actions
    • Unit - Create 1 Hero[R]......

 

[PurplePoot]

That can pick the same hero multiple times, which is what the OP's code is attempting to avoid. However, based on his (vague) reply I can only assume he isn't populating the arrays.

 

[Adiktuz]

You could always do this to avoid that

• After the hero is picked
• Set Hero[Number of hero picked or whatever] = Hero[Total]
• set Total = Total - 1

@Marsal - your trigger will create same hero for all players as you set the index outside the loop...

 

[Marsal]

Whooops I forgot that ~.~
The you can just leave the R variable and add the math func to the Hero variable's array.

 

[PurplePoot]

You could always do this to avoid that

• After the hero is picked
• Set Hero[Number of hero picked or whatever] = Hero[Total]
• set Total = Total - 1

@Marsal - your trigger will create same hero for all players as you set the index outside the loop...

Only if you won't ever be using the array again.

 

[Maker]

I would use a unit pool for this. Add all unit types into the pool with the same weight, then create random unit type from the pool and remove the type from the pool.

You'd have to use JASS, since there's no unit pools in GUI.

 

[Adiktuz]

well, you probably won't need it again since they are just for hero selection...

 

[PurplePoot]

well, you probably won't need it again since they are just for hero selection...

It's better not to make assumptions without basis.

 

[Adiktuz]

if he don't need them again he can use it or:

either he make another array for keeping them...

or set a boolean when a hero is picked and then check everytime you randomize a hero if someone already picked that hero, if so, randomize again... which I think is much less efficient...

 

[Admiral Jack]

Thanks everyone.....