Purging Ray - Spell

[MyPad]

Spell Review:

Notes:

• The spell is not multi-instanceable. This means that multiple units cannot cast the spell at the same time, as it might bug out. (Multi-instanceability is required for a spell submitted here.)
  
  
• In trigger PR3, a wait action has been spotted. This can cause clients to desync (as invoking a wait action is asynchronous). The wait action must be omitted from the trigger.
  
  
• In trigger PR2, a direct trigger execute to PR3 would suffice, instead of having to rely on a real event. (The real event in this case creates unnecessary overhead)
  
  • In addition, it appears that the spell leaks a group handle in the if-then statement.
    
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (PurgingRay_Target is in (Units within 700.00 of PurgingRay_TempLoc01)) Equal to True
    This can be optimized further, not requiring the creation of a group.
    
    
  • In most cases, the location handles PurgingRay__TempLoc00 and PurgingRay__TempLoc01 are not cleaned up. This can be optimized by adding RemoveLocation at the appropriate section/s.
    
    
• Configurability of the spell would be greatly appreciated. Such configurable variables are the following:
  
  
  • Damage type
  • Attack type
  • Intelligence point percentage
  • Damage delay
  • Link distance

Suggestions:

• Try adding an effect to the target when the link breaks. (This can make the spell appear a bit more pleasing to the eye).

Status:

• Awaiting Update

 

[McPepperoni]

From tests and trigger previewing, this spell is not MUI and not net-safe, due to the presence of a wait action. This would require an update before this can be approved.

Okay thank you sir, I'll better fix that. But, is the MUI really needed for a trigger? I can only do GUI triggers so. What should I do?

 

[MyPad]

Yes, for a spell to be approved, it must be MUI. If you need to ask more, you can check the link above or here: Spell Submission Rules

As for the review itself, it has been updated.

Okay thank you sir, I'll better fix that. But, is the MUI really needed for a trigger? I can only do GUI triggers so. What should I do?

Do check out the following links:

Things That Leak
Visualize: Dynamic Indexing

 

[McPepperoni]

Hey friend, I followed the links as I understand but, I don't know if it is already a MUI trigger.