[Trigger] Problems with ar mode

[Keysi]

• Manual Hero Pick
  • Events
    • Unit - A unit Sells a unit
  • Conditions
    • ((Sold unit) is A Hero) Equal to True
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
    • Player - Make (Unit-type of (Sold unit)) Unavailable for training/construction by (Picked player)
    • Game - Display to (All players) the text: (A player has chosen + (Name of (Sold unit)))
    • Selection - Select (Sold unit) for (Owner of (Sold unit))

and

• All Random Command
  • Events
    • Player - Player 1 (Red) types a chat message containing -ar as An exact match
  • Conditions
  • Actions
    • Trigger - Turn off Random Command <gen>
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Player((Integer A))) slot status) Equal to Is playing
          • Then - Actions
            • Set Random_Hero = (Random integer number between 1 and Random_Count)
            • Unit - Create 1 Hero_Array[Random_Data[Random_Hero]] for (Player((Integer A))) at ((Player((Integer A))) start location) facing Default building facing degrees
            • Selection - Select (Last created unit) for (Owner of (Last created unit))
            • Game - Display to (All players) the text: (A player has randomed + (Name of (Last created unit)))
            • Player - Add -425 to (Player((Integer A))) Current gold
            • Set Random_Data[Random_Hero] = Random_Count
            • Set Random_Count = (Random_Count - 1)
          • Else - Actions
            • Do nothing

• Map Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Set Player 1 (Red) Current gold to 750
        • Player - Set Player 2 (Blue) Current gold to 750
        • Camera - Pan camera as necessary for Player 1 (Red) to (Center of Region 002 <gen>) over 0.00 seconds
        • Camera - Pan camera as necessary for Player 2 (Blue) to (Center of Region 002 <gen>) over 0.00 seconds
    • Set Total_Heroes = 8
    • Set Random_Count = 8
    • Set Hero_Array[1] = Blood Mage
    • Set Hero_Array[2] = Mountain King
    • Set Hero_Array[3] = Nazgul
    • Set Hero_Array[4] = Paladin
    • Set Hero_Array[5] = Ice Lord
    • Set Hero_Array[6] = Far Seer
    • Set Hero_Array[7] = Dreadlord
    • Set Hero_Array[8] = Priestess of the Moon
    • For each (Integer A) from 1 to 8, do (Actions)
      • Loop - Actions
        • Set Random_Data[(Integer A)] = (Integer A)

Maybe I didn't need to post 3 triggers but I want to make sure that someone will realize how to fix this problem.

Ok guys here is the problem:When I type -ar I always get same hero.My opponent also get same hero(not same as me).I always get Far Seer and opponent gets Blood Mage.1v1.Also,when we get that heroes they aren't removed from tavern,and we can pick any hero again.My questions are: Why we are getting same heroes always,why they aren't removed from tavern,how I can set 1 hero per player(so player can't have 2 heroes).And how to fix this?Thanks in advance.

:/

 

[InfinateAnswers]

For one, theres nothing under your player group in the first trigger, you make a group and then put nothing under loop actions, so that trigger is pretty much useless. Should be like this

• Manual Hero Pick
  • Events
    • Unit - A unit Sells a unit
  • Conditions
    • ((Sold unit) is A Hero) Equal to True
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Make (Unit-type of (Sold unit)) Unavailable for training/construction by (Picked player)
        • Game - Display to (All players) the text: (A player has chosen + (Name of (Sold unit)))
        • Selection - Select (Sold unit) for (Owner of (Sold unit))

The reason when u random, and it doesnt remove from tavern is because instead of buying from tavern, your creating a whole new unit, so the tavern is never used. So when you say "Create 1 hero...." your not starting up your first trigger, because its just creating not buying. Also to limit 1 per player in gameplay constants it says "Limit 1 per players tech type" something like that, it might be in gameplay interface, and in the heroes tech tree, on the second techtree item it usualy says the second tech teir of that race, make sure theres something there or people can buy 2 heroes.

 

[Dr Super Good]

If you are testing in singleplayer, you will need to turn off fixed seed under the editor preferences to simulate battlenet like randomeness.

 

[Keysi]

For one, theres nothing under your player group in the first trigger, you make a group and then put nothing under loop actions, so that trigger is pretty much useless. Should be like this


The reason when u random, and it doesnt remove from tavern is because instead of buying from tavern, your creating a whole new unit, so the tavern is never used. So when you say "Create 1 hero...." your not starting up your first trigger, because its just creating not buying. Also to limit 1 per player in gameplay constants it says "Limit 1 per players tech type" something like that, it might be in gameplay interface, and in the heroes tech tree, on the second techtree item it usualy says the second tech teir of that race, make sure theres something there or people can buy 2 heroes.

I limited 1 hero per player but I still have problem with tavern.Heroes aren't disappearing from tavern.I understood what you said but I don't know how to write that in trigger(I am newbie).Also,I still have problem with getting same hero every time,can't understand why is that happening.

 

[InfinateAnswers]

easy, just put this right after you create the unit

• Player - Make (Last Created Unit) Unavailable for training/construction by (Player(Integer A))

 

[Dr Super Good]

Or you can remove them from the stock of the tavern via the corosponding native.

 

[InfinateAnswers]

whatever he wants to do idc

 

[Keysi]

• All Random Command
  • Events
    • Player - Player 1 (Red) types a chat message containing -ar as An exact match
  • Conditions
  • Actions
    • Trigger - Turn off Random Command <gen>
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Player((Integer A))) slot status) Equal to Is playing
          • Then - Actions
            • Set Random_Hero = (Random integer number between 1 and Random_Count)
            • Unit - Create 1 Hero_Array[Random_Data[Random_Hero]] for (Player((Integer A))) at ((Player((Integer A))) start location) facing Default building facing degrees
            • Player - Make (Unit-type of (Last created unit)) Unavailable for training/construction by (Player((Integer A)))
            • Selection - Select (Last created unit) for (Owner of (Last created unit))
            • Game - Display to (All players) the text: (A player has randomed + (Name of (Last created unit)))
            • Player - Add -150 to (Player((Integer A))) Current gold
            • Set Random_Data[Random_Hero] = Random_Count
            • Set Random_Count = (Random_Count - 1)
          • Else - Actions
            • Do nothing

After I imported that,it works but it only removes hero that I get(Player 1). :/
And I still have problem with getting same hero every time :/

Looks like I am doing something wrong :/ +rep for all your help anyway

 

[Keysi]

Bump!

Anyone know how to fix this? :/

 

[SanKakU]

it's simple. i thought i had answered already. sorry.
you need to use the math option and get a random integer. you're making the "random" integer be the integer of the player id. that's not what you want to do. that's for a mode where everyone has a preset hero. that's not all random. that's why your mode isn't working. you implemented the wrong integers.

 

[Keysi]

it's simple. i thought i had answered already. sorry.
you need to use the math option and get a random integer. you're making the "random" integer be the integer of the player id. that's not what you want to do. that's for a mode where everyone has a preset hero. that's not all random. that's why your mode isn't working. you implemented the wrong integers.

You are hell right. :/ I will just forget about those modes for now because it is just hard for me.Thanks anyway bro :/

 

[SanKakU]

You are hell right. :/ I will just forget about those modes for now because it is just hard for me.Thanks anyway bro :/

• //
• Unit - Create (Random integer number between 1 and 10) Footman for Player 1 (Red) at (Center of (Playable map area)) facing Default building facing (270.0) degrees
• //
• //

it's right there in the gui. but you might be right to ignore ar and other modes until you have more of the map done.
i would post the full trigger but i can't be bothered to make a gui unit array and all that

 

[InfinateAnswers]

haha thats not how you do it.... your basicly saying creat 10 footmen, or create 9 footmen, etc. You have to set up an array that calls back to stored units

 

[SanKakU]

haha thats not how you do it.... your basicly saying creat 10 footmen, or create 9 footmen, etc. You have to set up an array that calls back to stored units

that's what i said. my point is he needs a random integer.

 

[mckill2009]

try...

Unit - Create 1 Hero_Array[random number between 1 and 8]

 

[Keysi]

try...

Unit - Create 1 Hero_Array[random number between 1 and 8]

Holy....That worked bro Now we aren't getting same hero,yay +rep

So,one more problem is left: Only my hero gets removed from tavern when I type ar,hero that other players get stays in tavern :/ If nobody can help it is ok because I should really start adding modes when I make some better map,but this is my test map to learn some things before big projects..

 

[SanKakU]

won't you read over your own code? or did someone else type this up?

whatever. do change this one:

• //
• Player - Make (Unit-type of (Last created unit)) Unavailable for training/construction by (Player((Integer A)))
• //change to this:
• Player - Make (Unit-type of (Last created unit)) Unavailable for training/construction by (Player Group((All players)))

but, actually...we should redo the entire thing.
what we really need to do for -ar is make a unitpool
because if we want to run -ar for all players get random...Player - Make (Unit-type of (Last created unit)) Unavailable for training/construction by (Player Group((All players))) line is meaningless.
hero is selected through trigger, not through training/construction from tavern. thus it doesn't mean anything.

instead we need the function remove unit from unitpool. there might be another odd way to do this very thing but i don't know about that. this way is most simple. but i think you need to use custom text/jass to do unitpools

there is already a site tutorial on itempools unitpools are exactly the same thing. everything is the same except it handles units instead of items.
http://www.hiveworkshop.com/forums/jass-ai-scripts-tutorials-280/itempools-guide-35180/

 

[InfinateAnswers]

Actually now that i think about it, the only way AR wont have the same heroes, is if u made a unit group, picked a random unit from it, then removed that unit.

 

[SanKakU]

Actually now that i think about it, the only way AR wont have the same heroes, is if u made a unit group, picked a random unit from it, then removed that unit.

oh yeah. there might be another way, also. but this way sounds alright. at any rate doing it in jass would mean you only create as many units as you need to.