Pounce v1.0.0.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

11:22, 27th Oct 2012
Magtheridon96:

- The spell is not totally MUI as you're using a static variable for the distance. (Same distance variable is shared by all spell instances)
- The distance should be configurable.
- You're leaking Pounce_TargetLoc in the Loop trigger.
-

Code

• Set Pounce_Group = (Units within Pounce_AoE_Pick of Pounce_CasterLoc)
• Custom script: set udg_Pounce_TempUnit = FirstOfGroup(udg_Pounce_Group)
• Unit Group - Pick every unit in Pounce_Group and do (Actions)
  • Set Pounce_Target[Pounce_TempInt] = (Picked unit)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • And - All (Conditions) are true
        • (Owner of Pounce_Target[Pounce_TempInt]) Not equal to Pounce_Owner[Pounce_TempInt]
        • (Pounce_Target[Pounce_TempInt] is alive) Equal to true
    • Then - Actions
      • Set Pounce_TargetLoc = (Position of Pounce_Target[Pounce_TempInt])
      • Unit - Cause Pounce_Caster[Pounce_TempInt] to damage Pounce_Target[Pounce_TempInt] dealing Pounce_Damage[Pounce_Level[Pounce_TempInt]] damage of attack type Spells and damage type Normal
      • -------- ---------------------------------- --------
      • -------- When the caster encounters an enemy --------
      • -------- the loop will stop. --------
      • -------- ---------------------------------- --------
      • Set Pounce_Distance = 0.00
    • Else - Actions

This snippet of code makes no sense at all.
Are you trying to do the actions for one unit, or for all?
If you want to do them for all units, remove the custom script in which you set a unit to "FirstOfGroup(...)".
If you want to do the actions for a random unit from the group, remove the "Pick every unit in ..." line, and just do the actions of the group enumeration while using Pounce_TempUnit as your "random unit in the group".

 

[doomhammer99]

EDIT: [rainbow]UPDATED[/rainbow]
[broke=You have to Log Out!]Click Here[/broke]
[broke=No good kid]Don't Click[/broke]

 

[Tank-Commander]

• Set Pounce_Group = (Units within Pounce_AoE_Pick of Pounce_CasterLoc matching (((Owner of (Matching unit)) Not equal to Pounce_Owner[Pounce_TempInt]) and (((Matching unit) is alive) Equal to True)))

You could put that inside a bigger unit group and use an IF block to make it more readable and more configurable

• Set Pounce_Speed[Pounce_TempInt] = 40.00
• Set Pounce_Height = 500.00
• Set Pounce_Distance[Pounce_TempInt] = 10.00
• Set Pounce_FlyingRate[Pounce_TempInt] = 400.00

All of those could go into the configuration trigger with the others

• Unit - Move Pounce_Caster[Pounce_TempInt] instantly to Pounce_Point, facing Pounce_Angle[Pounce_TempInt] degrees

Really ought to be done with co-ordinates, considering the simplicity of the spell

All I have for now

 

[Almia]

1.Move the speed, height ,distance,Flyrate in the configuration trigger.
2.Use this method or formula for the arc:
(((4xMaxHeightof the Arc)/MaxDistance)x((MaxDistance-DistanceTravelled)x(DistanceTravelled/MaxDistance)))
If you use this,it will automatically change height and returns to 0.
3.Instead of using locations for moving,use coordinates just like what Tank-Commander and I and other spell coders do.
Here is a sample:
call SetUnitX(udg_Unit,GetUnitX(udg_Unit) + udg_Speed * Cos(udg_Angle * bj_DEGTORAD))
call SetUnitY(udg_Unit,GetUnitX(udg_Unit) + udg_Speed * Sin(udg_Angle * bj_DEGTORAD))
4.[trigger=]
Custom script: set bj_wantDestroyGroup=true
[/trigger]then picking the group?are you crazy?why not use call destroygroup itself
5.Check first the group 1 if it is not empty,then set the variable for random group then pick it,in this way,it wont bug.
Ex.
Set Group 1 = Unit Group Here.
If Number of unit in Group 1 greater than 0 then
set Group 2 = Random group
Pick units in Group 2
6.You leak the first group.
7.It is okay not to put the lightnings,we are talking about the code.

This spell has to make a lot of changes,then it will be approved.

 

[Magtheridon96]

There is a much better way of picking a random unit from a group.

• Set Group = (Something)
• Custom script: set udg_TempUnit = FirstOfGroup(udg_Group)
• // Use TempUnit as your random unit from the group

 

[Almia]

Yeah right

 

[gorillabull]

[trigger=5]
Custom script: set udg_TempUnit = FirstOfGroup(udg_Group)
[/trigger]

doesent this get the first unit in the group (the same unit) every time