[Solved] Possible leak in this trigger?

[Yours Truly]

Hey there. I've been making a trigger that creates another unit upon construction of a specific tower. The unit will never die (has reincarnation 0 cd) unless the tower itself is destroyed. Here's the trigger:

First Trigger

• Tower Revenant
  • Events
    • Unit - A unit Finishes construction
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to (==) Revenant Tower
  • Actions
    • Set Tower_Building = (Triggering unit)
    • Set Tower_TempPoint = (Position of Tower_Building)
    • Set Tower_Value = (Custom value of Tower_Building)
    • Unit - Create 1 Castle Revenant for (Owner of Tower_Building) at Tower_TempPoint facing Default building facing (270.0) degrees
    • Set Tower_Revenant[Tower_Value] = (Last created unit)
    • Custom script: call RemoveLocation(udg_Tower_TempPoint)

Second Trigger

• Tower Revenant Death
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Dying unit)) Equal to (==) Revenant Tower
  • Actions
    • Set Tower_Building = (Triggering unit)
    • Set Tower_TempPoint = (Position of Tower_Building)
    • Set Tower_Value = (Custom value of Tower_Building)
    • Unit - Remove Revenant Revival from Tower_Revenant[Tower_Value]
    • Unit - Add a 0.01 second Generic expiration timer to Tower_Revenant[Tower_Value]
    • Custom script: call RemoveLocation(udg_Tower_TempPoint)

Any help will be largely credited since I've been working on this for quite a while now and it still baffles me. I'm quite sure something in this is leaking the trigger.

 

[HappyTauren]

No leaks there. If it works properly, you have nothing to worry about.

 

[Yours Truly]

Hmm... I forgot to mention how this is not working properly. If I create a revenant tower, then create another one, the first tower will mark the second tower's revenant as its own, leaving the first revenant unkillable in any way. That's how I think something leaks, though I might be doing something wrong here.

 

[HappyTauren]

That's because all your units' custom values are zero.

 

[Yours Truly]

Then how do I fix this? I tried setting the tower's custom values to random numbers once they are constructed, still not working.

 

[HappyTauren]

You need to also set the created unit's custom value to the tower's custom value.

 

[Yours Truly]

You need to also set the created unit's custom value to the tower's custom value.

Tested it, doesn't work unfortunately.

 

[HappyTauren]

Post your trigger.

 

[Yours Truly]

• Tower Revenant
  • Events
    • Unit - A unit Finishes construction
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to (==) Revenant Tower
  • Actions
    • Set Tower_Building = (Triggering unit)
    • Set Tower_TempPoint = (Position of Tower_Building)
    • Unit - Set the custom value of Tower_Building to (Random integer number between 1 and 1000000000)
    • Set Tower_Value = (Custom value of Tower_Building)
    • Unit - Create 1 Castle Revenant for (Owner of Tower_Building) at Tower_TempPoint facing Default building facing (270.0) degrees
    • Set Tower_Revenant[Tower_Value] = (Last created unit)
    • Unit - Set the custom value of Tower_Revenant[Tower_Value] to Tower_Value
    • Custom script: call RemoveLocation(udg_Tower_TempPoint)

 

[HappyTauren]

That should work, what does your next trigger do?

 

[Yours Truly]

The second trigger remains the same since I don't see anything that needs changing.

 

[HappyTauren]

Is anything else in the map using custom value?

 

[Yours Truly]

Not really atm.

 

[HappyTauren]

I have no idea then, and I don't use GUI so I don't know what could be going wrong.

Try printing Custom Values out when you create/destroy the building. I just realized it's not even necessary to set the Revenant's custom value, only the tower needs it, I was kind of confused at what exactly needs to happen.

Anyways, try to debug it yourself, print out values, see what's going wrong.

 

[Yours Truly]

Oh,well.... thanks for trying tho. I'll try to fix it myself then.

 

[HappyTauren]

You can always post the map, if you can explain exactly which trigger and which units are problematic.

 

[Yours Truly]

Well, I cant give you the full map cos its kinda bs right now, so have a test map that has exactly the same triggers. Try building 3 scout towers and destroy the first one, you'll see what's the problem. The third revenant will die instead of the first.

 

[HappyTauren]

There you go. Arrays can only use values 0-8191
Also I have no idea how you thought any of what you sent me should work.

 

[Yours Truly]

There you go. Arrays can only use values 0-8191
Also I have no idea how you thought any of what you sent me should work.

Thanks! You've been a great help to me. I'm a bit rusty after I stopped editing maps a few months ago and I have no idea that arrays has a cap.