Please help checking my GUI

[04gusigo]

Could someone please help me to see if the code below contains too many leaks and if you can please tell me how can they be corrected. Thanks in advance!

Warning, this code is an eye killer! lol

• Electric Explosions lvl1
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Electric Explosions
        • (Level of (Ability being cast) for (Casting unit)) Equal to 1
  • Actions
    • Set Chens_ability_tmppoint = (Target point of ability being cast)
    • Set Chens_ability_point[1] = (Chens_ability_tmppoint offset by (150.00, 0.00))
    • Set Chens_ability_point[2] = (Chens_ability_tmppoint offset by (100.00, 100.00))
    • Set Chens_ability_point[3] = (Chens_ability_tmppoint offset by (0.00, 150.00))
    • Set Chens_ability_point[4] = (Chens_ability_tmppoint offset by (-100.00, 100.00))
    • Set Chens_ability_point[5] = (Chens_ability_tmppoint offset by (-150.00, 0.00))
    • Set Chens_ability_point[6] = (Chens_ability_tmppoint offset by (-100.00, -100.00))
    • Set Chens_ability_point[7] = (Chens_ability_tmppoint offset by (0.00, -150.00))
    • Set Chens_ability_point[8] = (Chens_ability_tmppoint offset by (100.00, -100.00))
    • For each (Integer A) from 1 to 8, do (Actions)
      • Loop - Actions
        • Special Effect - Create a special effect at Chens_ability_point[(Integer A)] using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl
        • Set Chens_ability[(Integer A)] = (Last created special effect)
        • Set Chens_ability_unit_group[(Integer A)] = (Units within 200.00 of Chens_ability_point[(Integer A)] matching (((Matching unit) belongs to an ally of (Owner of (Casting unit))) Equal to False))
        • Unit Group - Pick every unit in Chens_ability_unit_group[(Integer A)] and do (Actions)
          • Loop - Actions
            • Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 50.00)
        • Wait 0.26 seconds
        • Special Effect - Destroy Chens_ability[(Integer A)]
        • Custom script: call DestroyEffect(udg_Chens_ability[GetForLoopIndexA()])
        • Custom script: call DestroyGroup(udg_Chens_ability_unit_group[GetForLoopIndexA()])
        • Custom script: call RemoveLocation (udg_Chens_ability_point[GetForLoopIndexA()])
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Integer A) Equal to 8
          • Then - Actions
            • Custom script: call RemoveLocation (udg_Chens_ability_tmppoint)
          • Else - Actions
            • Do nothing

Ok, I have used the code that Squiggy has suggested, but I have implemented some changes to it ^^ thanks guys.. I hope there aren't any more mistakes in the code..

 

[leet.firefox]

Looks clean to me. But then again, what do I know, XD

 

[xD.Schurke]

so first of all wait actions can't be lower then 0.26, second, if u do it like this, use a loop to reduce the lines 3. wait sucks hard, because of the effect, that it destroys the chance to make a spell mui/mpi (only in gui)

 

[Igor_Z]

trigger too long... Can't check all out... Thanks for the warning... Anyways use A unit starts the effects of an ability instead of begins casting an ability

 

[04gusigo]

Thanks guys, I have changed the code to what your suggestions. Schurke, I didn't really understand what you have said there, but I changed the waiting time to 0.26 lol

 

[Squiggy]

I made it shorter lawlz

• Something
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Random
  • Actions
    • Set tmppoint = Target point of ability being cast
    • Set Chens_ability_point[1] = (tmppoint offset by (150.00, 0.00))
    • Set Chens_ability_point[2] = (tmppoint offset by (100.00, 100.00))
    • Set Chens_ability_point[3] = (tmppoint offset by (0.00, 150.00))
    • Set Chens_ability_point[4] = (tmppoint offset by (-100.00, 100.00))
    • Set Chens_ability_point[5] = (tmppoint offset by (-150.00, 0.00))
    • Set Chens_ability_point[6] = (tmppoint offset by (-100.00, -100.00))
    • Set Chens_ability_point[7] = (tmppoint offset by (0.00, -150.00))
    • Set Chens_ability_point[8] = (tmppoint offset by (100.00, -100.00))
    • For each Integer A from 1 to 8 do:
      • Special Effect - Create a special effect at Chens_ability_point[Integer A] using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl
      • Set Chens_ability[Integer A] = (Last created special effect)
      • Custom script: set bj_wantDestroyGroup = true
      • Unit Group - Pick every unit in (Units within 200.00 of Chens_ability_point[Integer A] matching (((Matching unit) belongs to an ally of (Owner of (Triggering Unit))) Equal to False)) and do (Actions)
        • Loop - Actions
          • If (((Picked unit) belongs to an ally of (Owner of (Triggering unit))) Equal to False) then do (Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 20.00)) else do (Do nothing)
      • Wait 0.26 seconds
      • Special Effect - Destroy Chens_ability[Integer A]
      • Custom script: call DestroyEffect(udg_Chens_ability[GetForLoopIndexA()])
    • Custom script: call RemoveLocation (udg_Chens_ability_point[1])
    • Custom script: call RemoveLocation (udg_Chens_ability_point[2])
    • Custom script: call RemoveLocation (udg_Chens_ability_point[3])
    • Custom script: call RemoveLocation (udg_Chens_ability_point[4])
    • Custom script: call RemoveLocation (udg_Chens_ability_point[5])
    • Custom script: call RemoveLocation (udg_Chens_ability_point[6])
    • Custom script: call RemoveLocation (udg_Chens_ability_point[7])
    • Custom script: call RemoveLocation (udg_Chens_ability_point[8])
    • Custom script: cal lRemoveLoaction (udg_tmppoint)

 

[04gusigo]

Ohh! Thanks man! It really makes life for your eyes easier lol, but you have forgotten to remove the tmppoint and it is also more efficient to remove the unit group through Custom Script: call DestroyGroup(udg_UnitGroup)