Player Group Leak

[darwin]

Why does Leak Check tell me this trigger leaks:

• Untitled Trigger 001
  • Events
  • Conditions
  • Actions
    • Set tempPlayerGroup = (Player group((Owner of tempLaser)))
    • Custom script: call DestroyForce(udg_tempPlayerGroup)

 

[RatchetNClank]

• Untitled Trigger 001
  • Events
  • Conditions
  • Actions
    • Set tempPlayerGroup = (Player group((Owner of tempLaser)))
    • Custom script: call DestroyForce( udg_tempPlayerGroup )

That works better!

 

[Apheraz Lucent]

Just add spaces between the brackets ( and ), as Ratched did.

 

[darwin]

Oh interesting, thank you both (rep incoming!)

One more question, should I do that for all the JASS commands I use to kill leaks? Will what I have actually leak or is it a bug with Leak Check?

 

[darwin]

That didn't stop it I'm afraid...

• fd
  • Events
  • Conditions
  • Actions
    • Set tempPlayerGroup = (Player group((Owner of tempLaser)))
    • Custom script: call DestroyForce( udg_tempPlayerGroup )

Leak Check still says:

(Line: 5) (Word: 3) Player Group Leak
Set tempPlayerGroup = (Player group((Owner of tempLaser)))
Set tempPlayerGroup = ^Leak
(Suggested Fix) No suggested fixes.

The problem appears to be with setting the player group variable as the following doesn't have an error:

• fd
  • Events
  • Conditions
  • Actions
    • Set tempPlayerGroup = Player Group - Player 1 (Red)
    • Custom script: call DestroyForce( udg_tempPlayerGroup )

 

[Apheraz Lucent]

Here you go: https://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/basic-memory-leaks-5889/

 

[darwin]

Here you go: https://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/basic-memory-leaks-5889/

I'm afraid that doesn't contain the answer to my question

 

[Apheraz Lucent]

It contains answer to your question. Just take a look at it and try to do the things Ralle explained. Maybe your ,,tempLaser" leaks? I don't see any removal of it.

 

[darwin]

It contains answer to your question. Just take a look at it and try to do the things Ralle explained. Maybe your ,,tempLaser" leaks? I don't see any removal of it.

tempLaser is a unit; I'm pretty sure unit variables don't leak. And the tutorial you posted does not explain why removing a player group doesn't fix the leak.

 

[tjordell]

Try this below:

• Custom script: call DestroyForce (udg_tempPlayerGroup)

Have a space between the DestroyForca SPACE (udg_...

 

[darwin]

Try this below:

• Custom script: call DestroyForce (udg_tempPlayerGroup)

Have a space between the DestroyForca SPACE (udg_...

I'm afraid that's not it... still has an error. Here's what I tested:

• Untitled Trigger 001
  • Events
  • Conditions
  • Actions
    • Set tempPlayerGroup = (Player group((Owner of (Triggering unit))))
    • Custom script: call DestroyForce ( udg_tempPlayerGroup )

Like I said before, teh problem seems to be the "owner of trigginer unit" part because if I replace that with Player 1 it's fine.

 

[tjordell]

Well, there must also be an triggering unit. Otherwise, the variable will result in a NULL and then it's nothing to destroy.

 

[darwin]

Well, there must also be an triggering unit. Otherwise, the variable will result in a NULL and then it's nothing to destroy.

Afraid that isn't it either... this is the strangest thing. Here's the trigger I tested:

• test
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set tempPlayerGroup = (Player group((Owner of (Triggering unit))))
    • Custom script: call DestroyForce ( udg_tempPlayerGroup )

Here's what leak Check said:

(Line: 6) (Word: 3) Player Group Leak
Set tempPlayerGroup = (Player group((Owner of (Triggering unit))))
Set tempPlayerGroup = ^Leak
(Suggested Fix) No suggested fixes.

 

[tjordell]

Well then you meaby should use the player group and do implement a custom script like this "Set bj_wantDestroyForce = true"

 

[Apheraz Lucent]

temLaster leaks, too. Set it to no value after you finish.