[JASS] Passive hero transformation doesn't recognize animation name

[Barade]

When I use passive hero transformation to transform my hero it ignores the animation name "Upgrade" of the unit it is transformed into.
I've also tried:

call AddUnitAnimationProperties(this.character().unit(), "Upgrade", true)

after the transformation but it didn't work either.
The unit is displayed properly with the "Upgrade" animation name in the editor.

Any ideas?

 

[Ezekiel12]

A quick

    call UnitAddAbility( udg_unit, 'A000')
    call UnitRemoveAbility( udg_unit, 'A000')
    call AddUnitAnimationProperties(udg_unit,"Upgrade",true)

with A000 being bear form and udg_unit being a mountain giant works nice for me.

 

[Barade]

Do you know why the animation name is not recognized although specified in the object editor for the unit?

 

[Ezekiel12]

You're using the "Art - Required Animation Names", right?

Note that with a passive transformation the unit will not automatically use the new animation name. A move command, use of an ability, or something comparable is required to activate it.

The Object Editor field works, so my guess is that your model is faulty.

 

[Barade]

Hm maybe my code is buggy.
So the animation name should work if I move the unit in the game or cast some ability?

I am using this model: http://www.hiveworkshop.com/forums/models-530/villager-255-animations-192204/

with upgrade it should ride a sheep and that is displayed properly in the editor as well as in the game.

For example when I place the alternative unit from the beginning it rides a sheep.

 

[Ezekiel12]

Testmap attached.

 

[Barade]

Ok I've tried your map and I've added the call with the Stand animation and then the animation name worked but as soon as I moved the unit it disappeared.

Note that I add many other abilities to the unit directly after the transformation:

/*
					 * These two lines of code do the passive transformation to a range fighting unit.
					 */
					call UnitAddAbility(this.character().unit(), this.morphAbilityId())
					call UnitRemoveAbility(this.character().unit(), this.morphAbilityId())
					
					// This line suffices as a "refresh" to show the new animation name
					call SetUnitAnimation(this.character().unit(), "stand")
					// TODO after one order the animation name is disabled
					
					set this.m_isMorphed = true
					
					// add unmorph spell
					if (this.disableGrimoire() or this.disableInventory()) then
						call UnitAddAbility(this.character().unit(), this.abilityId())
					endif
					
					/**
					 * Grimoire spells need to be readded.
					 */
					if (not this.disableGrimoire()) then
						call this.character().updateGrimoireAfterPassiveTransformation()
					endif
					
					/**
					 * Equipment needs to be shown.
					 */
					if (not this.disableInventory()) then
						call this.character().updateInventoryAfterPassiveTransformation()
					endif
			
			
					// morph spells are expected to morph immediately
					call this.onMorph.evaluate()

Probably my own code produces the error since in your map everything works.

The inventory items add attachments with tags as well but afterwards (in method updateInventoryAfterPassiveTransformation()). Could this somehow corrupt the animation name?

 

[Ezekiel12]

Could this somehow corrupt the animation name?

This code doesn't tell much, but since you seem to do other things with animation it's the probable cause.

Maybe a unit can only have one alternative animation tag?

 

[Barade]

Yes it had to do with another animation tag. I removed the possible already animation tags before adding the new one and that fixed it.

Thx!