Page error bug

[link598]

When i was looking for the member list of the neg rep people and i got this.

https://www.hiveworkshop.com/forums/memberlist.php?&order=asc&sort=reputation&pp=30&page=1


This is the bug i have found.

 

[Just_Spectating]

hmm, never happend to me.

 

[Earth-Fury]

Fatal Error

When sorting the member list by reputation and clicking the link for the last page, the following error comes up:

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 71 bytes) in /home/hiveworkshop.com/www/forums/includes/functions_reputation.php(139) : eval()'d code on line 16

One big question I have: Why is PHP displaying errors at all..? Shouldn't you be using error logging instead of error displaying for security..?

 

[Dr Super Good]

The error is caused by too many red gems appearing because some users have -999999 rep or something simlar.
Even if the error did not occur,no browser will function correctly as it will be displaying millions of gems.

Trying to fix by changing the folowing.
Jacek's reputation from -26000000 to -1000

Fatal error fixed.

 

[Ralle]

Haha! Good fix Doc! I didn't see that coming!

EF, you are right, I should log instead. I am just way too lazy.

 

[Samuraid]

Possibly PHP ran into its memory limit? The error message EF posted is exactly what happens when the memory_limit is reached.

 

[Pyritie]

Even when jacek had -260000000 it still worked fine.

I think it had something to do with archian and his bounty of red gems :3

 

[Dr Super Good]

No, the fact was Jacek had like 9999 or more red gems. This caused it to hit the memory limate.

 

[Pyritie]

No, jacek had 3 last time I checked.

 

[Dr Super Good]

Yes but the red gem limate was chaged. Thus the number shown was proportional to the ammount of rep one had. And so he was display more than there was memory to store them all.