Orbital Bombardment v1.1b

[Moderator]

12.12
IcemanBo: For long time as NeedsFix. Rejected.

11:45, 3rd Jun 2011
Maker:
Check my review, post #8 of this thread. The last created hashtable, OB_Clean being on all the time and OB_Counter check are the biggest issues, but try to do the others also.

 

[Marcos DAB]

Seems fine, and leakless.

 

[Archangel678]

Comments

Don't use (Key of(PickedUnit)) or anything like that. Its not efficient. Use:

• Custom script: set udg_YOURINTEGER = GetHandleId(udg_UNITVARIABLE)

Don't use 'Picked Unit' or 'Triggering Unit' more then once. Set it as a variable.

The OB_Targets and stuff is unneeded. Use:

• Custom script: set bj_wantDestroyGroup = True
• Unit Group - Pick every unit in YOUR RANGE range matching YOUR CONDITIONS and do (Actions)

The above script simplifies the steps, and does not require a unit group variable.

Somethings you could make more configurable:

This is a list of constants that you should make variables, and set those variables in map initialization.

• Set OB_Damage = (100.00 + (50.00 x (Real((Level of Orbital Bombardment for OB_Unit[1])))))
• Set OB_LightAoe = 150.00
• Set OB_Aoe = 100.00
• Set OB_LightDamage = (90.00 + (10.00 x (Real((Level of Orbital Bombardment for OB_Unit[1])))))
• Set OB_BombNumber = (4 + (2 x (Level of Orbital Bombardment for OB_Unit[1])))

 

[krisserz]

1. Right, gonna change it.
2. Where I used it? I think it's only in clean trigger and there are 2 actions so I don't see much point in storing it to variable.
3. I don't like bj_DestroyGroup. My personal preferences.
4. This part I didn't get.

Thank you for your comment.

 

[Manasurge]

Here's one example to what he means from one of my spells.
Constants are the values, numbers. Set them in the Init trigger to make it more configureable:
Example:
(it's not released yet )

Init

• Startup
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- ======================================================================= --------
    • -------- DON'T TOUCH THIS --------
    • -------- ======================================================================= --------
    • Hashtable - Create a hashtable
    • Set St_Hashtable = (Last created hashtable)
    • -------- ======================================================================= --------
    • -------- Configure this --------
    • -------- Formula: BaseValue + (BonusValue x Level of ability) = ActualValue --------
    • -------- St_Duration, St_LightningType, St_FloatingText and St_HitsTrees are the only variables that is not affected by the formula --------
    • -------- ======================================================================= --------
    • -------- Damage --------
    • -------- Remember: When dmg is AOE it will deal Actual_DmgAmount PER UNIT, so 3 units is (if Actual_DmgAmount is 150) 450 DMG TO EACH TARGET --------
    • -------- So lower the dmg when you have St_NrUnitsHit = more than 1 --------
    • Set St_CritAmount = 200.00
    • Set St_CritAmountSmall = 150.00
    • Set St_CritBonus = 50.00
    • Set St_DmgAmount = 100.00
    • Set St_DmgAmountBonus = 50.00
    • -------- Area of Effect --------
    • -------- AOE of spell when cast and dmg AOE of the Explode --------
    • Set St_Range = 200.00
    • Set St_RangeBonus = 50.00
    • -------- Sets the number of targets the spell hits --------
    • Set St_NrHitUnits = 2
    • Set St_NrHitUnitsBonus = 1
    • -------- Crit Chance in % --------
    • Set St_SmallCritChance = 20
    • Set St_SmallCritChanceBonus = 5
    • Set St_CritChance = 10
    • Set St_CritChanceBonus = 5
    • -------- St_Duration = 0.00 gives the duration (Until Dispelled) --------
    • Set St_Duration = 0.00
    • -------- Lightning Type --------
    • Set St_LightningType = Chain Lightning - Secondary
    • -------- Booleans --------
    • Set St_FloatingText = True
    • Set St_HitsDestructs = True
    • -------- Mana cost, Cooldown, Cast Range and Description is changed in Object Editor --------
    • -------- Trust me, i wish too it could be done in a trigger. :) --------
    • -------- ======================================================================= --------
• [/HIDDEN]

Cast

• Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Static Burst
  • Actions
    • Set St_Caster = (Triggering unit)
    • Set St_Level = (Level of (Ability being cast) for St_Caster)
    • Set St_Point1 = (Position of St_Caster)
    • Set St_LastHit = (Target unit of ability being cast)
    • Set St_LastHitPos = (Position of St_LastHit)
    • Set Actual_CritAmount = (St_CritAmount + (St_CritBonus x (Real(St_Level))))
    • Set Actual_CritAmountSmall = (St_CritAmountSmall + (St_CritBonus x (Real(St_Level))))
    • Set Actual_CritChance = (St_CritChance + (St_CritChanceBonus x St_Level))
    • Set Actual_SmallCritChance = (St_SmallCritChance + (St_SmallCritChanceBonus x St_Level))
    • Set Actual_DmgAmount = (St_DmgAmount + (St_DmgAmountBonus x (Real(St_Level))))
    • Set Actual_NrHitUnits = (St_NrHitUnits + (St_NrHitUnitsBonus x St_Level))
    • Set Actual_Range = (St_Range + (St_RangeBonus x (Real(St_Level))))

 

[krisserz]

I know what he meant by constants but I don`t know what it has to do with this spell. The variables he has shown are spell-level-based so they may change on each cast. They simply has to be in cast trigger. And such a things like aoe some people may want to change (however I used a constant value). In init trigger I`ve put only things which won`t change per spell level for sure.

EDIT: Oh, now I see what he exactly meant. No, I`m not gonna change it. I think people are smart enaugh to find out all they have to do is to change a value in one action.

 

[Manasurge]

I know what he meant by constants but I don`t know what it has to do with this spell. The variables he has shown are spell-level-based so they may change on each cast. They simply has to be in cast trigger. And such a things like aoe some people may want to change (however I used a constant value). In init trigger I`ve put only things which won`t change per spell level for sure.

You should always try to set all variables in the init trigger.
Like my example showed it works if you add a formula that the values follow.

• ------ in init ------
• Set St_DmgAmount = 100.00
• Set St_DmgAmountBonus = 50.00
• ------ in Cast -----
• Set Actual_DmgAmount = (St_DmgAmount + (St_DmgAmountBonus x (Real(St_Level))))
• ------ so ------
• Actual_DmgAmount = 100 + (50 * (Lvl of ability cast for triggering unit)

You place the constants in init trigger and the combination to the variable used in cast trigger so you can use the lvl

 

[Maker]

Comments

You could store the level of ability being cast into a variable since you're calling it three times. Not a big deal though.
Save the handle into a variable as mentioned.
I also agree that you should set all the configurables into variables in the init trigger, like base damage, bonus damage per ability level, AoE etc.
OB_Clean shouldn't be on all the time.
The learn tooltip image is missing.
The follow though time is too short for the unit to complete the animation, set it to about 1 second or something like that.
The dummy doesn't need invulnerability ability, is has locust.
I'd set the dummy to can't raise, does not decay. And not remove it with Unit - remove unit from game.
This should be done only when you reduce obcounter, it can't be zero during other loops:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • OB_Counter Less than or equal to 0
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

You can replace (Owner of(unit)) with triggering player in the cast trigger. It's slightly faster.
I recommend using bj_wantDestroyGroup for groups that you want to destroy immediately after use. Slightly better performance.
Last created hastable:

• (Load 10 of (Key (Picked unit)) from OB_Hash) Less than (Load 3 of (Key (Load 1 of (Key (Picked unit)) in OB_Hash)) from (Last created hashtable))

 

[krisserz]

Thank you. Gonna update the spell tomorrow.

EDIT: It`ll have to wait untill I find some time...