[vJASS] Optimize script again??

[jim7777]

Help help on my little script again

xD
just working with some animations like dota's shop but i can't understand how to use trackables so i come up with this

Code

The code? this thread should be closed

but i guess its kinda messy/not efficient/slow

please help library suggestions are accepted or just teach me how to use trackables D:

 

[Bannar]

I'm not experienced in vJass yet, so guess you will have to ask those who are, but what I see is that:

- you could combine actions & conditions together instead of splitting them.
- whats the local group g = CreateGroup() in Init function for? :S
- instead of using 2 hashtables, use one and manipulate indexes via: 1/-1 (the second index is the same one, just negative), if it can't be archieved, Table by Bribe could be usefull.

 

[jim7777]

baby let me love you dowwnn

ohh lol why is there a group there (my old trackable test forgot to delete that)
anyways this thing is old so i might try using the table

 

[Magtheridon96]

In the start function, you should cache stuff into local variables (GetTriggerPlayer, etc..)

 

[jim7777]

thanks for your help, i also tried my own optimization