Oblivion V1.1

[Moderator]

17:29, 22nd Dec 2009
TriggerHappy:

Review for Spell

Fixed everything I said.

Status

Feel free to message me here if you have any issues with my review or if you have updated your resource and want it reviewed again.

Approved

 

[Axarion]

First Comment Will test it and cant see any leaks. + rep

 

[Catch_ya]

change begins casting an ability to starts the effect of an ability

 

[Tank-Commander]

Woops lol, Well I always have to make one mistake or something has gone wrong with the world.
(Done)

-Subscribe-

 

[Cihparg]

Ok, I dont even need to make complete Review.

This is my review:
THIS SPELL ROCKS!
The Eye-Candy, triggering, GREEN!, and everything else in it rock'd.

Really, there's nothing else to say.
5/5

 

[Maker]

1) Why do you use countdown timer? I'd just use periodic event of 0,03 second.

2) I'd add "(Ability being cast) Equal to Oblivion" to the condition of the trigger, and not use IF/THEN/ELSE.

3) I'd use strings rather than integers for saving things in hashtable.

• Save (Level of Oblivion for (Triggering unit)) as 1 of...

• Save (Level of Oblivion for (Triggering unit)) as ability_level of...

The latter is much more descriptive.

4) You could loop those 1 to 15 loops. Put a loop inside a loop, and use a variable for changing the offset and flying height. Change the variables each time when the outer loop has run.

5) I'd use a dedicated unit group for loop trigger, add units to it in the spell cast trigger, and remove them from it when needed. Then there's no need to create/destroy Temp_Group. That way run_check becomes unnecessary, just check whether the group is empty or not.

6) (Unit-type of (Triggering unit)) Equal to Invisible Centre - IF/THEN/ELSE thingy should be in the first IF/THEN/ELSE thingy's ELSE branch. If the first check returns true, then this will return false.

7) Check the tooltip, there's one typo and unnecessary capital letters.

8) Good job with the spell

 

[D4RK_G4ND4LF]

it causes bugs when casted more than once

Screenshot

also I think the effects are overkill

note:
bug happened with 0 sec cooldown and casting with the same hero

 

[Tank-Commander]

Oh yea, the multichecker is what I forgot >.< I'm so forgetful :/
(Done, Hopefully)

 

[aki15]

It's biggest spell trigger i ever saw ...
Realy nice from Screenshot, not downloading cuz my comp will realy get sick

 

[Tank-Commander]

There are bigger, I've made bigger too, much bigger, my seraphic star was about twice the size of this lol.

 

[The World Is Flat]

Helll yes. this is awesome.

 

[CHA_Owner]

Leak #1

Special Effect - Create a special effect at Temp_Point using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl

In interval expires trigger

Leak #2

Special Effect - Create a special effect at Temp_Point using Abilities\Spells\Human\ThunderClap\ThunderClapCaster.mdl

In Unit-A unit Dies trigger


Hope this helps good luck

 

[Maker]

^I'm not seeing the leaks, did you notice there are "destroy last created special effect" in there in both cases.

 

[CHA_Owner]

oh my bad the destroy triggers were seperated by trigger comments......

 

[Lordarking00]

I only can say awesome +rep no laggs no leaks and nice effects

 

[Kingz]

Smooth spells ftw, i dislike the overuse of spec effects people are starting to use just to make it eye apealing

The fact is this is a simple spell, wrapped in the coat of giant SFX, nothing really special though(no offense).

Also please look into the following bug(screenshot), as i doubt it is made that corpses disipate in air on purpose.

EDIT:

Since you are using a timer, why do you shut the trigger down? Just pause and restart the timer as necesary

 

[Tank-Commander]

I suppose you right In saying It's simple wwith a big coat of sfx, But my next one (ehich will probably take months) Will be far more complex.

Anyway as for the bug, Can you specify how it occured or what was happening at the time (for exaple were you casting soemwere else at the exact same time etc.)?

It's never happend to me before. :/

 

[kennymckormic]

F***ING HELL NICE
enough said

 

[Scippi]

When i cast the spell the cage appears but nothing happens help?

 

[Tank-Commander]

Did you correctly import all the variables? (By this I mean is file - preferances - automatically create unknown variables was checked befire you added the triggers?

Other reasons may include not having the correct wc version or trying to use a program without hashtables to run the spell.

 

[Scippi]

My version is 1.24d, the skill worked when i tested it on the Oblivion map but it didn't work on my map. I have checked everything and the triggers are identical on both maps. Would i be able to send you the map to see what's wrong?

 

[Scippi]

Sorry i meant 1.24e

 

[Tank-Commander]

Well, I suppose theres no harm in me taking a look to see if anything has gone wrong =P

 

[Scippi]

Just sent you a message Tank

 

[Toxic 75]

Oh, this should be a famous spell. I approve this spell.

Approved

 

[troylowyee]

Delay before the spell starts

Is there a way to add a special effect or something like that for 2 seconds before the spell starts so that people have time to run away? i cant manage to do that. :/

 

[Tank-Commander]

It's possible but it's not in-built at all, it'd require individual coding skill to do, there's a couple methods: a long cast time, inserting dummy casting (caster uses on ability, which creates the signal/warning, then after a period of time a dummy unit is created which casts the main spell, though this may cause errors in terms of damage source (some modification to the main spell would have to be done as well to make sure the original caster was registered instead of the dummy unit).

Alternatively you could manually add a timer onto units within the range (they would have to be indexed), apply an effect to them (graphically) then when the unit's timer hits 0 then you play the rest of the ability (catch them) and recycle the unit index but all of this takes individual coding knowledge I'm afraid

 

[ToastAddict1057]

Is it me or i can't open the map?..

it says "Trigger function does not exist in database: "InitHashtableBJ