Nulling local triggers

[Strikest]

Do local triggers need to be nulled? I was under the impression that they didn't, but today someone suggested in my spell submission that I should null the local trigger created in my OnInit function. Is there any point in doing this?

I guess to clarify,

private function OnInit takes nothing returns nothing
        local trigger trig = CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(trig,EVENT_PLAYER_UNIT_SPELL_EFFECT)
        call TriggerAddCondition(trig,Condition(function OnSpell))
        set trig = null
endfunction

Is this fine? Is it fine if I don't null the trigger too?

Iirc, making triggers like this creates an unavoidable leak anyways, so there would be no point in nulling it?

 

[Geries]

It depends. Do you know handle leaks, right? This prevents leaking a handle if you ever destroy the trigger. If not, then it was useless, but the hardcore jass fags here insist nulling every handle type.

Anyways I didn't know that triggers generate serious leaks.

 

[WaterKnight]

It decreases the reference counter at least. Maybe some tiny reference would be cleared up.

@Geries: The point being made here was that the trigger is only called locally within the function, so the trigger cannot be destroyed although I do not like that the TC makes it sound like the trigger object would be local.

Not all handle types need their variables to be nulled. Only those that count to the big stack beyond 1mio. Those are called agents in most cases. Anyway, it seems more simple and routinely to just nullify everything.

 

[Geries]

Yeah yeah I know, but you still can destroy the trigger inside the trigger code with DestroyTrigger( GetTriggeringTrigger( ) ). Not like everyone would use that.

 

[Strikest]

Yeah just as I thought, it doesn't matter. Damn jassfags xD

 

[Dr Super Good]

Do local triggers need to be nulled?

If they are destroyed? Yes
If the triggers themselves are left to leak (persist the entire session)? No

Local handles only need to be nulled if the index is intended to be recycled at a later time during the session as otherwise they cause a reference counter leak. Local handles that are declared as function arguments do not need to be nulled, the reference leak is only with locals defined with the "local" key word.

 

[edo494]

I wonder, what abou globals? if I have a global location l, then I do

set l = Location(0, 0)
call RemoveLocation(l)
set l = Location(1, 0)

will that leak?
btw sorry if this is considered thread hijacking but Im curious and Ill not post another thread just for this small question

 

[Maker]

^That will not leak.

 

[Dr Super Good]

It will leak if l is never used again as it will still be referencing the old value of l (thus preventing the handle index from being recycled).