[vJASS] My Timer don't fire, why?

[Galdr]

Code

scope FrostStrom initializer init

    globals
        private constant real i = 1.0 //Interval
        private timer t
        private real x
        private real y
    endglobals
    
    function execute takes nothing returns nothing
        call BJDebugMsg("Tick!")
    endfunction

    private function condition takes nothing returns boolean
        return GetSpellAbilityId() == 'A000'
    endfunction
    
    private function action takes nothing returns nothing
        local location loc = GetSpellTargetLoc()
        local unit u = CreateUnitAtLoc(GetOwningPlayer(GetTriggerUnit()), 'h001', loc, 180.0)
        local integer i = 0
        set x = GetLocationX(loc)
        set y = GetLocationY(loc)
        call BJDebugMsg(R2S(x))
        call BJDebugMsg(R2S(y))
        call TimerStart(t, i, true, function execute)
        
        
        call KillUnit(u)
        call BJDebugMsg("Unit Kiled")
        set u = null
        set loc = null
        
    endfunction
    
    private function init takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
        call TriggerAddCondition(t, Condition(function condition))
        call TriggerAddAction(t, function action)
    endfunction
        
endscope

The above code is what I wrote for testing purpose. But then when I test I find that my timer never fire.(The debug message in the execute function never run) As you can see I had put some debug msg so I can figure it out that everything run just fine until it reach the timer one. So I come here to seek for some help. Can you find out that what's wrong? Thanks!

 

[Krogoth]

Corrected.

scope FrostStrom initializer init

    globals
        private constant real i = 1.0
        private timer t
        private real x
        private real y
    endglobals
    
    function execute takes nothing returns nothing
        call BJDebugMsg("Tick!")
    endfunction

    private function condition takes nothing returns boolean
        return GetSpellAbilityId() == 'AHtc'
    endfunction
    
    private function action takes nothing returns nothing
        local location loc = GetSpellTargetLoc()
        local unit u = CreateUnitAtLoc(GetOwningPlayer(GetTriggerUnit()), 'h001', loc, 180.0)
        local integer j = 0 //This one was called the same as global constant real i, 0.0 interval was used instead.
        //Don't name local variables as globals.
        set x = GetLocationX(loc)
        set y = GetLocationY(loc)
        call BJDebugMsg(R2S(x))
        call BJDebugMsg(R2S(y))
        call TimerStart(t, i, true, function execute)
        call KillUnit(u)
        call BJDebugMsg("Unit Kiled")
        set u = null
        set loc = null
    endfunction
    
    private function init takes nothing returns nothing
        local trigger trig = CreateTrigger()
        set t = CreateTimer() //You forgot to create a timer.
        call TriggerRegisterAnyUnitEventBJ(trig, EVENT_PLAYER_UNIT_SPELL_EFFECT)
        call TriggerAddCondition(trig, Condition(function condition))
        call TriggerAddAction(trig, function action)
    endfunction
        
endscope

2 mistakes.

 

[mckill2009]

- you dont need to create the timer in the 'init' just create it above at global
- use coordinates instead of locations
- merge the TriggerAddCondition and TriggerAddAction coz it's faster

 

[Lender]

you dont need to create the timer in the 'init' just create it above at global

he don't need to create in 'init' and MUST NOT create there, cuz the timer will be created even if the Condition fails...so it leaks

 

[Krogoth]

- you dont need to create the timer in the 'init' just create it above at global

What the difference is?

 

[Lender]

the difference is in my previous comment

 

[Galdr]

Oh I see, the problem is I forgot to create a timer.
Thanks all a lot! +REP

 

[Krogoth]

the difference is in my previous comment

Have I understood right that this

private timer t

creates first timer and this

//init:
set timer t = CreateTimer()

creates second and first leaks??? How? Why?

 

[mckill2009]

he don't need to create in 'init' and MUST NOT create there, cuz the timer will be created even if the Condition fails...so it leaks

it doesnt leak if he uses the timer again and again coz he's interval is true NOT false...

 

[Krogoth]

O, I wrote such not understandable shit.

 

[PurplePoot]

he don't need to create in 'init' and MUST NOT create there, cuz the timer will be created even if the Condition fails...so it leaks

It doesn't leak, since a reference to it is preserved. It's a waste of memory, but a memory leak specifically involves the object not being able to be referenced yet still taking up memory (an important distinction).

That said, creating the occasional extra handle is not a big deal. The issue with most actual leaks is that if they occur very frequently (usually in 0.01s repeating timers or similar situations) you can rapidly generate silly numbers of useless handles. You'd have to try very hard to explicitly create enough individual handles to cause issues without any sort of looping/recursive/otherwise complicating mechanism.