[JASS] My first jass trigger

[Da)sniper]

Ok I'm making the simplist jass trigger ever. yeah I know I suck. Every time I do it, it asks me for a end of the line statement. I have no idea what that is.

Function Mi_First_Jass_trigger takes nothing and returns nothing

local unit u = GetTriggerUnit (BladeMaster 001)
call KillUnit (u)

I just wanted to start off simple but supponsdly theres 4 things wrong. First line has a end of a code error along with second line
The third line has something wierd wrong (i think)
and the fouth has a problem.
The problems are Expected end of line (x2), Expected a name, Expected a line statement.
Please help!

 

[PurplePoot]

• decapitalize F on function.
• remove the 'and' from the first line.
• remove 'BladeMaster 001' from the brackets of GetTriggerUnit()
• add 'endfunction' on a new line at the end.

[jass=Solution]function My_First_Jass_Function takes nothing returns nothing
local unit u = GetTriggerUnit()
call KillUnit(u)
//note, the following line would NOT be needed for it to compile, but is antileak
set u = null
endfunction[/code]

 

[Earth-Fury]

"Function" worng. its "function". case matters.

"takes nothing and returns" wrong. "takes nothing returns nothing" there should be no and...

"BladeMaster 001" ??? the hell? variables can't have spaces... and... wtf is that?

also, you're missing "endfunction".

Go read JASS tutorials. you quite obviously have no idea what you're doing, and the tutorials that are all over should help you understand.

 

[Da)sniper]

I did thought i added end function (im on a labtob that im not used to) didnt mean to caps the "f" its just out of habit from posting here. Also theres still three problems but the first line is good. expected a name (x2) expected a code statement. I matched exactly what you said and when I added the null trigger it came up with another error.

function Mi_First_Jass_Trigger takes nothing returns nothing
local unit u = GetTriggeringUnit()
call KillUnit(u)
set u = null
endfunction

For null it saids it needs a varible.

 

[PurplePoot]

Erm, there should be no errors if you actually read what we say...

 

[wd40bomber7]

The problem is

 GetTriggeringUnit()

It should be

 GetTriggerUnit()

 

[Da)sniper]

Isnt it if you put something in the () after something itll make it? or am I just somehow not comprehending that tut right ;\

 

[wd40bomber7]

Just make the correction I pointed out and your trigger well work, I don't completely understand your question.

function OMG takes unit rak returns region
call RemoveUnit(rak)
return CreateRegion()
endfunction

Now that function doesn't really do anything useful, but you can call it like this.

call OMG(X)

Where X is a unit.

 

[PurgeandFire]

If you know PHP or C (I think), functions can take parameters. In JASS, it is similar.

Say you do this:

    call KillUnit(GetTriggerUnit())

This parses correctly.

  native KillUnit takes unit whichUnit returns nothing

The "takes unit" means that you must put a unit variable or function within the parentheses.

In this case, GetTriggerUnit() is our unit.

  native GetTriggerUnit takes nothing returns unit

Since GetTriggerUnit returns unit, it is a valid entry for the parentheses.

What a function takes is called parmeter(s).

So, KillUnit takes GetTriggerUnit because GetTriggerUnit returns a unit and "unit" is what the KillUnit takes. That might be a bit confusing... Reread this post a couple of times until you understand it.

 

[PurplePoot]

The problem is

 GetTriggeringUnit()

It should be

 GetTriggerUnit()

He didn't write that =o

Isnt it if you put something in the () after something itll make it? or am I just somehow not comprehending that tut right ;\

GetTriggerUnit() just returns the Triggering Unit of an event that's just run and has called the function you're calling GetTriggerUnit() in as an action. (Or a parent-func on the stack)

Just make the correction I pointed out and your trigger well work, I don't completely understand your question.

 function OMG takes unit rak returns Region
call UnitRemove(rak)
return CreateRegion()
endfunction

Now that function doesn't really do anything useful, but you can call it like this.

 OMG(X)

Where X is a unit.

Actually, yours doesn't fix anything and leaves a lot wrong - mine and EFs solve it.

Also, it's "region" not "Region", "RemoveUnit()" not "UnitRemove()", you need "call" in front of "OMG(X)", and a "region" is not the "Region" from GUI - that's a "rect".

 

[wd40bomber7]

I'm sorry about that, I was in a hurry. I fixed all my stupid little errors. Sorry for any confusion I caused. *Feels like an idiot*

 

[PurplePoot]

Heh, it's normally beyond fine to make mistakes, but try to be a little more careful when helping people, so as to avoid utterly confusing them