[MUI] Omnislash v0.1

[Moderator]

4 November 2015
Bribe: Rejecting due to the status of this resource being "needs fix" for years.

21:16, 4th Jan 2010
The_Reborn_Devil:
The code looks fine, but don't use TSA. Timers are a lot faster.

Status: Rejected until updated
Rating: N/A

 

[Down]

maybe you could change some things on it that it isn't like the dota omnislash
mhm 3/5
it's ok at all

 

[Noxtran]

i just trying to make dota spell...
but, i think i'm not creative o_o

 

[Down]

you try make dota spells mhmmmm
if this should be like a dota spell it is very good

 

[-JonNny]

Hmm.. im not sure (cuz i never used it before JNGP) but doest make your marking of the functions as constant this to vJass? anyway..

I would suggest to change it to complete vJass
a global block would spar alot lines

your

constant function SpellRawcode takes nothing returns integer
    return 'A000'
endfunction

constant function BlinkDelay takes nothing returns real
    return 0.15
endfunction

constant function BlinkDamage takes nothing returns real
    return 150.00
endfunction

constant function BlinkRadius takes nothing returns real
    return 600.00
endfunction

constant function WeaponEffect takes nothing returns string
    return "Abilities\\Weapons\\PhoenixMissile\\Phoenix_Missile.mdl"
endfunction

constant function BlinkFirstEffect takes nothing returns string
    return "Abilities\\Spells\\NightElf\\Blink\\BlinkCaster.mdl"
endfunction

constant function BlinkEffect takes nothing returns string
    return "Abilities\\Spells\\NightElf\\Blink\\Blinka.mdl"
endfunction

constant function AttackType takes nothing returns attacktype
    return ATTACK_TYPE_HERO
endfunction

constant function DamageType takes nothing returns damagetype
    return DAMAGE_TYPE_NORMAL
endfunction

constant function WeaponType takes nothing returns weapontype
    return WEAPON_TYPE_AXE_MEDIUM_CHOP
endfunction

way shorter

globals
    constant integer SpellRawcode = 'A000'
    constant real BlinkDelay = 0.15
    constant real BlinkDamage = 150.00
    constant real BlinkRadius = 600.00
    constant string WeaponEffect = "Abilities\\Weapons\\PhoenixMissile\\Phoenix_Missile.mdl"
    constant string BlinkFirstEffect = "Abilities\\Spells\\NightElf\\Blink\\BlinkCaster.mdl"
    constant string BlinkEffect = "Abilities\\Spells\\NightElf\\Blink\\Blinka.mdl"
    constant attacktype AttackType = ATTACK_TYPE_HERO
    constant damagetype DamageType = DAMAGE_TYPE_NORMAL
    constant weapontype WeaponType = WEAPON_TYPE_AXE_MEDIUM_CHOP
endglobals

also i would suggest to make some of these not to constants. e.g. a damage value depending on the level would be nice...

An own function for setting of the amount of jumps would be good to ensure easier editability

dont create a group each cast, atleast use a global and clear it each time with [GroupClear(g)


i guess this can be changed

        if IsUnitGroupEmptyBJ(g) == false then
            set b = GroupPickRandomUnit(g)
            ...
        endif

to

        set b = GroupPickRandomUnit(g)
        if b != null then
            ....
        endif

You set the Blink delay to 0.15 seconds but TriggerSleepActions under ~0.30 will normally wait for ~0.30

thats what ive found with skimming the code
atall the code looks ok for Jass but there a thousands of omnislashes, i guess this is not the best ive seen even i cant find another good one here for now [3.25/5]

 

[Noxtran]

EDIT: Now changed the constant variable.. thx -JonNny

 

[Ironside]

I hope this one is good, because I really need a Omnislash

EDIT: Ok It's great, I'll use it, credits given ofc. thanks

 

[Staff SgT Legacy]

ey how do i change the animation effect?

 

[Noxtran]

ey how do i change the animation effect?

just edit the global variable

 

[Staff SgT Legacy]

ok how i do that? xD
i changed the string here

constant string WeaponEffect = "Abilities\Weapons\ZigguratMissile\ZigguratMissile.mdl"

but the ability wont work anymore idk why
plz help me out =]

 

[xorkatoss]

very good spell!! 5/5
finaly an omnislash that works lol

 

[KuWe]

this is nice spell! I love it definitely 5/5