• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

MUI Advanced Equipment System (+Save/Load +Event)

This is my Advanced Equipment System

It is based on the same idea like many others: click on an item and it gets equipped, click on it in the equipment screen to unequip it.

It is advanced because it has many special options available!
Prevent unit types from equipping certain items.
Items may change animations.
Save/load code integration
and many more...

For explaination of the included functions check the documentations included in the map

Features:
  • decide whether a weapon is one or twohanded
  • give a unit a special animation tag, depending on the equiped item
  • an offhand tag will overwrite all mainhand tags (a shield will always cause defend animation)
  • functions for forcing equip/unequip
  • functions for getting information
  • functions for prohibiting a unit from equipping an item (for example for race-only items)
  • Save/load code generator included
  • Register Events to your triggers, firing on item equip and unequip
  • items can give countless abilities



my system is MUI, so every unit can have its own equipment, and easy to customize.
full documentation included.

New improved "How to import" and "How to Use" included, too!!

YOU NEED JNGP AND JASS KNOWLEDGE TO GET THIS WORKING! WITHOUT JNGP AND JASS KNOWLEDGE IT IS IMPOSSIBLE!

I importet some files!!!
the icons and models don't violate any rules, because they are necessary to show what this system can do!! credits ingame.

comment and if you like it maybe +rep^^
give credits when used

have fun

IMPORTANT:
For all who ask me to make the system in a spellbook:
That would be much more work for the users of this system and highly inefficient!!
I will not change that so don't ask me to do that anymore!




UPDATE v.1.5:
I read vercas suggestions and improved my scripting.
Adding an item is now much more simple^^
thx to vercas for his review

UPDATE v.2.0:
Tige_R found a bug, reseting the shield animation when another item got unequipped
fixed that!!

UPDATE v.3.0: BIG thx to teldrassil who found a huge bug which was settled in all my systems!!! i managed to fix it and updated ALL my newer systems!!!

UPDATE v.4.0: now there is no need anymore that the equipable items are of one itemclass! added system code to the description here

UPDATE v.5.0: it's possible now, to make items give up to 3 abilities when equipped instead of 1 in the previous versions...

UPDATE v.6.0: The bug fixed in v.2.0 was still there... now its really gone AND the script is 1.24 compatible

UPDATE v.6.5: added a new function (IsEquipmentClassEmpty) to check whether a specific unit has something from class x equipped
more information in the code

UPDATE v.7.0: added a new function (GetEquipItemID) to get an items rawcode which is equipped
more information in the code

UPDATE v.8.0: added 3 new functions (GetEquipItemIndex, EquipItemByIndex and EquipItemByID) to get an items index which is equipped (not the same as rawcode) and to equip a item by this index, which helps with the usage of Save/Load Systems
the last function makes you able to equip an item by its rawcode.
more information in the code

UPDATE v.9.0: again 2 new functions for prohibiting a unit from equipping an item or allowing it again for it(EnableItemEquipByID and EnableItemEquipByIndex) and a new function for getting the index of an item (not of its rawcode) --> GetItemIndex
Also much better performance because of the use of hastables!

UPDATE v.10.0: all O(n) searches are now replaced by hashtables!! also there is a new function (TransferEquipment) to move the equipment from unit a to unit b

UPDATE v.11.0: made the item registeration useable outside the library, improved documentation

Update v.12.0: created a how to import and structured the code a little more. also improved the empty-slot-icons

Update v.13.0: New code for equipping items and a new workaround for twohanded items

Update v.14.0: Reworked the beginning of the code, changed variable names, and removed a last rest of german i left in the testmap...


NEW versions:
Update v.2.0: At first I'd like to thank you for your great support!!
As so many of you love it I decided to refresh this a little!
Well i got a lot more experience since i first uploaded this and decided to remake the code... now takes advantage of much more efficient struct usage, doesn't need any hashtable anymore, runs smoother, more ways to work with (if you understand vJass), and many more new things...
Whole new documentation and new methods to work with!
Of course I kept the old names for most of the functions to make it easier for you to apply the new update!
SO: Have fun :D

Update v.2.1: Added Save/Load system, fixed the unequip function, added unequipAll function

Update v.2.2: Added Events and updated the "how to use"

UPDATE v.2.3: Thanks to creativeRPG for finding a very bad bug! i fixed it and suggest everyone to only use the new code!! the one from 2.2 may not work and freeze your game!

Update v.2.4: creativeRPG found more deadly bugs: you could equip items with all units you wanted to the unit owning the inventory and when equipping a one handed weapon while a two handed weapon was equipped the "offhand slot not available" button didn't vanish... fixed now! redownload is necessary!!!!!

Update v.2.5: aaaand again creativeRPG found a bug when you have too many items in your map the index gets too high for the system and it stops working

Update v.3.0: I chagned the whole code for equipping and unequipping and improved the ability handling:
its possible to get up to 50 abilitites from each item
added disbtns for my icons

Update v.3.1: Fixed bugs with syncing the inventories causing mass item creation on the map, made items in the dummys inventory undropable

Update v.4.0: Reduced Abilities per item to 20, fixed a bug for multiplayer usage preventing a second player from using the system, fixed an animation bug where the shield animation didn't disappear

Update v.5.0: New code cause the old one was buggy as hell :D works like a charm now

Update v.5.1: Fixed a bug regarding set Equipment[].owner=

Update v.5.2: Fixed a bug causing standard items to unequip registered equipment



JASS:
library AdvancedEquipmentSystem requires LinkedListModule, RegisterPlayerUnitEvent

    // The_Witcher's Equipment System
    //
    // This is my easy to use equipment system, which adds an equipment screen to any unit you want.
    //  equipped items can give up abilities to the owner and can change the animations of him...
    //
    //
    //       To learn how to use this system please read the "How To Use" delivered in the demo map
    //
    //
    // Requirements:
    //    JASS knowledge
    //    LinkedList (http://www.hiveworkshop.com/forums/jass-resources-412/snippet-linkedlistmodule-206552/)
    //    RegisterPlayerUnitEvent (http://www.hiveworkshop.com/forums/jass-resources-412/snippet-registerplayerunitevent-203338/)
    //
    // have fun^^

    //**************************************************
    //********************SETUP PART********************
    //**************************************************

    globals
        // this is the rawcode of the unit which works as inventory
        public constant integer INVENTORY_DUMMY = 'h007'
     
        // this is the class you selected as mainhand class
        public constant integer MAINHAND_CLASS = 0
     
        // this is the class you selected as offhand class
        public constant integer OFFHAND_CLASS = 1
        
        // this is the amount of total classes you have
        public constant integer CLASSES = 9
     
        // this is the ability to close the inventory
        public constant integer EXIT_ABILITY = 'A00G'
     
        // this is the ability to open the inventory
        public constant integer OPEN_ABILITY = 'A003'
        
        // this is the ability which gives the dummy the same inventory as your hero has
        public constant integer INVENTORY_ABILITY = 'AInv'
     
        // this is the icon ability shown in the offhand slot when a twhoanded weapon is equipeed
        public constant integer TWOHAND_ABILITY = 'A00Z'
        public constant boolean SHOW_TWOHAND_ABILITY = true
     
        // this is the text shown when a unit is trying to equip an item which it isnt allowed to
        // example: " can't equip " becomes ingame something like   Soldier can't equip Giant Sword
        public constant string UNABLE_TO_EQUIP_STRING = " can't equip "
    endglobals

    //************************************************************
    //********************SETUP PART ENDS HERE********************
    //************************************************************
    //*****************Don't edit anything below******************
    //************************************************************

    globals
        private trigger OnEquip
        private trigger OnUnequip
        private integer TriggeringItem
        private unit EquippingUnit
        private hashtable table
    endglobals
    
    private struct AbilityList extends array
        integer abi
        implement LinkedList
        
        static method create takes nothing returns thistype
            return .createNode()
        endmethod
        
        method remove takes nothing returns nothing
            call .removeNode()
            call .deallocate()
        endmethod
        
        method add takes integer abi returns nothing
            local thistype new = .allocate()
            set new.abi = abi
            call .insertNode(new)
        endmethod
    endstruct


    // **** struct EquipmentItem ****
    private struct EquipmentItem extends array
        readonly integer id
        readonly integer class
        readonly AbilityList abilities
        readonly integer icon
        readonly boolean twohanded
        readonly string tag

        static method operator [] takes integer itemid returns EquipmentItem
            return itemid - 'I000' + CLASSES + 1
        endmethod
    
        static method create takes integer id, integer icon, integer class, boolean twohanded, string animation returns EquipmentItem
            local EquipmentItem this = id - 'I000' + CLASSES + 1
            if id - 'I000' >= 0 then
                call SaveBoolean(table, id - 'I000', 0, true)
            endif
            set .id = id
            set .class = class
            set .icon = icon
            if id >= CLASSES + 1 then
                set .abilities = AbilityList.create()
                if class == MAINHAND_CLASS then
                    set .twohanded = twohanded
                else
                    set .twohanded = false
                endif
                if (class == MAINHAND_CLASS or class == OFFHAND_CLASS) and id != 0 then
                    set .tag = animation
                else
                    set .tag = ""
                endif
            endif
            return this
        endmethod
        
        method addAbility takes integer abi returns nothing
            call .abilities.add( abi)
        endmethod
        
        method applyAbilities takes unit u, boolean add returns nothing
            local AbilityList node = .abilities.next
            loop
                exitwhen node.head
                if add then
                    call UnitAddAbility(u, node.abi)
                else
                    call UnitRemoveAbility(u, node.abi)
                endif
                set node = node.next
            endloop
        endmethod
    endstruct

    public function RegisterNewClass takes integer emptyicon, integer class returns nothing
        call EquipmentItem.create('I000' - CLASSES - 1 + class, emptyicon, class, false, "")
    endfunction

    // **** struct Equipment ****    
    struct Equipment
        private static EquipmentItem twohandIcon
    
        private unit u
        private unit dummy
        readonly string animtag = ""
        readonly EquipmentItem array Item [12]
    
        static method operator [] takes unit u returns Equipment
            return LoadInteger(table, GetHandleId(u), 0)
        endmethod
    
        method operator owner takes nothing returns unit
            return .u
        endmethod
    
        method operator owner= takes unit new returns nothing
            local integer i = 0
            loop
                exitwhen i >= CLASSES
                if .Item[i] != 0 then
                    call .Item[i].applyAbilities(.u, false)
                    call .Item[i].applyAbilities(new, true)
                endif
                set i = i + 1
            endloop
            call AddUnitAnimationProperties(.u, .animtag, false)
            call UnitRemoveAbility(.u, OPEN_ABILITY)
            call AddUnitAnimationProperties(new, .animtag, true)
            call UnitAddAbility(new, OPEN_ABILITY)
            set .u = new
            call SaveInteger(table, GetHandleId(.u), 0, this)
            call SaveInteger(table, GetHandleId(.dummy), 0, this)
        endmethod
        
        method syncInventories takes nothing returns nothing
            local integer i = 0
            loop
                exitwhen i >= 6
                call RemoveItem(UnitItemInSlot(.dummy, i))
                call UnitAddItemToSlotById(.dummy, GetItemTypeId(UnitItemInSlot(.u, i)), i)
                call SetItemDroppable(UnitItemInSlot(.dummy, i), false)
                set i = i + 1
            endloop
        endmethod
    
        private method refreshAnimation takes nothing returns nothing
            local string a = .Item[MAINHAND_CLASS].tag
            if .Item[OFFHAND_CLASS] != 0 and .Item[OFFHAND_CLASS] != twohandIcon then
                set a = .Item[OFFHAND_CLASS].tag
            endif
            call AddUnitAnimationProperties(.u, .animtag, false)
            call AddUnitAnimationProperties(.u, a, true)
            set .animtag = a
        endmethod
        
        method equipEmptyClass takes integer class returns nothing
            call UnitAddAbility(.dummy, EquipmentItem(class).icon)
            set .Item[class] = 0
        endmethod
        
        method equipTwohandIcon takes nothing returns nothing
            call UnitAddAbility(.dummy, twohandIcon.icon)
            set .Item[OFFHAND_CLASS] = twohandIcon
        endmethod
    
        method unequip takes integer class returns nothing
            local integer i = 0
            local EquipmentItem toRemove = .Item[class]
            if toRemove != 0 then
                if toRemove.twohanded then
                    call UnitRemoveAbility(.dummy, TWOHAND_ABILITY)
                    call .equipEmptyClass(OFFHAND_CLASS)
                endif
                call toRemove.applyAbilities(.u, false)
                call UnitAddItemById(.u, toRemove.id)
                set TriggeringItem = toRemove.id
                set EquippingUnit = .u
                call TriggerEvaluate(OnUnequip)
                call UnitRemoveAbility(.dummy, toRemove.icon)
            else
                call UnitRemoveAbility(.dummy, EquipmentItem(class).icon)
            endif
            set .Item[class] = 0
            call .refreshAnimation()
        endmethod
        
        method equip takes integer id returns nothing
            local EquipmentItem toEquip = EquipmentItem[id]
            local EquipmentItem mainEquip = .Item[MAINHAND_CLASS]
            // remove existing
            if mainEquip != 0 then
                if toEquip.twohanded or (mainEquip.twohanded and (toEquip.class == OFFHAND_CLASS or toEquip.class == MAINHAND_CLASS)) then
                    call .unequip(MAINHAND_CLASS)
                    call .unequip(OFFHAND_CLASS)
                    if toEquip.class == MAINHAND_CLASS and not toEquip.twohanded then
                        call .equipEmptyClass(OFFHAND_CLASS)
                    elseif toEquip.class == OFFHAND_CLASS then
                        call .equipEmptyClass(MAINHAND_CLASS)
                    endif
                endif
            endif
            call .unequip(toEquip.class)
            // new is twohanded ?
            if toEquip.twohanded then
                call .unequip(OFFHAND_CLASS)
                call .equipTwohandIcon()
                if not SHOW_TWOHAND_ABILITY then
                    call UnitRemoveAbility(.dummy, twohandIcon.icon)
                endif
            endif
            // equip new
            call toEquip.applyAbilities(.u, true)
            call UnitAddAbility(.dummy, toEquip.icon)
            set .Item[toEquip.class] = toEquip
            call .refreshAnimation()
            // fire trigger
            set EquippingUnit = .u
            set TriggeringItem = id
            call TriggerEvaluate(OnEquip)
        endmethod
        
        static method disable takes integer itemId, integer unitType, boolean flag returns nothing
            call SaveBoolean(table, itemId - 'I000', unitType, flag)
        endmethod
        
        private method onDestroy takes nothing returns nothing
            local integer i = 0
            call RemoveUnit(.dummy)
            loop
                exitwhen i > 12
                if .Item[i] != 0 then
                    call .Item[i].applyAbilities(.u, false)
                endif
                set i = i + 1
            endloop
            call AddUnitAnimationProperties(.u, .animtag, false)
            call UnitRemoveAbility(.u, OPEN_ABILITY)
        endmethod
    
        static method create takes unit u returns Equipment
            local Equipment this = Equipment[u]
            local integer i = 0
            local integer id = GetPlayerId(GetOwningPlayer(u))
            if this != 0 then
                call RemoveUnit(.dummy)
            else
                set this = Equipment.allocate()
                call SaveInteger(table, GetHandleId(u), 0, this)
            endif
            set .u = u
            set .dummy = CreateUnit(GetOwningPlayer(u), INVENTORY_DUMMY, GetUnitX(u), GetUnitY(u), 0)
            call SaveInteger(table, GetHandleId(.dummy), 0, this)
            call UnitAddAbility(.dummy, INVENTORY_ABILITY)
            call UnitAddAbility(.dummy, EXIT_ABILITY)
            call UnitAddAbility(.u, OPEN_ABILITY)
            loop
                exitwhen i >= CLASSES
                call .equipEmptyClass(i)
                set i = i + 1
            endloop
            return this
        endmethod
        

    // **** Other Stuff ****
        private static method Access takes nothing returns boolean
            local unit u = GetTriggerUnit()
            local Equipment inv = Equipment[u]
            local integer class
            local integer i = 0
            if GetSpellAbilityId() == EXIT_ABILITY then
                if GetLocalPlayer() == GetOwningPlayer(inv.u) then
                    call ClearSelection()
                    call SelectUnit(inv.u, true)
                endif
            elseif GetSpellAbilityId() == OPEN_ABILITY then
                call SetUnitX(inv.dummy, GetUnitX(inv.u))
                call SetUnitY(inv.dummy, GetUnitY(inv.u))
                if GetLocalPlayer() == GetOwningPlayer(inv.u) then
                    call ClearSelection()
                    call SelectUnit(inv.dummy, true)
                endif
                call inv.syncInventories()
            elseif GetUnitTypeId(u) == INVENTORY_DUMMY then
                loop
                    exitwhen i >= CLASSES
                    if inv.Item[i].icon == GetSpellAbilityId() then
                        set class = i
                        set i = CLASSES
                    endif
                    set i = i + 1
                endloop
                call inv.unequip(class)
                call inv.equipEmptyClass(class)
                call inv.syncInventories()
            endif
            set u = null
            return false
        endmethod

        private static method ItemEquip takes nothing returns boolean
            local unit u = GetTriggerUnit()
            local item ite = GetManipulatedItem()
            local integer i = 0
            local Equipment inv = Equipment[u]
            local EquipmentItem invIte = EquipmentItem[GetItemTypeId(ite)]
            if GetItemTypeId(ite) - 'I000' >= 0 then
                if LoadBoolean(table, GetItemTypeId(ite) - 'I000', 0) then
                    if invIte != 0 and inv != 0 then
                        if not LoadBoolean(table, GetItemTypeId(ite) - 'I000', GetUnitTypeId(inv.u)) then
                            if u == inv.u then
                                call inv.equip(GetItemTypeId(ite))
                                call RemoveItem(ite)
                                call inv.syncInventories()
                            elseif u == inv.dummy then
                                loop
                                    exitwhen i >= 6
                                    if invIte.id == GetItemTypeId(UnitItemInSlot(inv.u, i)) then
                                        call UnitUseItem(inv.u, UnitItemInSlot(inv.u, i))
                                        call RemoveItem(ite)
                                        set i = 7
                                    endif
                                    set i = i + 1
                                endloop
                            endif
                        else
                            call DisplayTextToPlayer(GetOwningPlayer(inv.u), 0, 0, GetUnitName(inv.u) + UNABLE_TO_EQUIP_STRING + GetItemName(ite))
                        endif
                    endif
                endif
            endif
            set u = null
            set ite = null
            return false
        endmethod
        
        private static method onInit takes nothing returns nothing
            set OnEquip = CreateTrigger()
            set OnUnequip = CreateTrigger()
            call RegisterPlayerUnitEvent(EVENT_PLAYER_UNIT_USE_ITEM, function Equipment.ItemEquip)
            call RegisterPlayerUnitEvent(EVENT_PLAYER_UNIT_SPELL_CAST, function Equipment.Access)
            set .twohandIcon = EquipmentItem.create('I000' - 1, TWOHAND_ABILITY, 0, false, "")
            set table = InitHashtable()
        endmethod
        
        implement optional SaveLoadPlugin
    
    endstruct

    // **** Trigger Events ****
    function RegisterItemEquipEvent takes code func returns nothing
        call TriggerAddCondition(OnEquip, Filter(func))
    endfunction
    
    function RegisterItemUnequipEvent takes code func returns nothing
        call TriggerAddCondition(OnUnequip, Filter(func))
    endfunction
    
    function GetTriggeringItemId takes nothing returns integer
        return TriggeringItem
    endfunction
    
    function GetEquippingUnit takes nothing returns unit
        return EquippingUnit
    endfunction
   
   //wrappers
    function InitEquipment takes unit whichunit returns nothing
        call Equipment.create(whichunit)
    endfunction

    public function RegisterItem takes integer itemid, integer icon, integer class, boolean twohanded, string animation returns nothing
        call EquipmentItem.create(itemid, icon, class, twohanded, animation)
    endfunction
    
    public function AddItemAbility takes integer itemid, integer abi returns nothing
        call EquipmentItem[itemid].addAbility(abi)
    endfunction
    
    function EnableItemEquip takes integer itemId, integer unitType, boolean flag returns nothing
        call Equipment.disable(itemId, unitType, not flag)
    endfunction

    function IsEquipmentClassEmpty takes unit u, integer class returns boolean
        return Equipment[u].Item[class] == 0
    endfunction

    function EquipItem takes unit u, item ite returns nothing
        call Equipment[u].equip(GetItemTypeId(ite))
        call RemoveItem(ite)
    endfunction
    function EquipItemById takes unit u, integer itemId returns nothing
        call Equipment[u].equip(itemId)
    endfunction

    function UnequipItemById takes unit u, integer itemid returns nothing
        local integer class = EquipmentItem[itemid].class
        if Equipment[u].Item[class].id == itemid then
            call Equipment[u].unequip(EquipmentItem[itemid].class)
            call Equipment[u].equipEmptyClass(class)
        endif
    endfunction

    function UnequipItemByClass takes unit u, integer class returns nothing
        call Equipment[u].unequip(class)
        call Equipment[u].equipEmptyClass(class)
    endfunction

    function GetEquippedItemTypeId takes unit u, integer class returns integer
        return Equipment[u].Item[class].id
    endfunction

    function ChangeEquipmentOwner takes unit u, unit newowner returns nothing
        set Equipment[u].owner = newowner
    endfunction

    function UnequipAll takes unit u returns nothing
        local integer i = 1
        loop
            call Equipment[u].unequip(i)
            call Equipment[u].equipEmptyClass(i)
            exitwhen i >= CLASSES
            set i = i + 1
        endloop
    endfunction

endlibrary


//Code indented using The_Witcher's Script Language Aligner
//Download the newest version and report bugs at www.hiveworkshop.com

Keywords:
equipment, equip, system, item, hero, unit, bonus, stat, vjass, jngp, mui, mpi, animation, ability, save, load, hashtable, code, Event, events
Contents

Advanced Equipment System (Map)

Reviews
20:01, 26th Oct 2009 TriggerHappy187: Approved because of so many minimod approvals and high ratings. I also couldn't see anything wrong inside the code.
Level 6
Joined
Jul 22, 2009
Messages
214
It's juste too much epic this system, I really love it and I think i will use it.

Juste two things
1) Is it possible to add a system for item set, I'm talking about a system that give you bonus when you equip all item of a set, for exemple A Paladin wear all the Paladin tier 1 set he receive a bonus( the bonus could be like the item stats, ability that the system add to the unit)?
2) I think i've found a little bug, when I equip a shield it change the animation for defend, but when i unequip the shield it's keep this animation, is it supposed to rechange to the first hand animation?
 
Level 1
Joined
Jun 21, 2010
Messages
2
Im newbie dont rage at meXD

Hi how does this work?? im making a map to wc3 and i saw this and it looked cool so i want it:ogre_hurrhurr: but now i have some problems like how do i make new items for it or even how to carry it to my map:ogre_haosis:

well.... youtube tutorial would be the best with a person talking (hate tutorials with musicXD) but anything works as long i get help plzz im a newbie in needXD



thanks from Owningpanda:ogre_hurrhurr::ogre_hurrhurr:


btw this ended up where i dident want it and dont have time to delete and make a new one so im just gonna send a link to what i mean(= http://www.hiveworkshop.com/forums/...ve-load-event-133727/index21.html#post1882998
 
Last edited:
Level 2
Joined
Jun 13, 2010
Messages
11
Sorry bother you again... but can you detail how i do it?... i'm really don't know how to use vJass very well!

thanks!
 
Level 2
Joined
Jun 13, 2010
Messages
11
i use circle selection... wisp come in and give hero.
if you suggest any other way to do the hero selection to work better with yout code...
ty
 
Level 6
Joined
May 20, 2010
Messages
274
oh so in that case...if i want to dual wield...its either i make it two-handed with two weapon attachments or make another offhand type weapon with a weapon instead of shield attachment am i right?
and another question..why does it make me unequip all my items if i type anything with a - on the start??
thanks btw
 
and another question..why does it make me unequip all my items if i type anything with a - on the start??
thanks btw

just read the text displayed when you start the map ;)

whenever you type a chat message the system thinks its a save/load code and your string would be invalid;)

this is just a feature in this test map!
 
Level 4
Joined
Nov 20, 2006
Messages
70
It seems to be working, but when a unit is initialized i get these messages in War3:

Unable to allocate id for an object of type: Equipment

Attempt to destroy a null struct of type: Equipment


Edit:

I realized those were because of having "debug mode" turned on in JNGP, but I am still not sure if they should be there.


Edit Again:

I am now using spellbooks for the ability items, but I'm wondering why this wasn't the way it was done in the first place. Is there anything wrong with it?

The documentation is confusing sometimes and could use a lot of cleaning up, look at the difference in spelling here:
Code:
[b][u]EnableItemEquip[/b][/u] takes player p, integer id, boolean flag returns nothing
  with this function, you can disable/enable the equipping of a special item
  
  Example:
    call [b][u]EnableEquipment[/b][/u](Player(0), 'I001', false)
    => Player 1 cant equip the item 'I001' anymore, until it gets enabled again
It was very confusing having the example using a different function name than the instruction.
 
Last edited:
Level 4
Joined
Nov 20, 2006
Messages
70
Read my post.

I am not asking him to make the system in a spellbook, or change anything about it for spellbooks. I am only saying that rather than adding multiple abilities in the jass, you could set them in a spellbook, and then just add the spellbook ability in the jass.
 
Level 4
Joined
Nov 20, 2006
Messages
70
Oh OK. Well, I wasn't asking what is wrong with him making the system work via spellbooks, just what would be wrong with doing it as I described in my last post.
 
I think they have a common ground as its for the same system idea (lines two and three is basically a general answer for why you don't use SB for this)... ^_^

for me, I don't like SBs that much... haha... and I also believe with what he said that using SBs for this is highly less efficient than the method he currently uses...
 
Level 1
Joined
Jan 28, 2011
Messages
3
maybe you hit the thread limit of wc3... you need to place those inits on another trigger which runs after map init...
yea I probably did hit the limit, but I still don't know how to add another init trigger. I mean I tried but failed numerous attempts. Can you please tell me how to if possible?
 
Level 3
Joined
Oct 14, 2009
Messages
40
uh is it too late for me to post this comment?

how can you make this MPI (well the map said it is MPI, but i dont know how to initialize the trigger for each player)? any suggestions?
 
uh is it too late for me to post this comment?

how can you make this MPI (well the map said it is MPI, but i dont know how to initialize the trigger for each player)? any suggestions?

It's MPI cause you can have 1 inventory per player! so just add an inventory to another unit owned by another player and youre done!
 
Level 5
Joined
Jul 17, 2010
Messages
140
I dont understand why dont somebody just make the map multiplayer.. so its done and you can just copy the most without have to figur out how to make it multiplayer, would be much easiere for people..:S
 
Level 2
Joined
Oct 18, 2011
Messages
10
Hey, great system Witcher, thank you for uploading it! I've uploaded this system fine into an RPG I'm working on, however I'm curious as to how I should transfer the character and the equipment he has on into the next level of a campaign.

So far all I've done is save the hero and the inventory dummy into a game cache, and attempt to load them in the next level but when I load up the next level neither the hero nor the inventory dummy spawn. The maps share the exact same trigger and object data except for save/load triggers. I'm a total newb at Jass, but not unwilling to learn or to go through and fix things line by line if needed. Any insight into how to resolve this would be appreciated. Thanks.:thumbs_up:
 
you need to save the indexes (or the item rawcodes) of the items equipped, there are functions in the system to obtain them(that's how I save them into the game cache on the map I'm working on)... then use the force equip functions to equip them afterwards in the next map

as for the hero, if its not loading, then you've done something wrong... be sure that you create/load exactly the same game cache, and make sure that the keys are correct...
 
Hey, great system Witcher, thank you for uploading it! I've uploaded this system fine into an RPG I'm working on, however I'm curious as to how I should transfer the character and the equipment he has on into the next level of a campaign.

So far all I've done is save the hero and the inventory dummy into a game cache, and attempt to load them in the next level but when I load up the next level neither the hero nor the inventory dummy spawn. The maps share the exact same trigger and object data except for save/load triggers. I'm a total newb at Jass, but not unwilling to learn or to go through and fix things line by line if needed. Any insight into how to resolve this would be appreciated. Thanks.:thumbs_up:
another possible method to saving the systems internal codes is using my implemented save load code generator:
save the load code in the game cache and then in the next map force loading the code ;)
 
Level 2
Joined
Oct 18, 2011
Messages
10
Hmm I'm trying to figure out how to take a generated string (like the one generated in the SaveEquipment function) and save it into a game cache, but I'm not EXACTLY sure what I'm supposed to do. The only method I can think of would be to type out the LoadCode manually and save that as a variable into the game cache, but I'd like to avoid any retyping of it if possible. Is there a way to directly take the load code directly and save it as a string into the game cache? Thanks.
 
Level 2
Joined
Oct 18, 2011
Messages
10
Errr yeah sorry about my noobish comment above, didn't think to just save it in a game cache in that function.

However I still have another embarrassing question: How can I force the load code to work in the next map? I haven't really found a suitable method for this, I'd appreciate it if someone could just either come with some code for this or send me a tutorial explaining how to do this kind of stuff. Sorry for the trouble.
 
Don't double post please...

If the load code is saved as a string on the game cache:

JASS:
call LoadEquipment(player p, GetStoredString(gamecache cache, string missionKey, string key))
/*
player p is the player

cache is the gamecache that ur using
missionkey is the category (in GUI GC)
key is the label (in GUI GC)
*/

but be sure that you initialize first which hero is to use the system...
 
Level 2
Joined
Oct 18, 2011
Messages
10
Sorry about the double post >.<
Also, thanks for the quick reply, you're a life-saver Adiktuz!

I think I should read up more on the tutorials for Jass here... I think my using this system is like trying to run a marathon after just learning to crawl.
+rep :thumbs_up:
 
Level 2
Joined
Oct 18, 2011
Messages
10
Gah! Still having trouble! The love between me and technology is so one-sided. :vw_sad:

So yeah the issue I'm having still is reloading the equipment code from the last map. I'm thinking it may have something to do with how I saved the game cache, here's what it looks like:

JASS:
function SaveEquipment takes player p returns string
        local integer i = 0
        local string s = ""
        loop
            set i = i + 1
            if Equipment.Item[i].id != MAX_ITEMS then
                set s = s + I2S(Equipment.Item[i].id - 'I000')
            endif
            set s = s + "x"
            exitwhen i >= classes
        endloop
        return s
        call StoreString  (udg_RPGTest, "Stuff", "Gear", s)
        return s
    endfunction

Unless I'm mistaken, I believe the value "s" it's saving in the game cache is the same s value that is established just earlier in the code (the equipment loadcode). I only came up with the Stuff and Gear handles in order to save the string into the cache as I didn't know what else to use.

It seems to compile fine in JNGP and the map runs fine in game, the problem arises when I try to reload it in the next map.

And here's the trigger (custom script in GUI) I used in the next map to restore the equipment:

  • Custom script: call LoadEquipment(player p, GetStoredString(udg_RPGTest, Stuff, Gear))
When I try to save this in JNGP I get syntax errors, and when I try to edit it I get more syntax and/or struct errors. I'm thinking the problem has something to do with the fact that the game when it reloads the map and runs this trigger it isn't sure what the "Stuff" and "Gear" values are and hence it will crash. Am I going about this the right way? The only thing I'm sure about is that I am doing something wrong lol.

Also@ Adkituz,

I remember you mentioned you were using this system for your own map. I was wondering if I could see what you used to get the save/load codes into a game cache and have it work between maps (I'm assuming that's what you meant earlier).

Thanks all.
 
Okay guys it has been a while but i'm back with a new update ;)

Thanks for all your support and for making this system the highest rated equipment system here on THW!


Update v.4.0:
- Reduced Abilities per item to 20 because of jass limitations
- fixed a bug for multiplayer usage preventing a second player from using the system
- fixed an animation bug where the shield animation didn't disappear

 
Top