MoveSpeedX for GUI v1.1.0.0

[PurgeandFire]

Hi @PurgeandFire , thanks for this system, it's really useful for my map. But I have a few questions:

• is this running at 0.03 seconds all the time? Or only when you call the function "SetUnitMoveSpeedX"?
• If not: Does it recongize to automatically turn off as soon as no unit is above 522 speed?

This timer is running all the time. I should've optimized it to only run when needed, but it looks like I didn't. Sorry.

 

[Ugabunda]

No worries, but are you still actively working on this or not?
Just to understand if I rather wait for an update or try to add some adjustments myself (in GUI, since that's all I know).

 

[Daffa]

Apparently, removed units are mot accounted properly.

Remove Unit issue with MoveSpeedX v1.1.0.0

 

[Beckx]

Hey guys vJASS wasnt solution for me since my map runs on Lua, so i've implemented Lua version of this feature, logic is pretty much the same, there are only few differences, i am usin Trigger instead of Timer on periodic event, trigger is enabled only when needed, for some reason in original version it ran all the time, and i've hooked both natives SetUnitMoveSpeed and GetUnitMoveSpeed as well, thats probably even better for GUI creators. + Obvsly u dont need any extensions like Unit Indexer ect for usage anymore , indexing is handled by native GetHandleIdBJ()

----------------------------------------------------
---------------MOVESPEED SYSTEM SETUP---------------
----------------------------------------------------
do
    local function tableLength(t)
        local count = 0
        if t then
            for _ in pairs(t) do count = count + 1 end
        end
        return count
    end

    local MSX_PERIOD = 0.00625
    local MSX_MARGIN = 0.01

    local function ApproxEqual (A,B)
        return (A >= (B - MSX_MARGIN)) and (A <= (B + MSX_MARGIN))
    end

    local MOVESPEED_X_TABLE = {}
    local MOVESPEED_X_ISSUED_TRIGGER = CreateTrigger()
    local MOVESPEED_X_TRIGGER = CreateTrigger()
    local oldGetUnitMS = GetUnitMoveSpeed
    local oldSetUnitMS = SetUnitMoveSpeed

    local function MSX_Periodic()
        local u,order,d,dy,dx,ny,nx = nil,nil,nil,nil,nil,nil,nil
        for i,t in pairs(MOVESPEED_X_TABLE) do
            u = t.unit
            nx = GetUnitX(u)
            ny = GetUnitY(u)
            if not(IsUnitAliveBJ(u)) or GetUnitTypeId(u) == 0 then
                MOVESPEED_X_TABLE[i] = nil
            elseif not(ApproxEqual(nx, t.x)) or not(ApproxEqual(ny, t.y)) then
                if not(IsUnitPaused(u)) then
                    order = GetUnitCurrentOrder(u)
                    dx = nx - t.x
                    dy = ny - t.y
                    d  = SquareRoot(dx * dx + dy * dy)
                    dx = dx / d * t.speed
                    dy = dy / d * t.speed
                    if (order == 851986 or order == 851971) and (t.ox - nx)*(t.ox - nx) < (dx*dx) and (t.oy - ny)*(t.oy - ny) < (dy*dy) then
                        SetUnitX(u, t.ox)
                        SetUnitY(u, t.oy)
                        t.x = t.ox
                        t.y = t.oy
                        IssueImmediateOrderById(u, 851972)
                    else
                        t.x = nx + dx
                        t.y = ny + dy
                        SetUnitX(u, t.x)
                        SetUnitY(u, t.y)
                    end
                end
            end
        end
        if tableLength(MOVESPEED_X_TABLE) == 0 then
            DisableTrigger(MOVESPEED_X_TRIGGER)
        end
    end

    local function MSX_storeOrderPoint()
        local u_id = GetHandleIdBJ(GetTriggerUnit())
        if MOVESPEED_X_TABLE[u_id] then
            MOVESPEED_X_TABLE[u_id].ox = GetOrderPointX()
            MOVESPEED_X_TABLE[u_id].oy = GetOrderPointY()
        end
    end

    local function MSX_Create (whichUnit,newSpeed)
        local u_id = GetHandleIdBJ(whichUnit)
        MOVESPEED_X_TABLE[u_id] = MOVESPEED_X_TABLE[u_id] or {
            unit = whichUnit
            ,x = GetUnitX(whichUnit)
            ,y = GetUnitY(whichUnit)
        }
        MOVESPEED_X_TABLE[u_id].speed = (newSpeed - 522) * MSX_PERIOD
        if not(IsTriggerEnabled(MOVESPEED_X_TRIGGER)) then
            EnableTrigger(MOVESPEED_X_TRIGGER)
        end
    end

    local function MSX_Update (whichUnit,newSpeed)
        local u_id = GetHandleIdBJ(whichUnit)
        if newSpeed > 522 then
            MSX_Create(whichUnit,newSpeed)
        else
            MOVESPEED_X_TABLE[u_id] = nil
        end
    end

    function GetUnitMoveSpeed(whichUnit)
        local u_id = GetHandleIdBJ(whichUnit)
        if MOVESPEED_X_TABLE[u_id] then
            return (MOVESPEED_X_TABLE[u_id].speed / MSX_PERIOD) + 522
        end
        return oldGetUnitMS(whichUnit)
    end

    function SetUnitMoveSpeed(whichUnit,newSpeed)
        oldSetUnitMS(whichUnit, newSpeed)
        MSX_Update(whichUnit, newSpeed)
    end

    local oldInit = InitBlizzard
    function InitBlizzard()
        oldInit()

        TriggerRegisterTimerEventPeriodic(MOVESPEED_X_TRIGGER, MSX_PERIOD)
        TriggerAddAction(MOVESPEED_X_TRIGGER, MSX_Periodic)
        TriggerRegisterAnyUnitEventBJ(MOVESPEED_X_ISSUED_TRIGGER, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER)
        TriggerAddAction(MOVESPEED_X_ISSUED_TRIGGER, MSX_storeOrderPoint)
    end
end

More info HERE

 

[Bribe]

Hey guys vJASS wasnt solution for me since my map runs on Lua, so i've implemented Lua version of this feature, logic is pretty much the same, there are only few differences, i am usin Trigger instead of Timer on periodic event, trigger is enabled only when needed, for some reason in original version it ran all the time, and i've hooked both natives SetUnitMoveSpeed and GetUnitMoveSpeed as well, thats probably even better for GUI creators. + Obvsly u dont need any extensions like Unit Indexer ect for usage anymore , indexing is handled by native GetHandleIdBJ()

----------------------------------------------------
---------------MOVESPEED SYSTEM SETUP---------------
----------------------------------------------------

function tableLength(t)
    local count = 0
    if t then
        for _ in pairs(t) do count = count + 1 end
    end
    return count
end

MSX_PERIOD = 0.00625
MSX_MARGIN = 0.01

function ApproxEqual (A,B)
    return (A >= (B - MSX_MARGIN)) and (A <= (B + MSX_MARGIN))
end

MOVESPEED_X_TABLE = {}
MOVESPEED_X_ISSUED_TRIGGER = CreateTrigger()
MOVESPEED_X_TRIGGER = CreateTrigger()

function MSX_Initialize()
    TriggerRegisterTimerEventPeriodic(MOVESPEED_X_TRIGGER, MSX_PERIOD)
    TriggerAddAction(MOVESPEED_X_TRIGGER, MSX_Periodic)
    TriggerRegisterAnyUnitEventBJ(MOVESPEED_X_ISSUED_TRIGGER, EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER)
    TriggerAddAction(MOVESPEED_X_ISSUED_TRIGGER, MSX_storeOrderPoint)
end

function MSX_Periodic()
    local u,order,d,dy,dx,ny,nx = nil,nil,nil,nil,nil,nil,nil
    for i,t in pairs(MOVESPEED_X_TABLE) do
        u = t.unit
        nx = GetUnitX(u)
        ny = GetUnitY(u)
        if not(IsUnitAliveBJ(u)) or GetUnitTypeId(u) == 0 then
            MOVESPEED_X_TABLE[i] = nil
        elseif not(ApproxEqual(nx, t.x)) or not(ApproxEqual(ny, t.y)) then
            if not(IsUnitPaused(u)) then
                order = GetUnitCurrentOrder(u)
                dx = nx - t.x
                dy = ny - t.y
                d  = SquareRoot(dx * dx + dy * dy)
                dx = dx / d * t.speed
                dy = dy / d * t.speed
                if (order == 851986 or order == 851971) and (t.ox - nx)*(t.ox - nx) < (dx*dx) and (t.oy - ny)*(t.oy - ny) < (dy*dy) then
                    SetUnitX(u, t.ox)
                    SetUnitY(u, t.oy)
                    t.x = t.ox
                    t.y = t.oy
                    IssueImmediateOrderById(u, 851972)
                else
                    t.x = nx + dx
                    t.y = ny + dy
                    SetUnitX(u, t.x)
                    SetUnitY(u, t.y)
                end
            end
        end
    end
    if tableLength(MOVESPEED_X_TABLE) == 0 then
        if IsTriggerEnabled(MOVESPEED_X_TRIGGER) then
            DisableTrigger(MOVESPEED_X_TRIGGER)
        end
    end
end

function MSX_storeOrderPoint()
    local u_id = GetHandleIdBJ(GetTriggerUnit())
    if MOVESPEED_X_TABLE[u_id] then
        MOVESPEED_X_TABLE[u_id].ox = GetOrderPointX()
        MOVESPEED_X_TABLE[u_id].oy = GetOrderPointY()
    end
end

function MSX_Create (whichUnit,newSpeed)
    local u_id = GetHandleIdBJ(whichUnit)
    MOVESPEED_X_TABLE[u_id] = MOVESPEED_X_TABLE[u_id] or {
        unit = whichUnit
        ,x = GetUnitX(whichUnit)
        ,y = GetUnitY(whichUnit)
    }
    MOVESPEED_X_TABLE[u_id].speed = (newSpeed - 522) * MSX_PERIOD
    if not(IsTriggerEnabled(MOVESPEED_X_TRIGGER)) then
        EnableTrigger(MOVESPEED_X_TRIGGER)
    end
end

function MSX_Update (whichUnit,newSpeed)
    local u_id = GetHandleIdBJ(whichUnit)
    if newSpeed > 522 then
        MSX_Create(whichUnit,newSpeed)
    else
        MOVESPEED_X_TABLE[u_id] = nil
    end
end

oldGetUnitMS = GetUnitMoveSpeed

function GetUnitMoveSpeed(whichUnit)
    local u_id = GetHandleIdBJ(whichUnit)
    if MOVESPEED_X_TABLE[u_id] then
        return (MOVESPEED_X_TABLE[u_id].speed / MSX_PERIOD) + 522
    end
    return oldGetUnitMS(whichUnit)
end

oldSetUnitMS = SetUnitMoveSpeed

function SetUnitMoveSpeed(whichUnit,newSpeed)
    oldSetUnitMS(whichUnit, newSpeed)
    MSX_Update(whichUnit, newSpeed)
end

That's a great inclusion! Lua hooks are one of the main reasons I found Lua to be so useful and innovative. You don't realize just how limited JASS is until you realize how much more user-friendly Lua is.

 

[Beckx]

That's a great inclusion! Lua hooks are one of the main reasons I found Lua to be so useful and innovative. You don't realize just how limited JASS is until you realize how much more user-friendly Lua is.

Yeah its so powerfull, but "simple" at the same time

 

[Rasamayu]

T for the system bro

 

[InSaNe_97]

It is good. For Me.

 

[KitsuneTailsPrower]

I've done many tests with MoveSpeedX and found a way to make higher speeds more stable. With the attached test map I got 5 * 522 (5 times the normal max speed) to work reasonably well using a period of 0.02. It probably can go lower safely. The trick is to re-issue the order to the unit every so often so it re-calculates the way points. Also having a higher turn rate and/or air pathing helps a lot. Attached is a test map with my optimizations. Sonic's model is from here: Sonic - Chaos Realm