[Trigger] Move to "positions of Unit"

[Blacksorcerer]

Hi

does the "move unit to position of unit" action cause leak (positions of units)
and if it does with what script can i remove the positions?
I tried "call RemoveLocation( udg_TempPoint[GetForLoopIndexA()]"
TempPoint is an Array with the positions of the units inside. But i alway get compilation error "name required"

would be nice if so could help me, thanks in advance

 

[paskovich]

Firsty, did you create the TempPoint variable?
Secondly, you are missing a ")" from the end of the line:

call RemoveLocation( udg_TempPoint[GetForLoopIndexA()] )

 

[V_V_V]

msg removed because of inaccuracy.

 

[PurplePoot]

If you overwrite the location with another, V_V_V, it will retain the first one, but have no reference to it, thus it will leak.

 

[CoolSoFar]

What kind of leak you mean?

I also do
"move unit to position of unit offset by x,y"
or
"move unit to position of unit offset by z from facing point of unit"

what's wrong with these trigger? Is it not enough devastating for you?

 

[HappyTauren]

Anything that involves LOCATION or, "POSITION" leaks! even if you set it a variable it will leak if you dont deledte it. (call RemoveLocation(URVAR))

 

[PurplePoot]

Same with groups and DestroyGroup.

(and that's all thats really worth mentioning to a GUIer)

 

[paskovich]

Now that Doc is a mod here, he could make a "leak-elimination" tutorial sticky. So, will ya?

 

[Dr Super Good]

I may one day but currently there are a lot of them already.

I would like to remind everyone that this is the "Triggers (GUI)" section so please refraim for talking in jass unless you clearly say "insert this in the custom script action" or anything along thoes lines since pure jass belongs in the "Triggers (JASS)" section.

A location (point in GUI) will leak unless your remove it since a location is a piece of infomation with a XYZ cordinates tied together under one heading. Same goes for Groups except they are a list of units tied together under one heading. In GUI if you fail to destroy/remove a group/location and you overwright the variable with it, it has leaked since no matter what you do you can not retreive it again to remove it.

 

[Blacksorcerer]

Ok i think my question's answered, thanks to all.

 

[V_V_V]

*coughcough*:emote_innocent: :emote_innocent: :emote_innocent: *coughcough* You saw nothing here....:emote_innocent: :emote_innocent:

and just to prove that, i will do an experiment. 30 locations per sec until leak count = 20k, ran three times: one with no use of variables, one with locations stored in global var before calling for them. last one with global var + removelocation (20k potential leaks should be more than enough to able to make a significant impact)

Edit: Yea I just proved myself wrong :emote_mad: COMPLETELY forget what i said if you actually read my post. :emote_innocent:

(just for the info after running 50k of location leaks
- increased mem usage of normal leak ~ 18k,
- global leak ~ 18k (lol its identical, ill shut up now.)
- RemoveLocation ~ 3k

*note: i felt no leak symptoms cuz im running on 2gb of ram so increased mem usage was my method of measurement. I was planning on measuring "black screen of death" duration but to my suprise got none =O

But now i dont get it. Why did changing from leak to temp global use fix my leak problem? =?=? I assure you that my map once had massive leaking. Now i switched to temp globals no apparent leak symptoms can be seen...(that was both back when i was on 1gb of ram)

 

[HappyTauren]

no, why would blizzard use removeLocation if that doesnt leak

 

[Dr Super Good]

Vexorian said that local handles leak if you do not null them at the end of the function. Globals do not make that type of leak since they always exist. Globals can leak if you give them an object and then give them a new object without destroying the last object but then it is not really the global leaking but an object (handle) leaking.

 

[V_V_V]

I see... well i learned something today. thx Doc :emote_laugh: