MAP LEAKS LIKE HELL, UNPLAYABLE

[KNEZ95]

Hello fellow fans of World Editor, I recently made a map and I spent over 20 hours in desperate attempts to fix the problem I get. The map is still not completed and it is early Alpha/Beta version but the problem about it is that when I turn AI to play, no matter if there is 1,2 or 11 AI players the map starts to lag like hell and just freeze the screen. For faster testing I used "warpten" and "greedisgood 999999" cheat codes so AI starts developing much faster and make more units. Please I never asked for help with Threads before this, this is my first time in life, I am actively using World Editor for over 5 or more years and I never get in this much trouble. I already saw problems with leaks and I know how to fix them, I checked every trigger for leaks and I could not find any. I think there is some other problem that goes over my reach. Any help will be precious. Thanks in advance!

Important elements of the map.

Map size: Epiz (Full size: 256x256/ Playeble size: 244x244)
Player allowed in map: 12
Doodads count: Around 6000 (It is not above the limit)
Triggers count: 57 active triggers and couple of more inactive triggers made just for testing and fun
Maximum food production per player: 200 (double then normal maps use)

If needed I can show pictures triggers and other stuff from inside the map, I can do Skype call to connect with someone who know how to fix this. The map will be uploaded here so you can test it yourself.

 

[DaneTheBeast]

Umm does it open for you fine?

 

[Marcos_M]

View attachment 291463
Umm does it open for you fine?

Same here, did you erase the .wtg archive?

 

[KNEZ95]

View attachment 291463
Umm does it open for you fine?

The map is secured by me so other people wont open it, I did it the old way you can test it by playing it and see yourself what I am talking about

 

[Marcos_M]

okey, so you need help in your triggering, but we have to decipher what the hell is happening while playing???

You're asking us to get X in the equation, but the equation also has Y,Z,T,V as unknowns too

 

[KNEZ95]

okey, so you need help in your triggering, but we have to decipher what the hell is happening while playing???

You're asking us to get X in the equation, but the equation also has Y,Z,T,V as unknowns too

I think that there is no leaking triggers in that map, I can send you the triggers that might leak, but I truly believe the problem must be in some other aspect.

 

[DaneTheBeast]

With only gameplay, there's almost NO chance to fix the leak/ai problem... if you want send the map to someone's PMs, and they can look at it

 

[KNEZ95]

With only gameplay, there's almost NO chance to fix the leak/ai problem... if you want send the map to someone's PMs, and they can look at it

Yes I would like to fix this, do you think you can fix this? I can send it to you lets do a personal messaging?

 

[DaneTheBeast]

I never touched AI, so I doubt I can fix the problem, maybe someone else could do better @Marcos_M how about you?

 

[Dr Super Good]

AI will periodically lag (frame drops) if they have a base on a pathing island from their foes.

 

[KNEZ95]

AI will periodically lag (frame drops) if they have a base on a pathing island from their foes.

Hmm, meaning if there is no rivers that separate the map on 3 big islands it should stop the lag?

 

[Dr Super Good]

It means that if the map is an island map you will get a lot of lag. Only solution is to put bridges between all pathing islands so the AI can walk where ever it wants. Waygates might also work and make more sense on islands.

 

[KNEZ95]

It means that if the map is an island map you will get a lot of lag. Only solution is to put bridges between all pathing islands so the AI can walk where ever it wants. Waygates might also work and make more sense on islands.

But I have bridges connecting the islands and couple of waygates already in the map, as I see there is no solution and the map is completely broken

 

[Dr Super Good]

Well I am just giving out general advice, not like I even tried the map.

Another cause of AI performance problems is if an AI base is too small. It will try to build buildings but as it has no space to the routine to find a construction place will take a long time to complete and hence cause frames to be dropped.

If you want any more, you will have to provide an editable version of the map. Do you honestly expect us to read the JASS scripts directly and find the problems?

 

[KNEZ95]

Well I am just giving out general advice, not like I even tried the map.

Another cause of AI performance problems is if an AI base is too small. It will try to build buildings but as it has no space to the routine to find a construction place will take a long time to complete and hence cause frames to be dropped.

If you want any more, you will have to provide an editable version of the map. Do you honestly expect us to read the JASS scripts directly and find the problems?

Yes, I saw AI trying to build base but got no space for it, maybe that is the problem, as my map is big a lot i will need some time to change every starting position (there is 30 of them) and tomorrow will test it and post the results here, if that fix do not work then I will get in contact with you if you agree and give you the editable version of the map, we can use Skype/Facebook/Discord or personal message here on this site. If you agree?

 

[KNEZ95]

Well I am just giving out general advice, not like I even tried the map.

Another cause of AI performance problems is if an AI base is too small. It will try to build buildings but as it has no space to the routine to find a construction place will take a long time to complete and hence cause frames to be dropped.

If you want any more, you will have to provide an editable version of the map. Do you honestly expect us to read the JASS scripts directly and find the problems?

I made every starting base much bigger and it seems that it is reducing the lag a lot, the map is now playable but still lags a bit, ether the AI still miss some space to build or there is some other thing making them lag, is there anything more I should change?

Also big thanks to you my brother you just saved me!

 

[Dr Super Good]

How big is the map (dimensions)? I recall some people saying that on massive maps, like 480*480, the AI path finding/route finding becomes very demanding and can cause frame drops when deciding where to move.

 

[KNEZ95]

How big is the map (dimensions)? I recall some people saying that on massive maps, like 480*480, the AI path finding/route finding becomes very demanding and can cause frame drops when deciding where to move.

Map size: Epiz (Full size: 256x256/ Playeble size: 244x244)
Player allowed in map: 12
Doodads count: Around 6000 (It is not above the limit)
Triggers count: 57 active triggers and couple of more inactive triggers made just for testing and fun
Maximum food production per player: 200 (double then normal maps use)

 

[Dr Super Good]

Of those 57 are any prone to firing a lot? Any leaks in such triggers could degrade performance as time progresses.

 

[KNEZ95]

Of those 57 are any prone to firing a lot? Any leaks in such triggers could degrade performance as time progresses.

I am sure that there is no triggers that leaks, and for now there is no triggers that use "every x second of game"

 

[Dr Super Good]

Try putting the map through Jass Checker. This might flag up some leaks.

 

[KNEZ95]

Try putting the map through Jass Checker. This might flag up some leaks.

I will do it my brother, thank you a lot

This is what I get from it: Gyazo - 24b2097f98fa7bade7794474766469e3.png

And this is the triggers

Gyazo - ba7675db4f7c17dbbe9347e98b90ec07.png

And this one

Gyazo - 5f8d0a94bb40785ab99d8fe7a16a66ca.png

About last one I understand what mistake I made I will fix it right now

 

[Dr Super Good]

The weather trigger clealy does not do what you want. The event period is defined at map initialization.

The second one you forgot to use the group so leak another one.

 

[KNEZ95]

The weather trigger clealy does not do what you want. The event period is defined at map initialization.

The second one you forgot to use the group so leak another one.

The second one I fixed but about the weather trigger it does what it is supposed to do, but it leaks, and I got no idea on how to fix it?

 

[Dr Super Good]

it does what it is supposed to do

Which is?
What you probably meant...

Every 121 to 180 seconds do...

What it actually is doing...

At map initialization: X = Resolve a random real between 121 to 180
Every X seconds do...

This is a fairly common mistake people make as they do not realise that the arguments passed to event constructors are resolved only once at map initialization. The correct solution is to use a timer which is started at map initialization and get the trigger itself to restart the timer to a timeout between 121 and 180 as part of its actions, meaning the period between weather changes is random rather than the frequency between weather changes.

It probably is not leaking a weather effect. Just to be safe assign the weather effect to a global variable and destroy that before creating new weather effects.

With that your map is most likely leak free.

 

[KNEZ95]

Which is?
What you probably meant...

What it actually is doing...

This is a fairly common mistake people make as they do not realise that the arguments passed to event constructors are resolved only once at map initialization. The correct solution is to use a timer which is started at map initialization and get the trigger itself to restart the timer to a timeout between 121 and 180 as part of its actions, meaning the period between weather changes is random rather than the frequency between weather changes.

It probably is not leaking a weather effect. Just to be safe assign the weather effect to a global variable and destroy that before creating new weather effects.

With that your map is most likely leak free.

Thank you on your advices my friend you saved me, now is 3:54 AM so my brain is all out of power, I will work out on this tomorrow I really need to take a break. Thank you a lot my brother, if you wish I can add you on some social media or Skype/Discord just to have you in my friend list.