[Manasurge] Manastorm 1.7

[Moderator]

Manastorm 1.7 | Reviewed by Maker | 12th Oct 2013

APPROVED

Goodlooking, leakless and MUI spell Use variables for abilities You could create only one dummy, and make it cast Purge on all targets

[tr]

Old reviews Bribe Set WS_Force = (All players matching ((Triggering player) Equal to (Matching player))) -> There is a "Convert Player to Player Group" function which could simplify this to just use (Player Group((Triggering player))) instead. The rest looks good! This should see an approval once I give it a test run. Maker, v1.6: The unit dies trigger should be turned off when there are no dummies alive.

 

[Manasurge]

Info

Im away for the weekend and won't be able to read or response to any comments until Monday!

Also if you find anything bothering you pm me aswell.

For the love of god RATE!!!
>.<
Edit 2011-05-03:
Yeay 200 Downloads and 0 rates >.>

 

[Marcos DAB]

Triggers seems fine, but not leakless.
Try to clear Child Hashtables on loop.

 

[Narogog]

Cool spell, but you need to
get rid of the point array, Ws_point and create 3 point vars. arrays use a lot more memory then a none arrayed vars.

and remove this and the other one

• Special Effect - Create a special effect at (Position of (Picked unit)) using Units\Undead\Abomination\AbominationExplosion.md

it leaks and is repeated for every unit in range. use a point and then clear it in the loop.
using

• Custom script: call RemoveLocation(udg_Point_Var)

Keep up the Good work!

Edit: it might be a good idea to set picked unit to a var, to reduce memory consumed.

 

[Magtheridon96]

You have WAAAAAAY too many BJs (Don't report this post! It's a real thing ! --
You'll know what it is when you start learning JASS .. Or I can tell you now )

A BJ is a function made by Blizzard, but strangely (to the fact that they're a large
corporation), those functions are EXTREMELY SLOW... most of the time

In most cases, you would find a BJ that calls another BJ that calls another BJ
that calls a native. Why not use the native?

BJs are colored Red when you convert GUI to text.

LastCreatedUnit() isn't that bad a BJ (relatively), but you're calling the function
repeatedly.

Just create a new unit variable and set it to bj_lastCreatedUnit in a Custom Script.

It would be something like set wtvr = bj_lastCreatedUnit
Then you can use that variable instead of repeating it.

Same thing goes for the Floating texts. For them, use bj_lastCreatedTextTag

• (Position of (Picked unit))

^leaks

Store it in a variable before you use it, and yes: clearing leaks is very important.

Another thing:

• Lightning - Create a WS_LightningType lightning effect from source WS_Point[1] to target WS_Point[3]

It would look much better if you use Custom Script for this action.
The custom script allows you to give the lightning height so it would have a greater
Awesome-factor

• Unit Group - Remove (Triggering unit) from WS_LightningGroup
• Lightning - Destroy (Load 0 of (Key (Triggering unit)) in WS_Hashtable)
• Hashtable - Clear all child hashtables of child (Key (Triggering unit)) in WS_Hashtable

Store Triggering Unit in a variable because you're repeatedly using it.

EDIT:
-----
One more thing:

• Set WS_Unitgroup = (Units within WS_DamageRange of WS_Point[1] matching ((((Matching unit) belongs to an enemy of WS_Owner) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and (((Matching unit) is ali
  • Unit Group - Pick every unit in WS_Unitgroup and do (Actions)

Use set bj_wantDestroyGroup = true as a custom script right before
the Pick every unit action instead of storing a group, picking it, then destroying it.
It would be faster this way. In the Pick every unit action, you would use the value
of the group desired.

----------
That's all ... for now

 

[bladerdog]

it is about the spells how do you import them??

 

[Magtheridon96]

it is about the spells how do you import them??

You should copy and paste all the object editor data, the imports data, and then all the triggers only for the spell into your map.

 

[Manasurge]

Thanks for the feedback Magtheridon96 and Narogog.

The leaks will be fixed on Monday when i get home to my real computer. Then im off for another week so if you have anything else tell me before Tuesday evening.

Didn't know that position of picked unit leaked

And there's instructions on how to import in the end of Startup trigger.

EDIT: Monday 18th of April UPDATED

 

[mckill2009]

you really dont need this...

Custom script: set udg_lastunit = bj_lastCreatedUnit

"Unit - Make Last Created Unit Explode on death" is fine...

and

"Unit - Order Last Created Unit to Orc Shaman - Purge WS_PickedUnit"

and so on...

 

[Manasurge]

Magtheridon96 said i should fix it and i did it. Don't know enough to question his advise.

 

[mckill2009]

Last Created Unit acted like local variables, just like Triggering Unit...Magtheridon's
advice will work but you're repeating the Last Created Unit thing...

Storing in a variable has it's advantage though, particularly, when you're using Hashtables...

example:

Create 1 Unit footman
set udg_unit = bj_lastCreatedUnit
Create 1 Unit peasant
Add udg_unit to Unit Group (you cant add the footman as Last Created Unit here coz the peasant is the last created unit here)...
and so on...

 

[Narogog]

Last Created Unit acted like local variables, just like Triggering Unit...Magtheridon's
advice will work but you're repeating the Last Created Unit thing..

I think that the last created unit is a function, like getlastcreatedunit() or something like that. So it slows things down but if you use it less then 3 times it won't make a difference. but i am not positive about this. I don't use jass other than a few custom scripts.