Make Road Line for Unit Run Snippet v3

[Antares]

What is the reason you have three identical copies of RoadPoint in your script? As far as I can tell, you are not using any instanceable structs in your script. You could make a Road struct that you create with Road.New() and that has a rect array as a member, holding all the road points. Then you can add a method MyRoad.AddRoadPoint to add new road points to that road.

You are looping over all rects to find the one that the unit entered on the TriggerRegisterEnterRectSimple event. You can save the integer i to a hashtable with the rect as the key and retrieve it much faster that way.

You have hardcoded numbers such as if ORDER.Load(id) == 7 then or integer GREEN = 6 in your code that aren't explained anywhere. The former one should be just the maximum number of rects added to that Road.

And that's really the main issue with your ressource. As a system, it lacks customization options. As a template, it lacks explanations what the various parts are there for, making me believe that anyone who has the ability to understand your code and modify it to their own needs would also be able to write it from scratch. It doesn't help that your english isn't the best. I would advise that you get help doing your descriptions, either translate it with ChatGPT or have a hive member help you out. A bit of whitespace between the various functions would also help to make the code more readable.

Your code has some useful bits in there, but I don't think it's in a state where it can be approved.

Awaiting Update

 

[SunLord]

What is the reason you have three identical copies of RoadPoint in your script? As far as I can tell, you are not using any instanceable structs in your script. You could make a Road struct that you create with Road.New() and that has a rect array as a member, holding all the road points. Then you can add a method MyRoad.AddRoadPoint to add new road points to that road.

You are looping over all rects to find the one that the unit entered on the TriggerRegisterEnterRectSimple event. You can save the integer i to a hashtable with the rect as the key and retrieve it much faster that way.

You have hardcoded numbers such as if ORDER.Load(id) == 7 then or integer GREEN = 6 in your code that aren't explained anywhere. The former one should be just the maximum number of rects added to that Road.

And that's really the main issue with your ressource. As a system, it lacks customization options. As a template, it lacks explanations what the various parts are there for, making me believe that anyone who has the ability to understand your code and modify it to their own needs would also be able to write it from scratch. It doesn't help that your english isn't the best. I would advise that you get help doing your descriptions, either translate it with ChatGPT or have a hive member help you out. A bit of whitespace between the various functions would also help to make the code more readable.

Your code has some useful bits in there, but I don't think it's in a state where it can be approved.

Awaiting Update

Yeah, Thanks for your review, I'll take the time to make it easier to understand and use, and I'll let you know when it's updated

 

[SunLord]

@Antares my code is update to v3, it's look improve to use now !

 

[Antares]

    static method find takes region rg returns integer 
        local integer res = -1 
        local integer n = 0 
        if.i != -1 then 
            loop 
                exitwhen n >.i 
                if rg ==.regions[n].rg then 
                    set res = n 
                    exitwhen true 
                endif 
                set n = n + 1 
            endloop 
        endif 
        return res 
    endmethod

This could be solved much easier by storing the id to the region/rect with a hashtable.

    static method LoadDelay takes integer hid returns integer 
        local integer r = 0 
        set r = LoadInteger(road, hid, Roadline.DELAY) 
        return r 
    endmethod

=>

    static method LoadDelay takes integer hid returns integer 
        return LoadInteger(road, hid, Roadline.DELAY) 
    endmethod

While the code looks better overall, the documentation is still lacking. You're copy&pasting the code to the hiveworkshop page; that doesn't help. I can look up the code in your test map. What I need is a listing of all public functions and how to use them, what the arguments mean etc.

Having an example is necessary, but not enough. You need both examples and a documentation.

I have no idea what's going on in the Custom Road example.