[Trigger] Loop!

[CreatorD3292]

If i use a loop code from 1 to 1000000000. is it cause lag for weak pc?

 

[Daffa]

AFAIR, max operation is up to 8190.
And why did you even need to make that many loop?

 

[CreatorD3292]

It's like this:
Begin Loop
Condition Loop: RunTheTriggerInLoop = 1
Pick a random level creep
If creep have ability A. It's picked. if not, Remove it
Continues until the specific number picked it's change Conditions RunTheTriggerInLoop = 0
if the trigger only run about 1000 time. the number creep is not fulfil the specific yet.

 

[FUJI]

Why not use periodic instead of loop? and use groups.

 

[edo494]

the problem you have is the OP Limit, its because you can only do so many operation before your running "thread" crashes

You can only loop about 25000 times while increasing 1 int variable, if you call functions this number decreases drastically.

As jakeZinc suggested use periodic timer

 

[CreatorD3292]

what is groups for. i has nearly 200 custom creep units :V
U mean every 0.04 sec it will run trigger one time? nah. i make a another trigger that if there is no creep in the room 0.5s. it will kick the hero out and allow to build the item training room.
This problem can solve by change every NORMAL creep race into another race. only custom have CREEP race. ( but this shit that so much time cause every time you change a unit race it's load about 4 -> 5 sec )
Well, the if the loop act 25000 time then the weak pc got lag?

 

[PurgeandFire]

It depends on the action really, but with 25000, most weak-moderate computers will have a short freeze (and chances are you'll hit the op limit unless you are doing something incredibly inexpensive op-wise).

In general, if you have to loop 25k times then you are doing something wrong. If you think that you will have 25k creeps, then just think for a moment how much the number 25,000 really is.

 

[CreatorD3292]

well. then i must change all the normal creep race into other. And, about 1000 time. does it cause a little lag?
I was plan use something like this
For A integer from 1 To X Time
If trigger run right - do nothing
If trigger run wrong - X = X + 1

But it's not working.

 

[Daffa]

Sow us the trigger you want us to help, we will fix it, maybe somebody would even help with a test map.

 

[CreatorD3292]

maybe tomorrow i will upload it.

 

[FUJI]

well. then i must change all the normal creep race into other. And, about 1000 time. does it cause a little lag?
I was plan use something like this
For A integer from 1 To X Time
If trigger run right - do nothing
If trigger run wrong - X = X + 1

But it's not working.

Make a periodic trigger then create a condition boolean inside the trigger. Make this condition If YOUR_TRIGGER is on equal to ( == ) true then Do nothing, else increase the integer by 1.

 

[CreatorD3292]

Okay, It's better than before. but i will need you guys check it when i release the map

 

[deathismyfriend]

You can post the trigger here so we can help you improve it.

 

[CreatorD3292]

it's already solved.

 

[deathismyfriend]

it's already solved.

Yes the problem is solved but I'm betting that the triggers can get improvements.

You should look at my tutorial things a GUIer should know. It can help improve your coding.

 

[CreatorD3292]

ah... what should i say. i solved it by look at your tut! ^^!.

 

[deathismyfriend]

Ok lol. If you want to see if you can improve the code then feel free to post it on here or on my tutorials page and ill help.