[JASS] Illusion Loop Problem

[MaXaRaYkIn]

I need help with:

function Trig_Illusion_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A002'
endfunction

function Trig_Illusion_Actions takes nothing returns nothing
    local unit t = GetSpellTargetUnit()
    local unit c = GetTriggerUnit()
    local integer i = GetUnitTypeId(t)
    local integer l = GetUnitAbilityLevel(c, 'A002' )
    local real x = GetUnitX(t)
    local real y = GetUnitY(t)
    local player p1 = GetOwningPlayer(c)
    local player p2 = GetOwningPlayer(t)
    
    local unit m =  CreateUnit( p1, i, x, y, bj_UNIT_FACING )
    
    call SetUnitColor( m, GetPlayerColor(p2) )
    call UnitAddAbility(m, 'Aloc')
    call UnitApplyTimedLife(m, 'BTLF', I2R(l))
    call SetUnitPathing( m, false )
    call SetUnitVertexColor(m, 100, 100, 100, 50)
    call SetUnitInvulnerable( m, true )
    loop
        call IssueTargetOrder( m, "attack" , t )    
        if GetUnitState( t , UNIT_STATE_LIFE) <= 0 then
            set m = null
        endif
        if GetUnitState( m , UNIT_STATE_LIFE) <= 0 then
            set m = null
        endif
        exitwhen m == null 
    endloop
    
    call RemoveUnit(m)
    set m = null
    set t = null
    set c = null
    set p1 = null
    set p2 = null

endfunction

//===========================================================================
function InitTrig_Illusion takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( t, Condition( function Trig_Illusion_Conditions ) )
    call TriggerAddAction( t, function Trig_Illusion_Actions )
endfunction

The problem is that it never goes into the "IF"s. So it won't leave the loop. And probably this means it leaks...
Anyway, when I cast it, it lags a little and then it works pretty well.

My main problems are:
1. The lag when I cast the spell.
2. The Illusion does not die / disappear if the Target is dead... And that is because it never gets the loop.

I seems that the lag goes away if I replace

        if GetUnitState( m , UNIT_STATE_LIFE) <= 0 then

with

        if GetUnitState( m , UNIT_STATE_LIFE) <= GetUnitState( m ,  UNIT_STATE_MAX_LIFE) then

But this method seems like it doesn't go through the loop at all...
I think I might need timers... But I'm not that good at timers...
If you guys have any idea how to get rid of the lag and get out of the loop please let me know...

 

[Doomlord]

It is really funny but dead units don't exactly have negative life.

Actually, if the unit ever has negative life, Warcraft 3 will attempt to correct the error by adding a HUGE amount of life to it (iirc it is 2147483647). It feels kinda like some kind of insurance policy =P

For your problem, either go with IsUnitType(m, UNIT_TYPE_DEAD) or GetWidgetLife(u) < 0.405.

One more thing, the Remove and nulling of m below is kind unnecessary because the loop exits only when m is null.

edit

Oh and yeah, you will need a timer. Purge's post below clarifies it quite well.

 

[PurgeandFire]

You need timers. Right now, it is freezing because the unit is constantly issued an attack order. Keep in mind that loops don't take breaks (until they hit the op limit), they will continuously call the functions. Now, our computers can handle quite a bit--hundreds of thousands of operations at a time--but an infinite loop will freeze them up.

What you want instead is a timer that will check repeatedly if either of the units are dead. However, before we can help you, you need to give some info:
(1) What is your spell supposed to do?
(2) Do you have Jass NewGen Pack?

 

[MaXaRaYkIn]

~Doomlord~
This is how I thought of it. Since I only use "i" just one I though of getting it in the loop.
But the problem is the same... It lags less now (I think), but the unit still doesn't disappear...

function Trig_Illusion_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A002'
endfunction

function Trig_Illusion_Actions takes nothing returns nothing
    local unit t = GetSpellTargetUnit()
    local unit c = GetTriggerUnit()
    local integer i = GetUnitTypeId(t)
    local integer l = GetUnitAbilityLevel(c, 'A002' )
    local real x = GetUnitX(t)
    local real y = GetUnitY(t)
    local player p1 = GetOwningPlayer(c)
    local player p2 = GetOwningPlayer(t)
    
    local unit m =  CreateUnit( p1, i, x, y, bj_UNIT_FACING )
    
    call SetUnitColor( m, GetPlayerColor(p2) )
    call UnitAddAbility(m, 'Aloc')
    call UnitApplyTimedLife(m, 'BTLF', I2R(l))
    call SetUnitPathing( m, false )
    call SetUnitVertexColor(m, 100, 100, 100, 50)
    call SetUnitInvulnerable( m, true )
    loop
        call IssueTargetOrder( m, "attack" , t )    
        if IsUnitType(t, UNIT_TYPE_DEAD) then
            set i = 2
        endif
        if IsUnitType(m, UNIT_TYPE_DEAD) then
            set i = 2
        endif
        exitwhen i == 2
    endloop
    
    call RemoveUnit(m)
    set t = null
    set c = null
    set p1 = null
    set p2 = null
    set m = null
endfunction

//===========================================================================
function InitTrig_Illusion takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( t, Condition( function Trig_Illusion_Conditions ) )
    call TriggerAddAction( t, function Trig_Illusion_Actions )
endfunction

~PurgeandFire~
1. Create a copy of the target and make the copy attack the target. (kind of Terror Blade's spell, without the slow and -damage; mine does full damage (I know that making the slow and -damage might be harder, but this is a little bit of originality))
2. I think I have it since I'm using NewGen WE.exe. But don't know exactly how to use it properly. (only using the function list)

So? What is the conclusion? Any idea? Will it work?

 

[Doomlord]

~Doomlord~
This is how I thought of it. Since I only use "i" just one I though of getting it in the loop.
But the problem is the same... It lags less now (I think), but the unit still doesn't disappear...

function Trig_Illusion_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A002'
endfunction

function Trig_Illusion_Actions takes nothing returns nothing
    local unit t = GetSpellTargetUnit()
    local unit c = GetTriggerUnit()
    local integer i = GetUnitTypeId(t)
    local integer l = GetUnitAbilityLevel(c, 'A002' )
    local real x = GetUnitX(t)
    local real y = GetUnitY(t)
    local player p1 = GetOwningPlayer(c)
    local player p2 = GetOwningPlayer(t)
    
    local unit m =  CreateUnit( p1, i, x, y, bj_UNIT_FACING )
    
    call SetUnitColor( m, GetPlayerColor(p2) )
    call UnitAddAbility(m, 'Aloc')
    call UnitApplyTimedLife(m, 'BTLF', I2R(l))
    call SetUnitPathing( m, false )
    call SetUnitVertexColor(m, 100, 100, 100, 50)
    call SetUnitInvulnerable( m, true )
    loop
        call IssueTargetOrder( m, "attack" , t )    
        if IsUnitType(t, UNIT_TYPE_DEAD) then
            set i = 2
        endif
        if IsUnitType(m, UNIT_TYPE_DEAD) then
            set i = 2
        endif
        exitwhen i == 2
    endloop
    
    call RemoveUnit(m)
    set t = null
    set c = null
    set p1 = null
    set p2 = null
    set m = null
endfunction

//===========================================================================
function InitTrig_Illusion takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( t, Condition( function Trig_Illusion_Conditions ) )
    call TriggerAddAction( t, function Trig_Illusion_Actions )
endfunction

The loop will not be stopped because i is never 2. You need a timer to overcome this issue.

Here is an example code. It is not indented so please don't follow this style

function TimerCallback takes nothing returns nothing
    local timer t = GetExpiredTimer()

    // Load data here

    if IsUnitType(target, UNIT_TYPE_DEAD) then
        call KillUnit(dummy)

        call PauseTimer(t)
        call DestroyTimer(t)

    endif

    set t = null
endfunction

function Trig_Illusion_Actions takes nothing returns nothing
    // create some locals here
    local timer t = CreateTimer()

    // You pass data to the timer func by a hashtable or another method that you prefer.

    call TimerStart(t, 0.1, true, function TimerCallback)

 

[FUJI]

Anyway, I know how to create that spell . Simply go to OE (Object Editor) then to then Select "Items" find this to the Items named "Wand of Illusions". Then click that item, after that see the abilities of that Item then find that ability to the "Abilities" -->>> "Special" then find that ability. Make sure you create a custom item for Wand of Illusion and custom ability See the screenshots below: (because HARD to explain ^^.)

1st Instruction

2nd Instruction

 

[Malhorne]

What are those empty instructions

 

[MaXaRaYkIn]

~Doomlord~

    // You pass data to the timer func by a hashtable or another method that you prefer.

That is the problem. Don't know how to do that.
I only know that function take something and return something. This is my only way to move this around functions and it seems timers don't take anything (or return)

~jakeZinc~
It might work... But I need the illusion to have Locust, be invulnerable, have 50% transparency and attack the target till one of them dies.

 

[Doomlord]

~Doomlord~

    // You pass data to the timer func by a hashtable or another method that you prefer.

That is the problem. Don't know how to do that.
I only know that function take something and return something. This is my only way to move this around functions and it seems timers don't take anything (or return)

Timer is a type of handle and all handles in Warcraft 3 have something called handle id. A handle id is a unique value that represents the handle itself and we manipulate stuffs using said value as a hashtable key.

I am going to presume that you know how to work with hashtables. Now you will use the handle id of the created timer (get it through GetHandleId(t)) as the parent key. Then we store datas like this (don't forget to initialize the hashtable beforehand with set udg_Hashtable = InitHashtable()). The following example will be saving the dummy and the target.

call SaveUnitHandle(udg_Hashtable, GetHandleId(t), 0, dummy)
call SaveUnitHandle(udg_Hashtable, GetHandleId(t), 1, target)

Then we load it later with the corresponding functions. Once you are done, flush the child hashtable with call FlushChildHashtable(udg_Hashtable, GetHandleId(t)). This will free up space in the hashtable for later usage.

~jakeZinc~
It might work... But I need the illusion to have Locust, be invulnerable, have 50% transparency and attack the target till one of them dies.

I remember there is a way to detect an illusion's creation. You can catch that event, check some conditions and add those properties to the newly created illusion. Search around the forum for it~~

 

[MaXaRaYkIn]

I used hashtables. Once.
Anyway, it seems I don't find any Hashtable or Handle in the function list... Why's that?

Maybe you can help me with the spell by doing it, please? xD
Since I can't do it and you seem to have some experience with JASS.

About the other comment... I still need to remove the unit if the illusion or the target dies.

 

[FUJI]

I remember there is a way to detect when an illusion's creation. You can catch that event, check some conditions and add those properties to the newly created illusion. Search around the forum for it~~

Yes there is a Illusion System made by Robbepop ^^. You can see it below:

Doppelwalk Ability from DotA is the example of this system.
It says "Do anything with your last created illusion", If you want a 50% transparent then do it

call SetUnitVertexColor(m, 100, 100, 100, 50)

I'm hoping it helps for you ^^. Anyway If this helps for you give credit to Robbepop .

Doppelwalk Example

scope Windwalk initializer init

private function condition takes nothing returns boolean
    return GetSpellAbilityId() == 'AOwk'
endfunction

private function main takes nothing returns nothing
    //Create an Illusion
    call CreateIllusion(GetTriggerUnit(), 1., 1., 15.)

    //Do something with your created illusion!
    call SelectUnit(lastCreatedIllusion, true)
endfunction

private function init takes nothing returns nothing
    set gg_trg_test = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(gg_trg_test, EVENT_PLAYER_UNIT_SPELL_FINISH)
    call TriggerAddCondition(gg_trg_test, Condition(function condition))
    call TriggerAddAction(gg_trg_test, function main)
endfunction

endscope

 

[Doomlord]

I used hashtables. Once.
Anyway, it seems I don't find any Hashtable or Handle in the function list... Why's that?

Maybe you can help me with the spell by doing it, please? xD
Since I can't do it and you seem to have some experience with JASS.

About the other comment... I still need to remove the unit if the illusion or the target dies.

If you are using JNGP 1.5d or e, the hashtable functions won't be present in the function list, look around the forum for JNGP 2.0 beta. It is really stable imo

Sorry but I don't really have time to do requests. You should ask someone else, most of them can create it in no time =P

Anyhow,

^Just kidding ^^

 

[MaXaRaYkIn]

~jakeZinc~
Thanks, but I still have the problem with " kill / remove the illusion if one of them dies" ( well if the expiration timer expires, the illusion dies, but if the target dies then the illusion will start to attack nearby enemy units or (if there aren't any) will stay till the timer expires). Creating a illusion is not that hard... I just need to get rid of the illusion at the right time.

~Doomlord~
Ok ,I got JNGP beta ( I think). I can see handles and hashtables, now. But this doesn't change the fact that I can't use them properly.

 

[Malhorne]

Do you have 1.26 war3 ?

This is a moose oh yeah

 

[MaXaRaYkIn]

Yes. It's 1.26a if I remember correctly.

 

[Malhorne]

Last version of JASSHelper ?

 

[MaXaRaYkIn]

Not sure... Downloaded jassnewgenpack204. But I think I do have 0.A.2.B.jasshelper.

 

[Malhorne]

Ok that's the last :/
So i don't understand.
What's exactly the problem ?

 

[MaXaRaYkIn]

I need a spell. Like Terror Blade's.
Creates an illusion of the target and make the illusion attack the target till the timer of the illusion expires or till the target is dead. The first thing works well, but I can't remove the illusion when the target dies.

If anyone is good enough and has time, please make me the spell, if my trigger is wrong... or something...

 

[Malhorne]

You have to check every x second if the target is dead.
And at the end of the timer destroy the checking timer

 

[MaXaRaYkIn]

I know what I have to do...
I just don't know HOW to do it...

 

[Malhorne]

Oh ok sorry x)