[General] loop only running one time

[porker7]

I am trying to tell every barracks owned my a certain player to train a footman / add a new footman to the training queue every two seconds so I created two triggers to work together:
1) Populate the unit group 'enemybarracks' with all of player 21's barracks and then

• set variable enemybarracks
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Picked unit)) Equal to Player 21 (Coal)
            • (Unit-type of (Picked unit)) Equal to Barracks
          • Then - Actions
            • Game - Display to (All players) the text: barracks added to '...
            • Unit Group - Add (Picked unit) to enemybarracks
          • Else - Actions

2) tell each barracks in 'enemybarracks' to train a footmen or add a new footmen to it's training queue every two seconds

• tell all enemybarracks to train footmen every 2 seconds
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in enemybarracks and do (Actions)
      • Loop - Actions
        • Unit - Order (Picked unit) to train/upgrade to a Footman

The second trigger only works one time then it tells just one barracks from the group to train a footman. The trigger does tell every barracks in the unit group to train ONE footman the first time (like it is supposed to do), but then the trigger never correctly fires again. Why does my looped trigger stop working and only tell one unit in the group to train a footman after one iteration?

 

[IcemanBo]

You could print the amount of units shortly on the screen each of those 2 seconds, to see if all units are still inside.

 

[Warseeker]

First of all make sure the player has enough resources and food. Secondly, you are leaking a unit group and the first trigger is pointless since you can do everything inside one trigger.

• Train Footman Loop
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Owner of (Matching unit)) Equal to Player 21 (Coal)) and ((Unit-type of (Matching unit)) Equal to Barracks))) and do (Actions)
      • Loop - Actions
        • Unit - Order (Picked unit) to train/upgrade to a Footman

 

[Deserted]

First of all make sure the player has enough resources and food. Secondly, you are leaking a unit group and the first trigger is pointless since you can do everything inside one trigger.

Having a static group is better than re-creating it every 2 seconds.

 

[porker7]

No, none of those solutions are working, why is that happening and what is leaking?

 

[Deserted]

What happens when

• Game - Display to (All players) the text: (String((Number of units in enemybarracks)))

is added to "

tell all enemybarracks to train footmen every 2 seconds"? Does it print the correct number?

 

[porker7]

I used a timer instead and that solved it