[Trigger] Lightning == BAD (know a fix?)

[Xesirin]

So when I was working on my awesome map, I was considering adding a lightning effect that arcs across the map, and anything that is hit by it takes massive damage.

I can handle the math easily,what my problem relies upon is that fact that lightning seems to cause the game to crash.

Does anybody know what to do to clean up lightning/ handle whatever memory leaks might be formed by such a trigger?

 

[Eccho]

I think this should work, if the question is how to remove the lightning after its used

• Custom Script: call DestroyLightning(udg_YourVariableName)

 

[spiwn]

I doubt not destroying one lightning would crash the game.
And destroying it would also remove it.

 

[Squiggy]

Cleaning up memory leaks -> Lightning - Destroy *your lightning-effect*

That's all

 

[spiwn]

1 memory leak, not 1 at a time, just 1 will not cause the game to crash.
Problem is somewhere else.

 

[Squiggy]

So he shall post the trigger, eh? ^^

 

[GhostWolf]

Most likely you are targeting it out side of the map or something like that.

 

[PurplePoot]

Is it crashing as soon as it is supposed to be created?

If so, a bugged lightning effect could cause that (Texture choice, that is). An invalid choice might crash it too, but I'm not sure about that.

 

[spiwn]

If we are guessing, here is my guess(random):
Giving engineering upgrade based skills to units will crash the game.
My point:
Until he gives us info one guess is as good as another.

 

[Xesirin]

I'll get some code up here in a second.

It's not occuring suddenly, what it's doing is that after the trigger has run, generating god knows how many lightning effects, the game crashes. I tried to catch all teh variables and destroy them, but it doesn't seem to fix the problem.

 

[Xesirin]

Long Post

Alright, here's the code I'm using.

• WARP FIELDS Lightning
  • Events
    • Time - Every 9.00 seconds of game time
  • Conditions
  • Actions
    • -------- The math I'm using is in another trigger and does not cause errors, I have checked. --------
    • Set Loc = (Random point in WARP FIELDS <gen>)
    • Set Loc2 = (Random point in WARP FIELDS <gen>)
    • Lightning - Create a Chain Lightning - Primary lightning effect from source Loc to target Loc2
    • Set WARPLightning = (Last created lightning effect)
    • Wait 1.00 seconds
    • Custom script: call RemoveLocation(udg_Loc)
    • Set Loc = Loc2
    • Set Loc2 = (Random point in WARP FIELDS <gen>)
    • Lightning - Move WARPLightning to source Loc and target Loc2
    • Wait 1.00 seconds
    • Custom script: call RemoveLocation(udg_Loc)
    • Set Loc = Loc2
    • Set Loc2 = (Random point in WARP FIELDS <gen>)
    • Lightning - Move WARPLightning to source Loc and target Loc2
    • Wait 1.00 seconds
    • Custom script: call RemoveLocation(udg_Loc)
    • Set Loc = Loc2
    • Set Loc2 = (Random point in WARP FIELDS <gen>)
    • Lightning - Move WARPLightning to source Loc and target Loc2
    • Wait 1.00 seconds
    • Custom script: call RemoveLocation(udg_Loc)
    • Set Loc = Loc2
    • Set Loc2 = (Random point in WARP FIELDS <gen>)
    • Lightning - Move WARPLightning to source Loc and target Loc2
    • Wait 1.00 seconds
    • Custom script: call RemoveLocation(udg_Loc)
    • Set Loc = Loc2
    • Set Loc2 = (Random point in WARP FIELDS <gen>)
    • Lightning - Move WARPLightning to source Loc and target Loc2
    • Wait 1.00 seconds
    • Custom script: call RemoveLocation(udg_Loc)
    • Set Loc = Loc2
    • Set Loc2 = (Random point in WARP FIELDS <gen>)
    • Lightning - Move WARPLightning to source Loc and target Loc2
    • Wait 1.00 seconds
    • Custom script: call RemoveLocation(udg_Loc)
    • Set Loc = Loc2
    • Set Loc2 = (Random point in WARP FIELDS <gen>)
    • Lightning - Move WARPLightning to source Loc and target Loc2
    • Wait 1.00 seconds
    • Custom script: call RemoveLocation(udg_Loc)
    • Custom script: call RemoveLocation(udg_Loc2)
    • Lightning - Destroy WARPLightning

 

[WILL THE ALMIGHTY]

Are you sure WARP FIELDS doesn't go out of the map limits?

 

[Xesirin]

Warp Fields is within the bounds of the map.

 

[spiwn]

• WARP FIELDS Lightning
  • Events
    • Time - Every 11.00 seconds of game time
  • Conditions
  • Actions
  • Set Loc = (Random point in WARP FIELDS <gen>)
  • Do Multiple ActionsFor each (Integer A) from 1 to 8, do (Actions)
    • Loop - Actions
      • Set Loc2 = (Random point in WARP FIELDS <gen>)
      • Lightning - Create a Chain Lightning - Primary lightning effect from source Loc to target Loc2
      • Set WARPLightning = (Last created lightning effect)
      • Custom script: call RemoveLocation(udg_Loc)
      • Set Loc = Loc2
      • Wait 1.00 seconds
      • Lightning - Destroy WARPLightning
    • Custom script: call RemoveLocation(udg_Loc)

It is more compact this way

 

[PurplePoot]

You don't need to remove udg_Loc2 at the end.

 

[spiwn]

Yeap, you are right
Will edit it
P.s. Must spread.

 

[Xesirin]

You don't need to remove udg_Loc2 at the end.

Well, remember that memory leaks are caused by unused memory LOCATIONS, not just unused variables.

Kind of a definition difference. Basically, you DO have to delete the location before you reassign the variable, even if you're doing it in the same trigger.

Incidentally, I tried setting the periodic time higher, and the problem went away. I don't suppose anybody could diagnose this? I'm going to try a new system for the arcs, try to streamline it so it works properly, and is easier to read, I'll post my new code later when I'm done.

 

[spiwn]

He was talking about the trigger I posted.
As I said, I edited it.

 

[Xesirin]

New Code

Okay, my new code is alot more edit-friendly. It is separated into two triggers, but it is MUCH simpler.

• WARP FIELDS Lightning Init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set LightningLoc[0] = (Random point in WARP FIELDS <gen>)
    • Set LightningLoc[1] = (Random point in WARP FIELDS <gen>)
    • Lightning - Create a Mana Flare lightning effect from source LightningLoc[0] to target LightningLoc[1]
    • Set WARPLightning = (Last created lightning effect)
    • Custom script: call RemoveLocation(udg_LightningLoc[0])

• WARP FIELDS Lightning
  • Events
    • Time - Every 0.50 seconds of game time
  • Conditions
  • Actions
    • Set LightningLoc[0] = LightningLoc[1]
    • Set LightningLoc[1] = (Random point in WARP FIELDS <gen>)
    • Lightning - Move WARPLightning to source LightningLoc[0] and target LightningLoc[1]
    • Custom script: call RemoveLocation(udg_LightningLoc[0])

This thing didn't fail even after letting it run a long time, so I feel confident that it will work in the long run. So if anybody sees something wrong with it, I'd like to know.