[JASS] Library problems

[Paladon]

Hello there!

Here's my library:

library Init
function InitTrig_GSystem takes nothing returns nothing    
    local integer i
    local group g
    local unit u
    local real x
    local real y
    set g = CreateGroup()
    call GroupEnumUnitsOfPlayer(g, Player(1),null)
    loop
        set u = FirstOfGroup(g)
        exitwhen u==null
        call GroupRemoveUnit(g,u)
        set i = (i+1)
        call SetUnitUserData(u,i)
        set x = GetUnitX(u)
        set y = GetUnitY(u)
        set udg_Creep_Point[i] = Location(x,y)
    endloop
    call FogEnable(false)
    call FogMaskEnable(false)
    set g = null
    set u = null
endfunction
endlibrary

Everytime i save, i get an error message telling me that the end of the line is somehow missing.

How to solve that?

And if there are any other flaws in there, please report them to me.
I'm a beginner

 

[busterkomo]

It compiles fine for me. The syntax checker in the trigger editor in NewGen will give the impression that your code is severely wrong. However, it will save and run fine, so there isn't a worry.

A few tips:

set x = GetUnitX(u)
set y = GetUnitY(u)
set udg_Creep_Point[i] = Location(x,y)

Can easily optimize into:

set udg_Creep_Point[i] = Location(GetUnitX(u),GetUnitY(u))

Without the need for any x or y variables. Also, since your converting coordinates to a location, it seems like a waste to use them in the first place:

set udg_Creep_Point[i] = GetUnitLoc(u)

 

[Dynasti]

Oh dear, Paladon using vJass. This is worse that I thought.

Well nvm that.

Here is a fix for all your troubles

// Super simple library that sets the time of the day and displays a message :)
library TestMapSystems initializer Init
    globals
        private constant real TimeOfDay = 0.0
        private constant string WelcomeMessage = "TestMapSystems v 1.0"
    endglobals
    
    private function Init takes nothing returns nothing
        call BJDebugMsg(WelcomeMessage)
        call SetFloatGameState(GAME_STATE_TIME_OF_DAY, TimeOfDay)
        call FogMaskEnable(false)
        call FogEnable(false)
    endfunction
endlibrary

// Simple TreeRespawn system
library TreeRespawn initializer Init

    globals
        private constant real Time = 20.
        
        private trigger Act
    endglobals
    
    private function W2D takes widget w returns destructable
        return w
        return null
    endfunction

    private function Actions takes nothing returns nothing
        local destructable Tree = W2D(GetTriggerWidget())
        local real X = GetWidgetX(Tree)
        local real Y = GetWidgetY(Tree)
        local real L = GetWidgetLife(Tree)
            
        call TriggerSleepAction(Time)
            
        call DestructableRestoreLife(Tree, L, true)
            
        set Tree = null
    endfunction
        
    private function Filter takes nothing returns nothing
        local destructable d = GetEnumDestructable()
        call TriggerRegisterDeathEvent(Act, d)
        set d = null
    endfunction

    private function Init takes nothing returns nothing
        set Act = CreateTrigger()
        call TriggerAddAction(Act, function Actions)
        set bj_wantDestroyGroup = true
        call EnumDestructablesInRect(bj_mapInitialPlayableArea, null, function Filter)
    endfunction
endlibrary

// Simple Unit Revive System for a player
library ReviveSystem initializer Init

    globals
        private constant player P = Player(PLAYER_NEUTRAL_AGGRESSIVE)
        
        private constant real Time = 60. //Sec.
        private constant real Life = 100. //%
        private constant real Mana = 50. //%
            
        private integer array T // Type
        private real array X // X
        private real array Y // Y
        private real array F // Facing
    endglobals

    private function Conditions takes nothing returns boolean
        return IsUnitAlly(GetTriggerUnit(), P) == true and GetUnitUserData(GetTriggerUnit()) > 0
    endfunction

    private function Actions takes nothing returns nothing
        local unit u = GetTriggerUnit()
        local integer i = GetUnitUserData(u)
            
        call TriggerSleepAction(Time)
        
        call RemoveUnit(u)

        set u = CreateUnit(P, T[i], X[i], Y[i], F[i])
        call SetUnitUserData(u, i)
            
        call SetUnitState(u, UNIT_STATE_LIFE, GetUnitState(u, UNIT_STATE_MAX_LIFE) * Life * 0.01)
        call SetUnitState(u, UNIT_STATE_MANA, GetUnitState(u, UNIT_STATE_MAX_MANA) * Mana * 0.01)
            
        set u = null
    endfunction

//===========================================================================
    private function SetupFilter takes nothing returns boolean
        return IsUnitAlly(GetFilterUnit(), P)
    endfunction

    private function Init takes nothing returns nothing
        local trigger trg = CreateTrigger()
        local group g = CreateGroup()
        local unit u
        local integer i = 1
        call TriggerRegisterAnyUnitEventBJ( trg, EVENT_PLAYER_UNIT_DEATH )
        call TriggerAddCondition( trg, Condition( function Conditions ) )
        call TriggerAddAction( trg, function Actions )

        call GroupEnumUnitsInRect(g, bj_mapInitialPlayableArea, Condition(function SetupFilter))
        loop
            set u = FirstOfGroup(g)
            exitwhen u == null
                
            set T[i] = GetUnitTypeId(u)
            set X[i] = GetUnitX(u)
            set Y[i] = GetUnitY(u)
            set F[i] = GetUnitFacing(u)
            call SetUnitUserData(u, i)
                
            set i = i + 1
            call GroupRemoveUnit(g, u)
        endloop

        call DestroyGroup(g)
        set trg = null
        set g = null
    endfunction

endlibrary

 

[RolePlaynGamer]

What version of JNGP/JassHelper are you using?

Here's a few tips:

1. Use library initializers instead. There's not reason for this, I just think everyone should get used to it.
2. The script won't work, you declare a local integer with no initial value, so when you set the variable to +1, the thread will crash, because of the missing initial value.
3. Passing a "null" parameter to boolexpr's will leak. BoolexprUtils,
4. You forget to destroy the group.
5. No need to nullify the unit variable.

Hope these helped a little, =]

 

[Dynasti]

Btw pally, I can't seem to find the problem, except that you are using locations

 

[Paladon]

Errors over errors.
Who can link me to the newest JassNewGen version?

 

[Deaod]

Jass NewGen Pack v5b - Wc3campaigns

 

[Paladon]

Okay, the problem was neither the JassNewGenPack nor the library.
I simply forgot to enable the JassHelper.

However, i'm still having problems.

After hititng the 'test' button, warcraft instantly returns to the main menu, and i saved the map before (!).

 

[Eccho]

Save it twice. You should see JassHelper kicking in when the script is compiling.
If not, check that the JNGP is located on the same partition as your saved file. It seems to have caused several problems to me.

 

[Paladon]

Saved it twice, and checked it. I still have the same problem.

 

[Eleandor]

Don't scroll through your code after saving. Make sure there's no "*" at the end of the filename in world editor before testing your map.

 

[Paladon]

Yep, payed attention to that.
Still, it goes to the main menu.
If i remeove some natives and all vJass stuff, like libraries, it works.

 

[Eleandor]

Does it save correctly? (jasshelper doesn't give any errors when saving?)

 

[Paladon]

It gives.
Everything is how it should be.

Jass Helper gives error messages while saving, the code works for everyone except me.
If i delete all libraries, loops, global settings and if-thens, it apparently works.
But not if i use them.

 

[Dynasti]

Then your JNGP wont compile the vJass script for some reason :S

 

[Livirus]

I am often experiencing the same problem (Wc3 menu shows up when testing) but it always goes away after saving once again.

 

[Paladon]

I tried saving twice and more, without doind anything between the saves, and it did not help.

 

[Deaod]

you could at least post the errors. How are we supposed to fix something we dont know anything about.

 

[Paladon]

...

Read the previous posts.
No errors.

Whenever i test the map, warcraft instantly returns to the main menu.

 

[Shadow Daemon]

Hmm, I have the same problem, when I tried to save map with russian symbols, and with too long name. Save your map to e.g. "C:\123.w3x", save again and see, what happens when you press "Test map" button.

Also, make sure that you haven't disabled vJass syntax (but, according to previous posts, I doubt that is disabled).

 

[Paladon]

Did not work.

And that would not explain why the map (and vJass) works for everyone else.

EDIT: I am stupid. It was simple. Nothing more, it is finally

 

[Dynasti]

solved.

lulwut? D:
What did you do wrong?

 

[Paladon]

Aaaaawkward...

Burn me in eternal flames, the JassNewGenPack was not located in the directory of Warcraft.

 

[Sabertooth]

Neither is mine though. Mine's in a folder on my desktop. Odd, but whatever, glad your problem is solved.

 

[busterkomo]

Aaaaawkward...

Burn me in eternal flames, the JassNewGenPack was not located in the directory of Warcraft.

Mine is on my desktop, and I have always stopped that problem by simply re-saving my map. Anyways, glad to hear your problem is fixed, Paladon (the stress it must have caused...).

 

[Eleandor]

That shouldn't in theory be a problem. But perhaps it didn't find the path to your warcraft 3 installation. If you still want to keep newgen out of wc3 folder, try running newgen/findpath.lua

 

[Eccho]

Nope, I already said that to him, since he was using v1.21b at first. So I gave him that tip and he changed the path... but it didn't work

A good tip tho .-. and a weird problem even if he got it fixed now.