[Trigger] Lags when using create units

fire_god · May 23, 2009

okay, i use this trigger

Create 9 Zombie in region a
wait 2 seconds
Create 9 zombie in region b
wait 2 seconds
Create 9 zombie in region c
wait 2 seconds
etc
etc
etc
Create 9 zombie in region i

if i add it up i have created 81 units using that trigger, but the problem is everytime the trigger create units, it will heavily lag, i thought its just too many unit in the same time that's why i add the wait function, but it still lags even when they only create 9 units in one time...

can somebody fix this trigger.?

Lord_BoNes · May 23, 2009

Does the lag happen from the first time it runs? Or is it only after a while?

fire_god · May 23, 2009

i tried it several times, it seems everytime the trigger runs... maybe i have to post the trigger? (actually i know it leaks, but doesn't know which part)

Amigurumi · May 23, 2009

first, save the locs where the zombies should spawn into a variable.
then, after each 'Create blabla' you make custom script: call RemoveLocation(udg_VARIABLE)
then it should be leakless.
say if you need an example.

fire_god · May 23, 2009

do i have to destroy the unit group too to avoid leaks?

Amigurumi · May 23, 2009

I'm not shure that you have to do it when you create units. You should fix the point leaks
and then it should be alright, without any leaks

fire_god · May 23, 2009

okay i haven't tried it yet, but actually it lags when the trigger create units, does it really the region problem?

Amigurumi · May 23, 2009

yep, the system creates for that a region, and after the unit spawned, it doesn't remove it.
so after some seconds/minutes, it begins to lag, because there are a lot of regions.

Events
Your Event
Conditions
Your Conditions
Actions
set TempPoint = Center of Playable Map area
Unit - Create 1 Zombie for Player 1 at TempPoint facing 270
Custom Script - call RemoveLocation(udg_TempPoint)

fire_god · May 23, 2009

Amigurumi said:
yep, the system creates for that a region, and after the unit spawned, it doesn't remove it.
so after some seconds/minutes, it begins to lag, because there are a lot of regions.

Events

Your Event

Conditions

Your Conditions

Actions

set TempPoint = Center of Playable Map area

Unit - Create 1 Zombie for Player 1 at TempPoint facing 270

Custom Script - call RemoveLocation(udg_TempPoint)

my trigger lags only when it create units.... hmm is there any other possibilities? but of course i will try all of this out, thanks

:thumbs_up:

Amigurumi · May 23, 2009

fire_god said:
my trigger lags only when it create units.... hmm is there any other possibilities?

When the trigger creates units, it must create a point where the unit will spawn.
so there are point leaks. I think it hasn't to do with the units, except you have over 300 units on your map

Reaper2008 · May 23, 2009

Locations must be destroyed. But for groups and globals use

Actions
- Custom script: call GroupClear(udg_VARIABLE)

to clear them, if it will be used again.

Amigurumi · May 23, 2009

Reaper2008 said:
Locations must be destroyed. But for groups and globals use

Actions

Custom script: call GroupClear(udg_VARIABLE)

to clear them, if it will be used again.

If you create a unit with

Actions
set TempPoint = Center of Playable Map area
Unit - Create 1 Footman for (Player 1 Red) at TempPoint facing 270 degrees
Custom script: call RemoveLocation(udg_TempPoint)

does it create a unit group which leak?

M4stah · May 23, 2009

Nope. It doesn't create a dynamic unti group does it?

fire_god · May 23, 2009

okay maybe i just post my script here

Spawning Zombie
- Events
  - Unit - A unit enters Zombie Select <gen>
- Conditions
  - The Summoner 0054 <gen> Equal to (Entering unit)
- Actions
  - Set SpawnPoint[0] = (Center of Spawn 1 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[0] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[0])
  - Wait 2.00 seconds
  - Set SpawnPoint[1] = (Center of Spawn 2 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[1] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[1])
  - Wait 2.00 seconds
  - Set SpawnPoint[2] = (Center of Spawn 3 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[2] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[2])
  - Wait 2.00 seconds
  - Set SpawnPoint[3] = (Center of Spawn 4 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[3] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[3])
  - Wait 2.00 seconds
  - Set SpawnPoint[4] = (Center of Spawn 5 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at (Center of Spawn 5 <gen>) facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[4])
  - Wait 2.00 seconds
  - Set SpawnPoint[5] = (Center of Spawn 7 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at (Center of Spawn 7 <gen>) facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[5])
  - Wait 2.00 seconds
  - Set SpawnPoint[6] = (Center of Spawn 8 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[6] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[6])
  - Wait 2.00 seconds
  - Set SpawnPoint[7] = (Center of Spawn 9 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[7] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[7])
  - Unit - Move (Entering unit) instantly to (Center of The Summoner Spot <gen>)

i'm curious about the point leaks.. but my trigger use region, so maybe i just have to use destroy region function?

Dr Super Good · May 23, 2009

Lag is caused by creating too many units at the same location.
Create all 9 of the zombies at different locations and it will not lag.

Amigurumi · May 23, 2009

do this:

Trigger
- Events
  - Unit - A unit enters YourRect
- Conditions
  - (Entering unit) Equal to YourUnit
- Actions
  - Set TempPoint = (YourRect)
  - Unit - Create 9 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
  - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - Set TempPoint = (YourRect)
  - Unit - Create 9 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
  - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - Set TempPoint = (YourRect)
  - Unit - Create 9 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
  - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - Set TempPoint = (YourRect)
  - Unit - Create 9 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
  - Custom script: call RemoveLocation(udg_TempPoint)
  - etc.

The variable TempPoint is a Point variable.
Just use this, and your trigger is leakless.

Dr Super Good · May 23, 2009

It is not leaks for crying out loud causing the lag, it is the fact that WC3 sucks when having to displace 9 units which are at the same point so that they are not in each others collision radius.

I easilly can create 8 units at a time with no lag in my green circle TD, but I create each unit at a totally unique position.
However as soon as the pathing system overloads and units are not moving out fast enough, lag starts to occur.
Thus I stick with my diagnosis that it is caused by creating 9 units at the same time at the same point.

fire_god · May 23, 2009

Dr Super Good said:
Lag is caused by creating too many units at the same location.
Create all 9 of the zombies at different locations and it will not lag.

which means i better to divide the 9 zombie from 1 region to 3 zombie with 3 region right?

oh yeah this is my trigger, edited now with the destroy function (same as page 1)

Spawning Zombie
- Events
  - Unit - A unit enters Zombie Select <gen>
- Conditions
  - The Summoner 0054 <gen> Equal to (Entering unit)
- Actions
  - Set SpawnPoint[0] = (Center of Spawn 1 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[0] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[0])
  - Wait 2.00 seconds
  - Set SpawnPoint[1] = (Center of Spawn 2 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[1] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[1])
  - Wait 2.00 seconds
  - Set SpawnPoint[2] = (Center of Spawn 3 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[2] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[2])
  - Wait 2.00 seconds
  - Set SpawnPoint[3] = (Center of Spawn 4 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[3] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[3])
  - Wait 2.00 seconds
  - Set SpawnPoint[4] = (Center of Spawn 5 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at (Center of Spawn 5 <gen>) facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[4])
  - Wait 2.00 seconds
  - Set SpawnPoint[5] = (Center of Spawn 7 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at (Center of Spawn 7 <gen>) facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[5])
  - Wait 2.00 seconds
  - Set SpawnPoint[6] = (Center of Spawn 8 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[6] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[6])
  - Wait 2.00 seconds
  - Set SpawnPoint[7] = (Center of Spawn 9 <gen>)
  - Unit - Create 9 Zombie for Player 12 (Brown) at SpawnPoint[7] facing (Position of Zombie 0031 <gen>)
  - Custom script: call RemoveLocation(udg_SpawnPoint[7])
  - Unit - Move (Entering unit) instantly to (Center of The Summoner Spot <gen>)

Dr Super Good · May 23, 2009

no, you are better to divide the 9 zombies into 9 points. Nothing to do with regions at all. If you mean you have to use the rects as a guide system where to spawn them, then use a random point within the rect as a spawn point and spawn each at a different random point within the rect.
As it then becomes statistically impossiable for 2 points to be exactly the same, it should no longer have to displace units as much and so will not lag.

Remember to remove leaks as well, as they can also create lag if enough occur.

fire_god · May 23, 2009

so basically, my current trigger lags when create units because i haven't issued exact position from created unit, which cause two or more created unit have same spot when they are created right?

Amigurumi · May 23, 2009

Untitled Trigger 001
- Events
- Conditions
- Actions
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = (Center of (Playable map area))
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)

Better?

fire_god · May 23, 2009

oh yeaah... the loop function..

i just have to set the TempPoint to integer of the location right?

wait a minute, how do i use the RemoveLocation funcrion? do i have to give

SpawnPoint[0]
SpawnPoint[1]
SpawnPoint[2]
etc
etc

in the RemoveLocation script?

Amigurumi · May 23, 2009

you need no TempPoint[1,2,3,etc.], just set the TempPoint to your point...
set TempPoint = Rect1
Actions
call RemoveLocation(udg_TempPoint)
set TempPoint = Rect 2
Actions
call RemoveLocation(udg_TempPoint)
...

fire_god · May 23, 2009

umm sorry for asking too much, can i have the full trigger..?

i never used that kind of scripts before..

Amigurumi · May 23, 2009

Spawn Zombies
- Events
  - Unit - A unit enters YourRect
- Conditions
  - (Entering unit) Equal to YourUnit
- Actions
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = Spawn1
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = Spawn2
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = Spawn3
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = Spawn4
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = Spawn5
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = Spawn6
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = Spawn7
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)
  - Wait 2.00 seconds
  - For each (Integer A) from 1 to 9, do (Actions)
    - Loop - Actions
      - Set TempPoint = Spawn8
      - Unit - Create 1 Zombie for Player 12 (Brown) at TempPoint facing Default building facing (270.0) degrees
      - Custom script: call RemoveLocation(udg_TempPoint)
  - Set TempPoint = Spawn7
  - Unit - Move (Entering unit) instantly to TempPoint
  - Custom script: call RemoveLocation(udg_TempPoint)

This is the trigger... (I hate it to do the same thing eight times.. xD )

Dr Super Good · May 23, 2009

.... Something tells me that will not fix the problem. . .

You have to make sure not to spawn units ontop of or within the collision radius of already existing units.

Amigurumi · May 23, 2009

Dr Super Good said:
.... Something tells me that will not fix the problem. . .

You have to make sure not to spawn units ontop of or within the collision radius of already existing units.

hmm tested it, and there was no lag, so I think it works... but it also could be my computer... I don't know

Super-Sheep · May 23, 2009

Initialization
- Events
  - Map initialization
- Conditions
- Actions
  - Set SpawnPoint[1] = (Center of Region 1 <gen>)
  - Set SpawnPoint[2] = (Center of Region 2 <gen>)
  - Set SpawnPoint[3] = (Center of Region 3 <gen>)

Spawn
- Events
  - Time - Every 5.00 seconds of game time
- Conditions
- Actions
  - For each (Integer A) from 1 to 3, do (Actions)
    - Loop - Actions
      - Unit - Create 1 Peon for Player 1 (Red) at SpawnPoint[(Integer A)] facing 0.00 degrees

You could check on second trigger if the point is pathable or not, if not, then set SpawnPoint[(Intger A)] = offset 50 or something. But I couldnt find this action.

Dr Super Good · May 23, 2009

It seems only certain map points are prone to this problem, somethings it creates no lag while at other points it does.

fire_god · May 24, 2009

Dr Super Good said:
It seems only certain map points are prone to this problem, somethings it creates no lag while at other points it does.

can you give me example.. which points are prone to this problem?

Dr Super Good · May 24, 2009

No, but I have noticed lag when units are moved into each other or made ontop of units in various wc3 maps.

Amigurumi · May 24, 2009

It had a lag, when all the zombies spawn in the same moment at one rect...
but when every 2 seconds only 9 spawn at one rect, there is no lag.
I think, it depends on the unit count

Dr Super Good · May 24, 2009

WC3's displacement is poor and demanding. One unit at a time produces minimal lag. I am sure even 9 units at one point are ok if your PC is better than mine. But if you have to displace 72 units at once, then logically it will lag a lot more.

Reaper2008 · May 24, 2009

Don't know, I've spawned 16 units together many times within a single game, and noticed no lag, even though I had a memory leak (good old GUI days). Then again, my PC is only 1 year old.

[Trigger] Lags when using create units

Similar threads