JASS how to break loop?

[Pinzu]

Conditions not working!

function Ability_Interact takes nothing returns boolean
    local integer idD = GetDestructableTypeId(GetSpellTargetDestructable())
    return GetSpellAbilityId() == 'ACfn' and (idD == 'LTe2' or idD == 'LTg1')
endfunction

function Gate_Interaction_Actions takes nothing returns nothing
    local player p = GetTriggerPlayer()
    local destructable TargetedGate = GetSpellTargetDestructable()
    local real x = GetLocationX(GetRectCenter(gg_rct_Options_Spawn))
    local real y = GetLocationY(GetRectCenter(gg_rct_Options_Spawn))
    local integer PlayerNum = GetConvertedPlayerId(p)
    local integer GateArray
    local integer i = 0
    set udg_InteractionCurrentTarget_d[PlayerNum] = TargetedGate
    loop
        exitwhen i > udg_GateCount
        if (udg_Gate[i] == TargetedGate) then
            set GateArray = i
            set i = udg_GateCount + 1
            else
            set i = i + 1
        endif
    endloop

// Abilities: Open - 'A005', Close - 'A006', Lock 'Aslp', Unlock - 'A008', Knock - 'ACwe', Information - 'ACsf'

    set udg_InteractionCurrentTarget_i[PlayerNum] = GateArray 
    set udg_OptionsUnit[PlayerNum] = CreateUnit(p, 'hhou', x, y, 0.00 )
    call SelectUnitForPlayerSingle(udg_OptionsUnit[PlayerNum], p)
    call UnitAddAbilityBJ('ACsf', udg_OptionsUnit[PlayerNum])


    if (udg_GateStatus[GateArray] != 0) then // Status != Dead
    call UnitAddAbilityBJ('ACwe', udg_OptionsUnit[PlayerNum])


        if (udg_GateStatus[GateArray] == -2) then // Status = Closed and Locked
        call UnitAddAbilityBJ('ACwe', udg_OptionsUnit[PlayerNum]) 

            if (IsPlayerInForce(p, udg_GateControl_g[GateArray]) == true ) then //Player has control
            call UnitAddAbilityBJ('A005', udg_OptionsUnit[PlayerNum]) 
            call UnitAddAbilityBJ('A008', udg_OptionsUnit[PlayerNum]) 
            endif 
        endif

        if (udg_GateStatus[GateArray] == -1) then // Status = Closed and Unlocked
        call UnitAddAbilityBJ('A005', udg_OptionsUnit[PlayerNum]) 
            if (IsPlayerInForce(p, udg_GateControl_g[GateArray]) == true ) then 
            call UnitAddAbilityBJ('Aslp', udg_OptionsUnit[PlayerNum])
            endif 
        endif

        if (udg_GateStatus[GateArray] == 1) then // Status = Open and Locked
            if (IsPlayerInForce(p, udg_GateControl_g[GateArray]) == true ) then 
            call UnitAddAbilityBJ('A006', udg_OptionsUnit[PlayerNum]) 
            call UnitAddAbilityBJ('A008', udg_OptionsUnit[PlayerNum]) 
            endif 
        endif

        if (udg_GateStatus[GateArray] == 2) then // Status = Open and Unlocked
        call UnitAddAbilityBJ('A006', udg_OptionsUnit[PlayerNum]) 
            if (IsPlayerInForce(p, udg_GateControl_g[GateArray]) == true ) then  
            call UnitAddAbilityBJ('Aslp', udg_OptionsUnit[PlayerNum])
            endif 
        endif

    endif

    set p = null
    set TargetedGate = null

endfunction

//===========================================================================
function InitTrig_Gate_Interaction takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_CAST)
    call TriggerAddCondition(t, Condition(function Ability_Interact))
    call TriggerAddAction(t, function Gate_Interaction_Actions)
    set t = null
endfunction

function CheckForOptionsUnit takes nothing returns boolean
return GetUnitTypeId(GetTriggerUnit()) == 'hhou'
endfunction

function GateSpell_Actions takes nothing returns nothing

    local player p = GetTriggerPlayer() // Will probably use it more when I add messages.
    local integer i = udg_InteraCurTarget_i[GetConvertedPlayerId(p)]
    local destructable Gate = udg_Gate[i]
    local destructable GatePathing = udg_GatePathing[i]
    local integer PlayerNum = GetConvertedPlayerId(GetTriggerPlayer())
    local real y = GetLocationY(GetDestructableLoc(Gate))
    local real x = GetLocationX(GetDestructableLoc(Gate))
    local integer z = 1

if (udg_GateStatus[i] != 0) then // GateStatus != Broken

    if (GetSpellAbilityId() == 'A005') then // Open Gate
    call SetDestructableAnimationBJ(Gate, "death alternate")
    call SetDestructableInvulnerableBJ(Gate, true)
    call KillDestructable(GatePathing)

//Replaces abilities from eveyr player that has it avalible.

    loop
        exitwhen z > 11
            if (udg_InteraCurTarget_d[z] == udg_InteraCurTarget_d[PlayerNum]) then
            call UnitRemoveAbilityBJ( 'A005', udg_InteraOptions_u[z])
            call UnitAddAbilityBJ( 'A006', udg_InteraOptions_u[z])
            endif
            set z = z + 1
    endloop

//Takes the GateStatus and changes it to matching opposite.

        if (udg_GateStatus[i] == -2) then
            set udg_GateStatus[i] = 1  
        else
            set udg_GateStatus[i] = 2  
        endif
    endif    



    if (GetSpellAbilityId() == 'A006') then // Close Gate

    call SetDestructableAnimationBJ(Gate, "stand")
    call SetDestructableInvulnerableBJ(Gate, false)
    call DestructableRestoreLife(GatePathing, 250, true )

    loop
        exitwhen z > 11
            if (udg_InteraCurTarget_d[z] == udg_InteraCurTarget_d[PlayerNum]) then
            call UnitRemoveAbilityBJ( 'A006', udg_InteraOptions_u[z])
            call UnitAddAbilityBJ( 'A005', udg_InteraOptions_u[z])
            endif
            set z = z + 1
    endloop
            
        if (udg_GateStatus[i] == 1) then
            set udg_GateStatus[i] = -2
        else
            set udg_GateStatus[i] = -1
        endif  
    endif


    if (GetSpellAbilityId() == 'Aslp') then // Lock Gate

    call PlaySoundAtPointBJ(gg_snd_Lever, 100, Location(x, y), 1500.00)

    if (udg_GateStatus[i] == -1 ) then // GateStatus = Closed and Unlocked
        set udg_GateStatus[i] = -2
    else 
        set udg_GateStatus[i] = 1
    endif

    loop
        exitwhen z > 11
            if (udg_InteraCurTarget_d[z] == udg_InteraCurTarget_d[PlayerNum]) then
            call UnitRemoveAbilityBJ( 'Aslp', udg_InteraOptions_u[z])
            call UnitAddAbilityBJ( 'A008', udg_InteraOptions_u[z])
            endif
            set z = z + 1
    endloop
    endif


    if (GetSpellAbilityId() == 'A008') then // Unlock Gate

    call PlaySoundAtPointBJ(gg_snd_Lever, 100, Location(x, y), 1500.00)

    if (udg_GateStatus[i] == -2) then // GateStatus = Closed and Unlocked
        set udg_GateStatus[i] = -1
    else 
        set udg_GateStatus[i] = 2
    endif

    loop
        exitwhen z > 11
            if (udg_InteraCurTarget_d[z] == udg_InteraCurTarget_d[PlayerNum]) then
            call UnitRemoveAbilityBJ( 'A008', udg_InteraOptions_u[z])
            call UnitAddAbilityBJ( 'Aslp', udg_InteraOptions_u[z])
            endif
            set z = z + 1
        endloop
    endif


    if (GetSpellAbilityId() == 'ACwe') then // Knock On Gate
    if ((udg_GateOwner[i] != Player(11)) and (udg_GateOwner[i] == p)) then
    call PingMinimapLocForForceEx( GetForceOfPlayer(udg_GateOwner[i]), Location(x, y), 4.00, bj_MINIMAPPINGSTYLE_SIMPLE, 100, 100, 100)
    call DisplayTextToForce(GetForceOfPlayer(udg_GateOwner[i]), "Alert: Someone is knocking on your door...")
    endif
    call PlaySoundAtPointBJ(gg_snd_DoorKnock, 100, Location(x, y), 1500.00)
    call TriggerSleepAction(0.25)
    call PlaySoundAtPointBJ(gg_snd_DoorKnock, 100, Location(x, y), 1500.00)
    call TriggerSleepAction(0.25)
    call PlaySoundAtPointBJ(gg_snd_DoorKnock, 100, Location(x, y), 1500.00)
    call TriggerSleepAction(0.25)
    endif
endif

    set p = null
    set Gate = null
    set GatePathing = null
    
endfunction

//===========================================================================
function InitTrig_Gate_Spells takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_CAST)
    call TriggerAddCondition(t, Condition( function CheckForOptionsUnit))
    call TriggerAddAction(t, function GateSpell_Actions)
    set t = null
endfunction

 

[deathismyfriend]

u have to set local integer i to a value and then it will work

 

[Pinzu]

u have to set local integer i to a value and then it will work

I belive the problem is in condition, but I can try. You apear to have been right, cudos!

 

[deathismyfriend]

theres a couple other things u should change if u want me to list them ?

 

[Pinzu]

Yes please, just started with jass

I have destroyed the player and destructible leaks already though.

 

[deathismyfriend]

here u go u can just copy and paste this just change the integer i to what u changed it to

on a note try to watch out for any things tht appear red try to look in function list for stuff tht is a native ( purple color ) and change it to tht

 

[Pinzu]

here u go u can just copy and paste this just change the integer i to what u changed it.

You sure about the or in the begining, the ability must always be true, and then check for the target.

Im not using any software so everything is in black, that wont do thought...

 

[deathismyfriend]

if all three abilities need to be true change or to and sry forgot to add tht note if only one of the abilities need to be true keep them or

i see what u mean i misread the one thing here copy this one

//===============================
// THIS PART IS NOT WORKING, THE TRIGGER NEVER RUNS? ;(
//===============================

function Ability_Interact takes nothing returns boolean
    local integer idD = GetDestructableTypeId(GetSpellTargetDestructable())
    if GetSpellAbilityId() == 'ACfn' and ( idD == 'LTe2' or idD == 'LTg1' ) then
        return true
    else
        return false
    endif
endfunction

//===============================

function Gate_Interaction_Actions takes nothing returns nothing
    local player p = GetTriggerPlayer()
    local destructable Gate = GetSpellTargetDestructable()
    local real x = GetRectCenterX(GetRectCenterX(gg_rct_Options_Spawn))
    local real y = GetRectCenterY(GetRectCenterY(gg_rct_Options_Spawn))
    local integer PlayerNum = GetPlayerId(p)
    local integer GateArray
    local integer i = 0 // not sure what u changed it to 
    set udg_InteractionCurrentTarget_d[PlayerNum] = Gate
    loop
        exitwhen i > udg_GateCount
        if (udg_Gate[i] == GetSpellTargetDestructable()) then
            set GateArray = i
            set i = udg_GateCount + 1
            else
            set i = i + 1
        endif
    endloop
    call DisplayTextToForce( GetPlayersAll(), "HELLO!?" )
    set udg_OptionsUnit[PlayerNum] = CreateUnit( p, 'hhou', x, y, , 0.00 )
    call SelectUnitForPlayerSingle(udg_OptionsUnit[PlayerNum], p)
    call UnitAddAbility( udg_OptionsUnit[PlayerNum], 'ACsf' )
    

endfunction

//===========================================================================
function InitTrig_Gate_Interaction takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_CAST)
    call TriggerAddCondition(t, Condition(function Ability_Interact))
    call TriggerAddAction(t, function Gate_Interaction_Actions)
    set t = null
endfunction

 

[Pinzu]

That looks very clean

Why can't this part be changed to:

if (udg_Gate[i] == Gate) then

 

[deathismyfriend]

also i just noticed the local integer GateArray is not doing anything

local variables basically wipe themselves from memory after the trigger is finished running

i also missed this

at the end of ur trigger do
not sure if u have to set destructibles to null

set p = null

//===============================
// THIS PART IS NOT WORKING, THE TRIGGER NEVER RUNS? ;(
//===============================

function Ability_Interact takes nothing returns boolean
    local integer idD = GetDestructableTypeId(GetSpellTargetDestructable())
    if GetSpellAbilityId() == 'ACfn' and ( idD == 'LTe2' or idD == 'LTg1' ) then
        return true
    else
        return false
    endif
endfunction

//===============================

function Gate_Interaction_Actions takes nothing returns nothing
    local player p = GetTriggerPlayer()
    local destructable Gate = GetSpellTargetDestructable()
    local real x = GetRectCenterX(GetRectCenterX(gg_rct_Options_Spawn))
    local real y = GetRectCenterY(GetRectCenterY(gg_rct_Options_Spawn))
    local integer PlayerNum = GetPlayerId(p)
    local integer GateArray
    local integer i = 0 // not sure what u changed it to 
    set udg_InteractionCurrentTarget_d[PlayerNum] = Gate
    loop
        exitwhen i > udg_GateCount
        if (udg_Gate[i] == GetSpellTargetDestructable()) then
            set GateArray = i
            set i = udg_GateCount + 1
            else
            set i = i + 1
        endif
    endloop
    call DisplayTextToForce( GetPlayersAll(), "HELLO!?" )
    set udg_OptionsUnit[PlayerNum] = CreateUnit( p, 'hhou', x, y, , 0.00 )
    call SelectUnitForPlayerSingle(udg_OptionsUnit[PlayerNum], p)
    call UnitAddAbility( udg_OptionsUnit[PlayerNum], 'ACsf' )
    set p = null
endfunction

//===========================================================================
function InitTrig_Gate_Interaction takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_CAST)
    call TriggerAddCondition(t, Condition(function Ability_Interact))
    call TriggerAddAction(t, function Gate_Interaction_Actions)
    set t = null
endfunction

 

[Maker]

See what I did here?

function Ability_Interact takes nothing returns boolean
    local integer idD = GetDestructableTypeId(GetSpellTargetDestructable())
    return GetSpellAbilityId() == 'ACfn' and ( idD == 'LTe2' or idD == 'LTg1' )
endfunction

What is this?

local real x = GetRectCenterX(GetRectCenterX(gg_rct_Options_Spawn))
local real y = GetRectCenterY(GetRectCenterY(gg_rct_Options_Spawn))

 

[Pinzu]

See what I did here?

function Ability_Interact takes nothing returns boolean
    local integer idD = GetDestructableTypeId(GetSpellTargetDestructable())
    return GetSpellAbilityId() == 'ACfn' and ( idD == 'LTe2' or idD == 'LTg1' )
endfunction

What is this?

local real x = GetRectCenterX(GetRectCenterX(gg_rct_Options_Spawn))
local real y = GetRectCenterY(GetRectCenterY(gg_rct_Options_Spawn))

So that the point doesnt leak? :S

 

[deathismyfriend]

yup always use x and y instead of locations

 

[Pinzu]

This line isnt working: set udg_OptionsUnit[PlayerNum] = CreateUnit( p, 'hhou', x, y, , 0.00 )

Not when I change it to this either:
set udg_OptionsUnit[PlayerNum] = CreateUnit( p, 'hhou', Location(x, y), 0.00 )

I want to make a while loop running every 0.5 seconds updating this as long as the LastCreatedUnit is selected or perhaps its wiser to separate the cleanup from this trigger...

 

[Maker]

This line isnt working: set udg_OptionsUnit[PlayerNum] = CreateUnit( p, 'hhou', x, y, , 0.00 )

There's an extra ","

 

[Pinzu]

I want to make a while loop that updates as long as the CreatedUnit is the only selected unit of the triggering player.

loop
    exitwhen (CurrentSelectionCondition??)
     
 if () then
add ability X
else remove ability X
endif
 if () then 
add ability y
else remove ability y
endif
... etc... 
    call TriggerSleepAction( 0.20 )
endloop

end trigger

and when its no longer selected everything is flushed.

There will be 11 players in my map and this 11 possible interactions running at the same time, is this feasable or should I create a seperate trigger for every interaction trigger?

Gate interaction is but one.

 

[Maker]

Register deselection event for a trigger instead of using a loop.

 

[Pinzu]

Register deselection event for a trigger instead of using a loop.

Problem would be that I dont know how much objects you can interact with, and if I could change the options in the same trigger perhaps it would be easier to make?

Is it really that bad with 11 loops running every 0.2 seconds (maximum) Well that and other triggers that use stuff like that ;


I was thinking that the deselectiong event would be another trigger that changes the CurrentSelectionUnit[PlayerNum]

and then a condition in that loop would recognize that the selection is no longer the same.

Hmm perhaps this is just a brainfart. And not relevant.

It's basically finnished.



Something is messed up with Gate Spells (second one)... The abilities for one are not replaced properly. Gonna relocate most of those conditions...

Edit, found the issue, I ussed two different variables for the Options unit.

Edit 2, Okey I'm finnished any feedback on the functionality of it is greatly valued.

 

[deathismyfriend]

Did u get the updated one I sent ? It removed a lot of useless stuff

 

[Dr Super Good]

"exitwhen true" will break a loop.

 

[Pinzu]

Did u get the updated one I sent ? It removed a lot of useless stuff

Yep, I updated it now. Should I add a condition another condition in the begining so that the locals arn't created and destroyed for no reason?

 

[deathismyfriend]

i meant u should update it on here lol ur first post is still the old version locals are always destroyed just limit it down to the lowest amount of locals u need

 

[Pinzu]

i meant u should update it on here lol ur first post is still the old version locals are always destroyed just limit it down to the lowest amount of locals u need

Okay, Changed that. Last things I would like to add is a cooldown to added ability and fix the sound not playing if you spam the trigger. (Lock sound) And perhaps that the unit goes near the gate when interacting with it. And a while loop hmm..

 

[deathismyfriend]

ya the sound im not sure about how to play it with the x, y coordinates u can do location but im pretty sure tht leaks